From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AF60C56202 for ; Wed, 25 Nov 2020 16:38:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 077F82083E for ; Wed, 25 Nov 2020 16:38:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 077F82083E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 70E876B0070; Wed, 25 Nov 2020 11:38:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6969D6B0072; Wed, 25 Nov 2020 11:38:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5846B6B0073; Wed, 25 Nov 2020 11:38:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id 3FC226B0070 for ; Wed, 25 Nov 2020 11:38:14 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id EDF75181AEF3E for ; Wed, 25 Nov 2020 16:38:13 +0000 (UTC) X-FDA: 77523498066.15.toes56_331142827378 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id C8FCF1814B0C7 for ; Wed, 25 Nov 2020 16:38:13 +0000 (UTC) X-HE-Tag: toes56_331142827378 X-Filterd-Recvd-Size: 2456 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Nov 2020 16:38:13 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 36C47AC22; Wed, 25 Nov 2020 16:38:12 +0000 (UTC) Subject: Re: [PATCH v5 4/4] mm,hwpoison: drop unneeded pcplist draining To: Oscar Salvador , n-horiguchi@ah.jp.nec.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20201013144447.6706-1-osalvador@suse.de> <20201013144447.6706-5-osalvador@suse.de> From: Vlastimil Babka Message-ID: <75488d50-02e5-c766-2c27-16b776c5c9c1@suse.cz> Date: Wed, 25 Nov 2020 17:38:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201013144447.6706-5-osalvador@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/13/20 4:44 PM, Oscar Salvador wrote: > memory_failure and soft_offline_path paths now drain pcplists by calling > get_hwpoison_page. > > memory_failure flags the page as HWPoison before, so that page cannot > longer go into a pcplist, and soft_offline_page only flags a page as > HWPoison if 1) we took the page off a buddy freelist 2) the page was > in-use and we migrated it 3) was a clean pagecache. > > Because of that, a page cannot longer be poisoned and be in a pcplist. > > Signed-off-by: Oscar Salvador Acked-by: Vlastimil Babka > --- > mm/madvise.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 416a56b8e757..c6b5524add58 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -877,7 +877,6 @@ static long madvise_remove(struct vm_area_struct *vma, > static int madvise_inject_error(int behavior, > unsigned long start, unsigned long end) > { > - struct zone *zone; > unsigned long size; > > if (!capable(CAP_SYS_ADMIN)) > @@ -922,10 +921,6 @@ static int madvise_inject_error(int behavior, > return ret; > } > > - /* Ensure that all poisoned pages are removed from per-cpu lists */ > - for_each_populated_zone(zone) > - drain_all_pages(zone); > - > return 0; > } > #endif >