From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66C1FC7EE29 for ; Thu, 25 May 2023 21:16:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9D406B0074; Thu, 25 May 2023 17:16:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4BB26B0075; Thu, 25 May 2023 17:16:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9F20900003; Thu, 25 May 2023 17:16:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 96E026B0074 for ; Thu, 25 May 2023 17:16:49 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 32CF5140712 for ; Thu, 25 May 2023 21:16:49 +0000 (UTC) X-FDA: 80830036938.15.4A40D0F Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by imf15.hostedemail.com (Postfix) with ESMTP id 5C452A0007 for ; Thu, 25 May 2023 21:16:47 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=OayEOOVE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of hughd@google.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685049407; a=rsa-sha256; cv=none; b=ZIDiCB+cDILIHUQIO3V59Z3K45M52Q/8bUtaNnTFS+YdGkfrsMITJl/dd2a8Uvyubh7ehl Qfy/qlrYBvvAw6FYV+p8T8z1sqaEkW7rPUtT2qI4n4NM0ZYq6CvxKMxP0hwPmfVM7z1I78 HqImkL0uSBB7uiksVyhO88V4GkUGxHw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=OayEOOVE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of hughd@google.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685049407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L9pQOGdYsjdZbdCHHypN1w7tMBLEjB+ZZ/4gmvVnzrE=; b=bOg/RBaTZhZt7ldANcVw6PK/Y8mHvekhEOc4TdfAqVXTy+TJHuQD48LhF/JHpbB49wSfSA Neltg0p5cftw9OxI6eWtIH0J1JatWVJVqYx1/K/umLlndi1lZj4UjfTRNIdcEcsxexOBlI TYNNd1oX486zgGm5hj+RDXXvOnMpXNk= Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-55db055b412so15543327b3.0 for ; Thu, 25 May 2023 14:16:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685049406; x=1687641406; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=L9pQOGdYsjdZbdCHHypN1w7tMBLEjB+ZZ/4gmvVnzrE=; b=OayEOOVEDoRCfVgPBQP7q3z8x8raeYdqUtCTiEzo/KCJT2OF/mliqW4VfVw3blftBB YB9D0kFzVJK4jUvggsNfjY/J8TSjLPHQCEa+bsaNfsJu957213ZxBXcctz5fwMsbudlf B+iEIyTXHb/Z3r1gdJGtM09lzyZFhu7QkO3GpWcMlW3KPGuHRrYGWKQP5LuS5IFzltat V8+Jc+THw7D+s8FCtrXddxKOOyuh8vmN3SZh5xV6urmV0BmGCVh99kdyy0QEH19dlWf0 5Di+Uk6uMV8gTVpTwVnHaEPGFyvLyfVNq3Ik5SIpizBO6wgKeIycuyYeqbcxXOKCGXNG lrpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685049406; x=1687641406; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L9pQOGdYsjdZbdCHHypN1w7tMBLEjB+ZZ/4gmvVnzrE=; b=NSdp3eCu/YK/qsJwHcevNk8WNu7DYP3nK2b4/foldpBjDptMUVWrWrILWp7Pdz4+00 NJpRRwCUYoHr1mXyNLwsm0/WH8q5eer5MAQKC+T1XditkvofO8xkYjcp60x/gU+j4JJu 8O6K6HkdrShHcGMiq0PgyGKQ2IlJp0lQpF+HUiyBbEhj1uuXs5rUcTBKrQkCdIU4cQ1r fC3pckQvjl+NlwB1lfFyvAUNqR2emzzAv5IaztuVNs3sho38TGZHTgsu7Q/nnx/uAUM1 B23OYlR2qc5ZfOUFkY42wgZKPaxq8kEh7nd6gejP80h6odqd0iMwauZ4+APru0fHP2im bGPQ== X-Gm-Message-State: AC+VfDzIIVnGGIbLOle4BNvT2L5Liai59qSG3OQG1+mWVp5zi2TJRuVF 8TsYAsYl+xK2NIv9pMaUwKh67A== X-Google-Smtp-Source: ACHHUZ7lPieMWiIbLy5ZAvMbt8Ai9mzflKlXhdst9cXNlI6EwObACsnmib2ZBLhQn0ABNPnTuOhCSw== X-Received: by 2002:a81:f207:0:b0:55a:776e:95f3 with SMTP id i7-20020a81f207000000b0055a776e95f3mr206336ywm.25.1685049406300; Thu, 25 May 2023 14:16:46 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id z141-20020a0dd793000000b0054c0a8ceb2fsm674804ywd.28.2023.05.25.14.16.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 May 2023 14:16:45 -0700 (PDT) Date: Thu, 25 May 2023 14:16:34 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Yang Shi cc: Hugh Dickins , Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 25/31] mm/gup: remove FOLL_SPLIT_PMD use of pmd_trans_unstable() In-Reply-To: Message-ID: <7538c751-9bee-75f9-50a5-1bc12f919e8e@google.com> References: <68a97fbe-5c1e-7ac6-72c-7b9c6290b370@google.com> <3d548f45-9ff9-d73a-83e0-bdd312f524@google.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463760895-1817524506-1685049405=:5227" X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5C452A0007 X-Stat-Signature: 5b5ew8io3syob8th35kxh4j4c1rbiihp X-HE-Tag: 1685049407-593103 X-HE-Meta: U2FsdGVkX18PmiihSLOFLZtyjGp0+MRi2b6uCvBljWIoXnpC1Vsh6JSCqE55uydb6oMlOBypd6zrCVy68xiP+atynLHmQGxoMLgzZc6n0q6MLDQ8WMZ9bHIyWmNbfocbcEsCoe+9JYL02Hns3a19qjykNXfEsNDBviBFJ6RDyEqxgHuhmIj28192pgfQvnAxXwkFlRkwcqkBuOFw5V3prFAw3nvVjqpb5SSo4RDN9WxKsIKC9M+UGhRUxOeGJKFxmzdNLwYhFMI6Fklx3cmlPlIf4TbqnOCdMYWg3wozKDwPBTjfy0+S5xZvm7HThF2mAYYewFFcyYDYAhx4VfogLmec5odiKu6OU7X+6F+idkWlzVwkoyFc2/tE8FbNlktnwiNQS6i6SVD1amF0ESxcGzFKTbzQ1YnnIATD+WHXWfzybi2pqPSiUrjwf8CN8Ebn0lqZZy47GYSocUqelW2X/N/WvdTgM/yUUTkhUmibkccN0wHqLFmFaA5QKsm5xwaPp62o1XtDhjp1bQK+83i+UutpVaKSwxz19YE7CuRHkBkt/7TIBPFBIFUNBgOvvIcfuz9t4NsozT+TXB23nVwELr13AY4T1zTkP4dynsWmLwQZ71ye305pKS6q02t4sVbLCvmZH9mHHORxZjUDiuoy4S+L3wMFNbGfvPZ7x/zyqfSIQWX85OgwoWaanwxC7wbPTv6wIESR0rdSY1mQOOdj8Xt8AyL9EXkbTbUwrTNXNNTV1qHRdU2oLwIaqawLBaXyzhkECIZuSR3n63qIk6tJ0/6W0OxnzBFiUEyxoFJgHIIuM0KEkc43ZlFPZPaKOW2GD4Xw2+TCNJZdYQ0rKtwEdzUlQdwkbnxIc7YSzdYsmpBa01Q3KW6bj6Jqc5bZhoNDkav0eElEEo/93r+1HGWTuhWjI91SLrKMxbPgSF3FtqvEC2rNUY+7MPggKbo45rfUQTfKb8bNwbYGAErrycF W/L9Q8b5 Y6RmSPrEEyxFjYCmw95qcbC5X06xSGpzh21NmmC1/X0kHbexfHQbEH9qKpCRWzBl+r0RnZYu6amlP3tep2+ZtfDbXR7ft5BJiWHQb8AYm9je1MEx7tyBxS8L8YTnguaYqB0bHeOX3iMjqVpRmuA14783DBfB0mOOpe6vM4P0yLC4suasUl+IUwjB4yHxwlAgkC1W4v7ADTejtAyMkvHCYTlVEKO73nppFHxMYwpNqFur2xAU2uUeMnxYsZDLs1dfhWF5xUD5IZGjseYM3Ct/CEPA03KEpCh2DfwD6lHwpqxXFOM7gEgFfm1WkPCjkKPWBCEcYdZs/FyKBue9qcR6JOltbd77VM2DozrdwUkvVBA8XeaqCzuA/gMrCcetHlkgWOQcauKb62jjsvYeIO4JFhnsBhVxdmFD+wWOXhHBOO/03SJpmSuK7Ywcx8FNJorYcVKkJdtOmOe461U7qKRf/1HlB3Vkd706saBqapyxSq7FvLOWtBs5ZCTqeIVAQaojGW3th X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463760895-1817524506-1685049405=:5227 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE On Wed, 24 May 2023, Yang Shi wrote: > On Tue, May 23, 2023 at 9:26=E2=80=AFPM Hugh Dickins w= rote: > > On Mon, 22 May 2023, Yang Shi wrote: > > > > > For other unstable cases, it will return -ENOMEM instead of -EBUSY. > > > > I don't think so: the possibly-failing __pte_alloc() only gets called > > in the pmd_none() case. >=20 > I mean what if pmd is not none for huge zero page. If it is not > pmd_none pte_alloc() just returns 0, Yes, I agree with you on that. > then returns -ENOMEM instead of -EBUSY. But disagree with you on that. =09=09return pte_alloc(mm, pmd) ? ERR_PTR(-ENOMEM) : =09=09=09follow_page_pte(vma, address, pmd, flags, &ctx->pgmap); Doesn't that say that if pte_alloc() returns 0, then follow_page_mask() will call follow_page_pte() and return whatever that returns? > Or it is impossible that pmd end up being pmd_huge_trans or > !pmd_present? It should be very unlikely, for example, migration does > skip huge zero page, but I'm not sure whether there is any corner case > that I missed. I'm assuming both are possible there (but not asserting that they are). Hugh ---1463760895-1817524506-1685049405=:5227--