From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3AAEC07E8F for ; Mon, 22 Apr 2024 07:53:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CB506B00A4; Mon, 22 Apr 2024 03:53:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 27DA76B00A5; Mon, 22 Apr 2024 03:53:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1431B6B00A6; Mon, 22 Apr 2024 03:53:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EB4346B00A4 for ; Mon, 22 Apr 2024 03:53:26 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6B063120AB3 for ; Mon, 22 Apr 2024 07:53:26 +0000 (UTC) X-FDA: 82036402812.22.BCDA96D Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf04.hostedemail.com (Postfix) with ESMTP id 1E2F94000E for ; Mon, 22 Apr 2024 07:53:23 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=none (imf04.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713772404; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=akDn4kU23Nv3ereNmCSiH77ghLc07ZU9uUFT2OLoQoE=; b=jPCBv0kMJbOEvxoWMjKLnO+wlEBV/AUFORmO0cJ+glab6IURQhx5ZYTaLpAEl08/hsWrcQ 9CdoKSVUKFEN53KfxkcVgwANMHnaxkJeN77iklXx7BWZuBnnhMCUPD0tZ145WKslRpBfQE JobPJgadN5Nabq0Owdcey+e7ccgWyCo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=none (imf04.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713772404; a=rsa-sha256; cv=none; b=gUZ1o9LXtVike5MLPBeUjMKLKGWiI6E3F5LHKTcwuGGYsbpNMGFm2UQCuPmewmf+Y6oqUd cEU3lxB5gmGBM/douni6mjjKQZ1smz4gnvWYBKaoKCNiaLpmPG9Q3eabb1ZWXEmGNUgsMT RWLAQ8EU6Ces94xL02Du+p1MeN+NzM4= Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4VNHYR46Ymz4f3jHm for ; Mon, 22 Apr 2024 15:53:15 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.75]) by mail.maildlp.com (Postfix) with ESMTP id 5AA251A0568 for ; Mon, 22 Apr 2024 15:53:20 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP2 (Coremail) with SMTP id Syh0CgA3kfRRFyZmPFqLKw--.43190S2; Mon, 22 Apr 2024 15:53:20 +0800 (CST) Subject: Re: [ATCH v3 0/4] Improve visibility of writeback From: Kemeng Shi To: akpm@linux-foundation.org, willy@infradead.org, jack@suse.cz, bfoster@redhat.com, tj@kernel.org Cc: dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org References: <20240422160539.3340-1-shikemeng@huaweicloud.com> Message-ID: <75341abe-8ab6-a712-2b42-66897d847e57@huaweicloud.com> Date: Mon, 22 Apr 2024 15:52:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20240422160539.3340-1-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:Syh0CgA3kfRRFyZmPFqLKw--.43190S2 X-Coremail-Antispam: 1UD129KBjvJXoWxWFyrGF4UXFW8uw17tr1rtFb_yoWrJr1UpF Z3Aw13Kw1UZr9rArn3Ca42qr15t3y0qa47Xr9rZrW2vwn0grn8tF95W34UAr15Ar93Aryx AFsxZry8Gr1q9F7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvIb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7Mxk0xIA0c2IE e2xFo4CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxV Aqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q 6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_JFI_Gr1lIxAIcVC0I7IYx2IY6x kF7I0E14v26F4j6r4UJwCI42IY6xAIw20EY4v20xvaj40_Gr0_Zr1lIxAIcVC2z280aVAF wI0_Gr0_Cr1lIxAIcVC2z280aVCY1x0267AKxVW8Jr0_Cr1UYxBIdaVFxhVjvjDU0xZFpf 9x07UWE__UUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1E2F94000E X-Rspam-User: X-Stat-Signature: jfsu4azqt4wnxckjb7zyicqsr4cadgxw X-HE-Tag: 1713772403-615530 X-HE-Meta: U2FsdGVkX19t6KjS28jnIRNJHJj09YaMzUj6bVS8O2t/3w5oFmygWbAhpy5s5vmYITaBCipMsG7IYq61GN9SIUea0vMCqtJjBqJ3em9+/SiIjvCFS0VqET0kaffIjkI6YsJJqj4A+vkwLXEDu/8OCiP/Cd/y8qGDcio4dpwacntYuqN/PcM7gs6l6CfCMlRlOt/olP71R04+4alo0hIzH7KSVmXjSi9Xxu0n3uzYDSZSxLloACUm8Jqq3MNk9DALvY5RsgULPeCbOiwTKr3mZlcn9iH/WmseDviViED7iA5kcjw94jkv9+LQkNSplZWOGugi/6z+PieuarPez9Tm1fIbWQiKu6Cx4y/lEce19q6qgIIs53/8hE8h7/MPiuL4TKLZHxdNt1KLDYC1DNUsAVAv+p93t9ydpBU6pj4smvcZkmq1ZGiUjEO7S0QIZHoF8TrtWYM4cy5R5B/u6+E3m4/NpsaZG9M8LmNIOvqojNoF70K4fSLHtKrjWUJ8sCxTAJrdS/7pMqBANStBCxVuhF/rA2k4jHYl8GioogQYNC2Ua+/5TpOG2K3CpVmfNqRn0vzGIRZxxNIdS7KDf24SDudZCltI95QdD06XwJ40ubP3bvc7Lu5Eya/hUnHR/Yls9hVj/QrTV/3B+2BbfGopgog0G5dWxe7lFUTm4vIYHyUNdqjaK2GiH3vdYWrF8uAQ8Nz2T9HjjI/mKBP8tnbHCEcSyfZ7JhDwLKyKUqCEK6DJ4XCSBqGxoL9/MX4fZYyAIvq1grH/mTH8rmi555cc+2c74xrSPGF9uEWPDIOYnB8hoLmFnmbl8OBFjEr4U4RNSLVhPBVFVvin3Cle2tlwCc5xMxLbN558GWeplVuQ9uC1TWWaZZVPpTGl/bhoOPTt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: on 4/23/2024 12:05 AM, Kemeng Shi wrote: Forget to fix a build warning, please ignore this series. Sorry for the noise. > v2->v3: > -Drop patches to protect non-exist race and to define GDTC_INIT_NO_WB to > null. > -Add wb_tryget to wb from which we collect stats to bdi stats. > -Create wb_stats when CONFIG_CGROUP_WRITEBACK is no enabled. > -Add a blank line between two wb stats in wb_stats. > > v1->v2: > -Send cleanup to wq_monitor.py separately. > -Add patch to avoid use after free of bdi. > -Rename wb_calc_cg_thresh to cgwb_calc_thresh as Tejun suggested. > -Use rcu walk to avoid use after free. > -Add debug output to each related patches. > > This series tries to improve visilibity of writeback. Patch 1 make > /sys/kernel/debug/bdi/xxx/stats show writeback info of whole bdi > instead of only writeback info in root cgroup. Patch 2 add a new > debug file /sys/kernel/debug/bdi/xxx/wb_stats to show per wb writeback > info. Patch 3 add wb_monitor.py to monitor basic writeback info > of running system, more info could be added on demand. Patch 4 > is a random cleanup. More details can be found in respective > patches. Thanks! > > Following domain hierarchy is tested: > global domain (320G) > / \ > cgroup domain1(10G) cgroup domain2(10G) > | | > bdi wb1 wb2 > > /* all writeback info of bdi is successfully collected */ > cat stats > BdiWriteback: 4704 kB > BdiReclaimable: 1294496 kB > BdiDirtyThresh: 204208088 kB > DirtyThresh: 195259944 kB > BackgroundThresh: 32503588 kB > BdiDirtied: 48519296 kB > BdiWritten: 47225696 kB > BdiWriteBandwidth: 1173892 kBps > b_dirty: 1 > b_io: 0 > b_more_io: 1 > b_dirty_time: 0 > bdi_list: 1 > state: 1 > > /* per wb writeback info of bdi is collected */ > cat /sys/kernel/debug/bdi/252:16/wb_stats > WbCgIno: 1 > WbWriteback: 0 kB > WbReclaimable: 0 kB > WbDirtyThresh: 0 kB > WbDirtied: 0 kB > WbWritten: 0 kB > WbWriteBandwidth: 102400 kBps > b_dirty: 0 > b_io: 0 > b_more_io: 0 > b_dirty_time: 0 > state: 1 > > WbCgIno: 4208 > WbWriteback: 59808 kB > WbReclaimable: 676480 kB > WbDirtyThresh: 6004624 kB > WbDirtied: 23348192 kB > WbWritten: 22614592 kB > WbWriteBandwidth: 593204 kBps > b_dirty: 1 > b_io: 1 > b_more_io: 0 > b_dirty_time: 0 > state: 7 > > WbCgIno: 4249 > WbWriteback: 144256 kB > WbReclaimable: 432096 kB > WbDirtyThresh: 6004344 kB > WbDirtied: 25727744 kB > WbWritten: 25154752 kB > WbWriteBandwidth: 577904 kBps > b_dirty: 0 > b_io: 1 > b_more_io: 0 > b_dirty_time: 0 > state: 7 > > The wb_monitor.py script output is as following: > ./wb_monitor.py 252:16 -c > writeback reclaimable dirtied written avg_bw > 252:16_1 0 0 0 0 102400 > 252:16_4284 672 820064 9230368 8410304 685612 > 252:16_4325 896 819840 10491264 9671648 652348 > 252:16 1568 1639904 19721632 18081952 1440360 > > writeback reclaimable dirtied written avg_bw > 252:16_1 0 0 0 0 102400 > 252:16_4284 672 820064 9230368 8410304 685612 > 252:16_4325 896 819840 10491264 9671648 652348 > 252:16 1568 1639904 19721632 18081952 1440360 > ... > > Kemeng Shi (4): > writeback: collect stats of all wb of bdi in bdi_debug_stats_show > writeback: support retrieving per group debug writeback stats of bdi > writeback: add wb_monitor.py script to monitor writeback info on bdi > writeback: rename nr_reclaimable to nr_dirty in balance_dirty_pages > > include/linux/writeback.h | 1 + > mm/backing-dev.c | 174 +++++++++++++++++++++++++++++----- > mm/page-writeback.c | 27 +++++- > tools/writeback/wb_monitor.py | 172 +++++++++++++++++++++++++++++++++ > 4 files changed, 345 insertions(+), 29 deletions(-) > create mode 100644 tools/writeback/wb_monitor.py >