From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A439DC433F5 for ; Tue, 21 Dec 2021 15:57:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C0116B009F; Tue, 21 Dec 2021 10:57:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 26F946B00A1; Tue, 21 Dec 2021 10:57:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C2A66B00A2; Tue, 21 Dec 2021 10:57:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0006.hostedemail.com [216.40.44.6]) by kanga.kvack.org (Postfix) with ESMTP id EA6716B009F for ; Tue, 21 Dec 2021 10:57:15 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A46E488CF4 for ; Tue, 21 Dec 2021 15:57:15 +0000 (UTC) X-FDA: 78942255630.16.DE94776 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf07.hostedemail.com (Postfix) with ESMTP id 0FEA340049 for ; Tue, 21 Dec 2021 15:57:14 +0000 (UTC) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BLD3Skp002419; Tue, 21 Dec 2021 15:56:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=QgVi0UxhfErMblQVaF7kJy24YaNCw/Ul1J9r4oeumdA=; b=fE4M14hSHUZ9BJ3fwDGfyQ6yBCF5IHLRtPPK/6ufLhpW9hKhMbkfIMvFHcdfpsM6xaPo a3ClGXW340BtusgA08w1RzLe1OXZju8/1GtYVnFiv/avORC+h9kxc6oSrzmIpGcSe2Oc GX4OPUs5XMlwB9g0aq6yEmYp0bfOBlmkj3zCR/UojTvamXwA0CKARTkN3UZhvdXNyaJW hKqnmxPXMKjr8fFOh/kkGvDLrg3FQPwlvr6OOkOWwmt/5r6rW2cqAsMp+BmmZZHnrKoh SKnLSrIQAmWzW+wSiz//QWiP6XH0i4oAWsLqbITswhG2+PQ7qqDrH0LkBCnwmYU9P3ou Mw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3d2qbqupj3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Dec 2021 15:56:59 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BLFumPd021767; Tue, 21 Dec 2021 15:56:58 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2176.outbound.protection.outlook.com [104.47.56.176]) by aserp3030.oracle.com with ESMTP id 3d15pdddgu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Dec 2021 15:56:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eTw5LyvTtMaNjGCF+uuKK4246k9fphLGCjI7kxxqjz6UkLGUnNtli4gixkurXQKrEirc6ngh/ZESJCKOSeFqiOw/w1aik8UDgpoqkhHk17v0bvnUSFVGwlHLHsUIdCNG2N7Z/hysl5fNgej+eia+mRh45P2m7Hx8AY8XhHx4TbkkH29VjekXsLC5TcB8jc7V9rII7WKFRDisZGhuZjdxRjVPElzVHCJMpEX7E38pJeW5U+mriLExGb4cEgpGYf1HMw21MWy0q/3Op0Cps16DyAoKO6pTvi0+E4QIDfMcTacMErnPdqIB5JVHRNZllaYtSzAq7bOBePIFlehQN/B5pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QgVi0UxhfErMblQVaF7kJy24YaNCw/Ul1J9r4oeumdA=; b=gbJYwn78VYaaZq4gnU4lzSGnXuqsugDRXUyyeyWbTW8BEc02mIL7gWqrA8ngG19gEbbOYgexRoDJ1ctMMVRabna7OjB0aByXuB0HxAJNKUvRrLVcJcZMTqZRazXkLz2TUz5dJwTHZVgbhJDFTMA/RJLJqb3oJ2HhvO0R1vJ8qApyB70F5lQZz9NPlllViV+lSkFQBd34aG+bieJu+aQlVvtpzbRI4KMUOMstFLCCTnu5J+G/HWi8kd4k2ZbKP/u6f3a7ooOIvSvt62nnr0rkwyRBiRM4Ttpt6GZIvgZ781ZBs2tzh1su5bJXzhAWhZFMA2UQ+wzK3+yS7pzitF5fgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QgVi0UxhfErMblQVaF7kJy24YaNCw/Ul1J9r4oeumdA=; b=QRKOhycMaS15BOM7jRIUh5rZOr+0cOfhhcs++4fAs0SH1cKDmi/YYpwKeTfIHRQxu0xWtiGd3qgAbFIvkO1Fbk+kl83KIIYnBejFuTyeQPxwhM/AemNmjti9DJsNvA7dFeZMMUejSndAzHDvI2P5MzsvI4n8J3h0REDJykvMpco= Received: from SN4PR10MB5559.namprd10.prod.outlook.com (2603:10b6:806:202::16) by SA2PR10MB4409.namprd10.prod.outlook.com (2603:10b6:806:11a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Tue, 21 Dec 2021 15:56:55 +0000 Received: from SN4PR10MB5559.namprd10.prod.outlook.com ([fe80::7514:eec6:460d:a074]) by SN4PR10MB5559.namprd10.prod.outlook.com ([fe80::7514:eec6:460d:a074%5]) with mapi id 15.20.4801.020; Tue, 21 Dec 2021 15:56:55 +0000 From: William Kucharski To: "Matthew Wilcox (Oracle)" CC: Linus Torvalds , David Hildenbrand , Andrew Morton , "linux-mm@kvack.org" Subject: Re: [PATCH 1/3] mm: Remove last argument of reuse_swap_page() Thread-Topic: [PATCH 1/3] mm: Remove last argument of reuse_swap_page() Thread-Index: AQHX9oNgoOl7H09PJ0G3CKJaMAsnHQ== Date: Tue, 21 Dec 2021 15:56:55 +0000 Message-ID: <75281E27-96A0-45E1-8C15-801F3499AC65@oracle.com> References: <20211220205943.456187-1-willy@infradead.org> In-Reply-To: <20211220205943.456187-1-willy@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3693.40.0.1.81) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3a993da8-f6ef-453f-20e1-08d9c49a834a x-ms-traffictypediagnostic: SA2PR10MB4409:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /c9Dw/GcfkTVuYwmUYuehDrXjLvvJuLHXCrTncr6U941PkzSJiFI7aTbgZNj0n6uPo/bjke+5XzJTKA8PkH/XLLfeCHWc4lryZNh+4V8vaEhoNwAoATXUyTQt4VZtzrVLyfxpuwA9kIq9/L1xzuws+P3YFSATRRoE+HH65EyhcigsQXASt/E6boJmYKPszHl66DbKTxg2vcojzG6yFUtQlFWD8G1UAXJn7I92s9Bs8lVqbpCkZ/2RDe5ifMmE6e8bxkDzegj+yS2VWD+LZzm9hSN2d1OQRL8wnlu7IugOp0nm/CI6aPZH2rvZF0OePAE6iI6ZDXP1mDfBfS9Tcyqf8a9IFwkkFEYCoLqkOy+nncQ1UOP2+SG5vtlfzSeoznE2fIQLY2IATSffUY9APJztNJW1CsiVzyXGgZ3OxIyxFFtSVTsMWOGBnruWDftx529z+7qTKajV05YOM+F4ajoolzQZ79gSpE2m3ZXp1bGK5EQ4Nfy+514JoTb6NqdDz4xa/fTcb7aPdQtRNpZSXcPZPJfSgCzeGdEXmBsJgnOEhs71F99VgPuO4/K+ZPfmZ+Y42xfdwFfZPel1wGEcyUEVDk10PkL4EXVUfGlPdjgVpcePGLdPx4imuWbQDVa40Hoy/UwK+0XihIAq70n27x//co9UUCKWWmSmDmn387x+HDHWlepNyZE9LfOFcJMExf7HxfuxakQTFJwDTGHYjza5gLtAOY2MtaDtVquZG01msrhTfeSPE/Xgwq8/NuJi4j3 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN4PR10MB5559.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(71200400001)(122000001)(66476007)(38100700002)(66556008)(91956017)(64756008)(76116006)(4326008)(66446008)(5660300002)(38070700005)(33656002)(186003)(6512007)(6486002)(36756003)(2616005)(86362001)(6916009)(44832011)(83380400001)(54906003)(6506007)(53546011)(316002)(2906002)(8936002)(8676002)(508600001)(66946007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?t0B/0LQhhmv9KXvImTj2aoKZWiRlOwiAtTNpzlQEIXO7MLbVAjMdbGF0+nlk?= =?us-ascii?Q?RTOxxVUfdP4D/I+PbzBkOTUJXLY2X3kMrXOvXYZ6puRoDsqaE6CZ4pB8VTpM?= =?us-ascii?Q?T6ljBiYTKm4KgK5k0qlTM1vgwDzS45XmmcS42CuSSqPHFMyu2bkXU9hAmErT?= =?us-ascii?Q?rwS0l+eymDYJOVwGk9lX8hpKujbuQPiS2tDXbW6pvj/V5mPfsGvcAZ08gHCY?= =?us-ascii?Q?+Ca4lvs/zsixdSLaOID0WIc3s5GiFCpaG6XXoqsBtksxHtou9Np7GSUc9qYy?= =?us-ascii?Q?OKZwBY+WieFUMsaaJF4qkYj07Wsy3jTQqzIa1NkPt5XTN1ddsxHlIgfuwTa2?= =?us-ascii?Q?70AfHYu2+HABdVO9RodJyH9GezuPHcrQM7zozawbV7kL2LpmE7/hewgL8dXy?= =?us-ascii?Q?Z+F3lOgszNQ1Kqvytwjne6DyQJ0ybbhQnNDUhYuhX7lg1zQR5ShQQcVC0fvg?= =?us-ascii?Q?ZrOXQ+KIhTc2r3hdSfo80BMGAdm2bCLol8XotJGw+wLUMs4yKPew/JA+jR9n?= =?us-ascii?Q?4xLXsZcBtModDjzp0e3kNF4kkT+fqEtFqUt0lU6PIZIXtSqoPL1PlqCiRqC4?= =?us-ascii?Q?5ugxS3arexWPSUiKhDeIPLa33bQGlCF1oMs5JXXf+knaIaoJaFTXECUAqi6B?= =?us-ascii?Q?HpbmMrE0T6aEjBcr5CL9EqSJWzp/B8qelOIqdhD2Khm06k3ZgjprVXUrlbbC?= =?us-ascii?Q?VAs5PpKOt7XqfG/dl55xj3fFCq/AsxWFFxBGrvNaQQxQPepoj+htv67pAUjI?= =?us-ascii?Q?3vU3OBGIT0yKS/qltURswTa+Ki6ldYOam2DOQT8mLVct3Mxn08V1DYgfuFfE?= =?us-ascii?Q?5RNa+54NX5/OE6rfsNs2GaEneB4pZZo+43cE/YtFFVfPh6Z1fnlMr9VroR45?= =?us-ascii?Q?UnhMU66t5EXp4VYZpnMl1ujlAXoPK4xYxYIepZ97CokjKTqncBZlPf/Vr7j/?= =?us-ascii?Q?agU4OgXJx6S1J1IR12sfsPl5L7RMb5qIE04xb95GDDB6+6BgAhk0HstQzyh0?= =?us-ascii?Q?EeGvvmAjYFHQdNZSvUBx/ihdbxE5nO4asdQsNjIETRKBrjVzb4xXiwZViEZg?= =?us-ascii?Q?RkVwkJsa+uXyokFJQXvcQMhs7w9HHq0hrNYyzFT9FQ7o/Kt4N7iujUddPsny?= =?us-ascii?Q?BGpkka3tSwAdi9VuBlSyaGL4UyLfZv+YOWK2UncR9xihzKjFO7OzbAIP7i2E?= =?us-ascii?Q?nSiIcyRRVjp1rZVGrx/Fal9ubeBV8RnLkQv4GZ/wm4oPfJ6r4vS4GJoo+lUC?= =?us-ascii?Q?JTWmNMad58l8pKGf2fdwEENf30JQ+YQ1C5siEoECsu5dy7EVep+piEjDaCUo?= =?us-ascii?Q?SO1LRtSFj75GXirRlvOtlSTBySm/yEi6qPA5i9bpro5oEb5DvqyrX4DgGq7P?= =?us-ascii?Q?FOCEcZ5pKEM3/N2OFZWUASQFZdR0vWpPYBISY6o+97CJWkXsQRbBNiHcsO+S?= =?us-ascii?Q?98eYcXF6GUYP/3vsAOAboQVMdb9uOXhXQClqa+AE9or5Cd8ijekRkXTUYj2L?= =?us-ascii?Q?QCqUuZKYqRCrNCoKWmX4TFpFYf7l+uTb8jGRy8qaRgKOmAgMwks3RBKbA8uH?= =?us-ascii?Q?7+wAo8fpfFsqhW9KL+Vx3jNq6rGPmklW+8JvAtmzS1UhL99xH8gGxeTUtGpF?= =?us-ascii?Q?tPbA5P8ZNMIpcNEoBwUfkEtRYy/O9RE+LMgUsYmloa5n8W1Z6jX3zHmQ10YA?= =?us-ascii?Q?GuY72M0sphR0aVRty820G31ogReVHh+ocXXb3NvpdUqHLRbQtqDYRlB5lTkE?= =?us-ascii?Q?H9sT7ZUvxakO7Wl7haEPgckCp4r9ua0=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <1E7703A5CA306C4D8E8092567F7493F5@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN4PR10MB5559.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a993da8-f6ef-453f-20e1-08d9c49a834a X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2021 15:56:55.4694 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vJNczuxW8XoMkDIIVR662TmrKjSZi+8VET2RHV6LU2BQLyHTRCPK+2UPfOx1gePox3jYpWWXtDykygRnVSSSHnuyxjgcUgZ+dC+uiCtLvRY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4409 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10204 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 mlxscore=0 spamscore=0 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112210077 X-Proofpoint-ORIG-GUID: KIhAp0-R5vl2WeczauSuhpP2KmHLwl5g X-Proofpoint-GUID: KIhAp0-R5vl2WeczauSuhpP2KmHLwl5g Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=fE4M14hS; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=QRKOhycM; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf07.hostedemail.com: domain of william.kucharski@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=william.kucharski@oracle.com X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0FEA340049 X-Stat-Signature: mnd5m4km586wd1guk53jamqsgjx3k7z8 X-HE-Tag: 1640102234-444975 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I really like the cleanups and the removal of code no one is using anyway. For the series: Reviewed-by: William Kucharski > On Dec 20, 2021, at 1:59 PM, Matthew Wilcox (Oracle) wrote: >=20 > None of the callers care about the total_map_swapcount() any more. >=20 > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/swap.h | 6 +++--- > mm/huge_memory.c | 2 +- > mm/khugepaged.c | 2 +- > mm/memory.c | 2 +- > mm/swapfile.c | 8 +------- > 5 files changed, 7 insertions(+), 13 deletions(-) >=20 > diff --git a/include/linux/swap.h b/include/linux/swap.h > index d1ea44b31f19..bdccbf1efa61 100644 > --- a/include/linux/swap.h > +++ b/include/linux/swap.h > @@ -514,7 +514,7 @@ extern int __swp_swapcount(swp_entry_t entry); > extern int swp_swapcount(swp_entry_t entry); > extern struct swap_info_struct *page_swap_info(struct page *); > extern struct swap_info_struct *swp_swap_info(swp_entry_t entry); > -extern bool reuse_swap_page(struct page *, int *); > +extern bool reuse_swap_page(struct page *); > extern int try_to_free_swap(struct page *); > struct backing_dev_info; > extern int init_swap_address_space(unsigned int type, unsigned long nr_pa= ges); > @@ -680,8 +680,8 @@ static inline int swp_swapcount(swp_entry_t entry) > return 0; > } >=20 > -#define reuse_swap_page(page, total_map_swapcount) \ > - (page_trans_huge_mapcount(page, total_map_swapcount) =3D=3D 1) > +#define reuse_swap_page(page) \ > + (page_trans_huge_mapcount(page, NULL) =3D=3D 1) >=20 > static inline int try_to_free_swap(struct page *page) > { > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index e5483347291c..b61fbe95c856 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1322,7 +1322,7 @@ vm_fault_t do_huge_pmd_wp_page(struct vm_fault *vmf= ) > * We can only reuse the page if nobody else maps the huge page or it's > * part. > */ > - if (reuse_swap_page(page, NULL)) { > + if (reuse_swap_page(page)) { > pmd_t entry; > entry =3D pmd_mkyoung(orig_pmd); > entry =3D maybe_pmd_mkwrite(pmd_mkdirty(entry), vma); > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index e99101162f1a..11794bdf513a 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -681,7 +681,7 @@ static int __collapse_huge_page_isolate(struct vm_are= a_struct *vma, > goto out; > } > if (!pte_write(pteval) && PageSwapCache(page) && > - !reuse_swap_page(page, NULL)) { > + !reuse_swap_page(page)) { > /* > * Page is in the swap cache and cannot be re-used. > * It cannot be collapsed into a THP. > diff --git a/mm/memory.c b/mm/memory.c > index 8f1de811a1dc..dd85fd07cb24 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -3626,7 +3626,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > inc_mm_counter_fast(vma->vm_mm, MM_ANONPAGES); > dec_mm_counter_fast(vma->vm_mm, MM_SWAPENTS); > pte =3D mk_pte(page, vma->vm_page_prot); > - if ((vmf->flags & FAULT_FLAG_WRITE) && reuse_swap_page(page, NULL)) { > + if ((vmf->flags & FAULT_FLAG_WRITE) && reuse_swap_page(page)) { > pte =3D maybe_mkwrite(pte_mkdirty(pte), vma); > vmf->flags &=3D ~FAULT_FLAG_WRITE; > ret |=3D VM_FAULT_WRITE; > diff --git a/mm/swapfile.c b/mm/swapfile.c > index e59e08ef46e1..a4f48189300a 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -1668,12 +1668,8 @@ static int page_trans_huge_map_swapcount(struct pa= ge *page, int *total_mapcount, > * to it. And as a side-effect, free up its swap: because the old content > * on disk will never be read, and seeking back there to write new content > * later would only waste time away from clustering. > - * > - * NOTE: total_map_swapcount should not be relied upon by the caller if > - * reuse_swap_page() returns false, but it may be always overwritten > - * (see the other implementation for CONFIG_SWAP=3Dn). > */ > -bool reuse_swap_page(struct page *page, int *total_map_swapcount) > +bool reuse_swap_page(struct page *page) > { > int count, total_mapcount, total_swapcount; >=20 > @@ -1682,8 +1678,6 @@ bool reuse_swap_page(struct page *page, int *total_= map_swapcount) > return false; > count =3D page_trans_huge_map_swapcount(page, &total_mapcount, > &total_swapcount); > - if (total_map_swapcount) > - *total_map_swapcount =3D total_mapcount + total_swapcount; > if (count =3D=3D 1 && PageSwapCache(page) && > (likely(!PageTransCompound(page)) || > /* The remaining swap count will be freed soon */ > --=20 > 2.33.0 >=20 >=20