From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 029F8C2D0C4 for ; Tue, 10 Dec 2019 09:25:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B994E20726 for ; Tue, 10 Dec 2019 09:25:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AAWTnfs/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B994E20726 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B16F56B2B91; Tue, 10 Dec 2019 04:25:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC5916B2B92; Tue, 10 Dec 2019 04:25:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B5EF6B2B93; Tue, 10 Dec 2019 04:25:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id 85D876B2B91 for ; Tue, 10 Dec 2019 04:25:05 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 1D34D180AD83A for ; Tue, 10 Dec 2019 09:25:05 +0000 (UTC) X-FDA: 76248697770.05.color51_83a78dffd4708 X-HE-Tag: color51_83a78dffd4708 X-Filterd-Recvd-Size: 4440 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Dec 2019 09:25:04 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id y1so1790785lfb.6 for ; Tue, 10 Dec 2019 01:25:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bwAtdmxvGyrCILPXFQvJnltIvhpI4gs5tXgbrhs6Bw8=; b=AAWTnfs/Eo6Hj9n5OB6phmWbD1m15J5X8zumgD18FNQPA7cz27EvX1/21ZhNTbTPUY XGkSjBCWioOl7cC9OShUkrEKjWSkJX+5pVSLHJxNAGJsts66j+RkjZKoV9kGHo5xR9kH GwHXNIfkPO4sCcaUllxE+QKhWrY0ySSM3eYgYneiUTqBcR+CyGtTLgsL3KPyQtKw0Ib8 aeR8A4Smt36NwUgCjEfjt5srHlEM9A5By9QYXtSzyR661zdeCMX9O2ejs05kko8w2PCp m3RoIKrDuiJa7+GEH9hm00BQcZc0Ry7JEYWvvyK1tkUZw3KKqEB/bG3BzdJmvRp1O2aD B1IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bwAtdmxvGyrCILPXFQvJnltIvhpI4gs5tXgbrhs6Bw8=; b=CFTPy5UzuV7ljhFBVU2PEd4wcEJbec+iuqdZ7a75LDyiSCFr+wHnHnu1yF0vRQXWl3 Ktwo4pZRvEdvRRbE912/nTifxSj0KoNBKeScDZHnOFIqNWK7y+MQaeAdlk+eiO2qAabi PuU2u1P/ue+Xk6HJg7+tq2eDKjE9S1juVNNoaQsrLOdtaBxs3wNHy34IJYaKb8GWZI1S NapgCU6tD7BJNKhGOXVzmjiOXvQmMxxYNr4dnFRE2fFot3ni7Dv7QPaorOVcHtyCrMYV 07dVO932/YpXhn2FOjQyzXdZ6RsyK5J8rLPHoF8/CgK6x+tsRhGCslGinPQNOnN0iQPh dNsA== X-Gm-Message-State: APjAAAWQ8cysjZ8tiwkN0rAxnx0yP107IccVdCoLobdhjdrDATALlGzV 4JveVNmKFiVsxf1XrHgwk5k= X-Google-Smtp-Source: APXvYqzm65bVkxT4Df63k0Cw7qZ6HRx7A1/BYXwyrUoXItP8lfD75xLlEPsY+Fw6rS+ESQMXguWwjA== X-Received: by 2002:a19:c1c1:: with SMTP id r184mr4402876lff.128.1575969902911; Tue, 10 Dec 2019 01:25:02 -0800 (PST) Received: from [192.168.68.106] ([193.119.54.228]) by smtp.gmail.com with ESMTPSA id 22sm1689626ljw.9.2019.12.10.01.24.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Dec 2019 01:25:02 -0800 (PST) Subject: Re: [Patch v2] mm/hotplug: Only respect mem= parameter during boot stage To: Baoquan He , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, mhocko@kernel.org, david@redhat.com, jgross@suse.com, akpm@linux-foundation.org References: <20191210084413.21957-1-bhe@redhat.com> From: Balbir Singh Message-ID: <75188d0f-c609-5417-aa2e-354e76b7ba6e@gmail.com> Date: Tue, 10 Dec 2019 20:24:55 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191210084413.21957-1-bhe@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/12/19 7:44 pm, Baoquan He wrote: > In commit 357b4da50a62 ("x86: respect memory size limiting via mem= > parameter") a global varialbe global max_mem_size is added to store typo ^^^ > the value parsed from 'mem= ', then checked when memory region is > added. This truly stops those DIMM from being added into system memory > during boot-time. > > However, it also limits the later memory hotplug functionality. Any > memory board can't be hot added any more if its region is beyond the > max_mem_size. System will print error like below: > > [ 216.387164] acpi PNP0C80:02: add_memory failed > [ 216.389301] acpi PNP0C80:02: acpi_memory_enable_device() error > [ 216.392187] acpi PNP0C80:02: Enumeration failure > > From document of 'mem= ' parameter, it should be a restriction during > boot, but not impact the system memory adding/removing after booting. > > mem=nn[KMG] [KNL,BOOT] Force usage of a specific amount of memory > ... > > So fix it by also checking if it's during boot-time when restrict memory > adding. Otherwise, skip the restriction. > The fix looks reasonable, but I don't get the use case. Booting with mem= is generally a debug option, is this for debugging memory hotplug + limited memory? Balbir