From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3028BC46CD2 for ; Tue, 2 Jan 2024 14:04:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98A118D000C; Tue, 2 Jan 2024 09:04:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9117A8D0006; Tue, 2 Jan 2024 09:04:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B35B8D000C; Tue, 2 Jan 2024 09:04:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 627378D0006 for ; Tue, 2 Jan 2024 09:04:24 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0A0F6C07C4 for ; Tue, 2 Jan 2024 14:04:23 +0000 (UTC) X-FDA: 81634540848.11.F98A71D Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf28.hostedemail.com (Postfix) with ESMTP id D0DD4C002A for ; Tue, 2 Jan 2024 14:04:20 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf28.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704204262; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jHtxspFYMXLgbsoHlUfpova+2SNX3zK7sveiyj8ThoY=; b=KRTuvAkSgzJaDRll7o1OBDUE6wrF7CVBd4pqgZNnyxQL2xN01uNCPOQxR2cOMEtE0LIg9s WDUC67uSamOWuOR2/Rvbv+zQgGbWowd0ZhBrACAdMrpCGMnmoD92FIVbmSTNVB+X+kvjlf AUewYLkQgDMqVBBpMDf09l0bY0/y3o8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf28.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704204262; a=rsa-sha256; cv=none; b=Mr5rtRSKzXMVUajQASJjyWPkOW/D/BJkkeY0es0Uyis9Q3qZa+UYGGmHzvHgrQ01KHTCoi CB0lZstTHagvmpvNMmuCL7xLkaARp3ra0BLd/ws/+DpXCQCDFUytVsbgZ7qo8bMrpYckBh TJYIGazY9mcIH85A5SlbIoniGzdCdhM= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=22;SR=0;TI=SMTPD_---0VzqtEDH_1704204253; Received: from 192.168.33.9(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VzqtEDH_1704204253) by smtp.aliyun-inc.com; Tue, 02 Jan 2024 22:04:14 +0800 Message-ID: <750e8251-ba30-4f53-a17b-73c79e3739ce@linux.alibaba.com> Date: Tue, 2 Jan 2024 22:04:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 33/40] netfs, cachefiles: Pass upper bound length to allow expansion To: David Howells Cc: Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Eric Van Hensbergen , Ilya Dryomov , Christian Brauner , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton , Steve French References: <20231221132400.1601991-1-dhowells@redhat.com> <20231221132400.1601991-34-dhowells@redhat.com> From: Gao Xiang In-Reply-To: <20231221132400.1601991-34-dhowells@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D0DD4C002A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: uic8bg58f4n71c4a7fwkab3jyuqjwi1j X-HE-Tag: 1704204260-243023 X-HE-Meta: U2FsdGVkX18DH8prVjdzv6oCMCD6XO4UHwhYovu1S9oelxhGphxPKx40X6m6gLEgg0TvMAxveVGseMsqsnNc5dr/cy5zVhyUVZG8EvAHVHd7OZp4t3TglPXsmbOQBScN27UdtEE8dj0nCn2fKhQEBsvBIQYS3ZLfZKjwsuIG0xe59idp66jDYUObRNqtP8LUp2lAN8EovNQ2oPwVoZHYFNvCRZtkSdvt0CERapZD7mkI21OlCjVpsNqipfOqtcGSZ9w7/cBAg6Vb4vHAFyfstE2LPZjbTDUicAOPbdPsQtl2XYJEoN2ecZg+46Jk3ElhP2v8BJIOPZGrtDZISihseeVjoeFZy8uFdnX5aKA5W9lZWcCmJzfo1umD6vgXON3Bv8UNQhiC1KsSgO5f/uGqLQI+NhYB/LIR75yKFBMRcpWizlWtE+khSOz4LpHFPKUmoXhXvKPGPz8wWbxafWftVybqOZTVLwT2W9L0JJ+DecaM6liBsukn71Toz7Jik5atU1bhmYyodoQaOrs/9MI1EyenDegyd/BV1D9537QFeRWkb2v4Gv0RDRVwzxh24qkcyoY9HqSCoamrx+lmqw3JZeq4mZX/CxbQuX0n1XEDmhVEE5xV8ixmvLdz0SBTSuxo5hi4vGl1DtSbmOD8pmtDVAgtiU+Tl3bUDQ4v7GwPR9uX+O6gCDS6IBMqZ5pwPM7a93Pxs0rwfsY90ofYR8ef8H0PyqQDbhJ3K7oLm0stlKZM1gGGXN5jz4Eci5BIBpoaHQq72/aO8DXrMC0HnNSw+hfA3Czf32hKhqXXCXuqhuK7NVA/U0ON/jJ7NiK4cvBbraxtQhD6fKheEDjxhgkDI9YE4VnJqiQ3xJcs0NUkr0EJg6urmF8JJCJypkhuRfhvouwjWVr6wfVwqTdGewScHDVtXZcGO6D4sZBjJYO6e7Ry1eJIwrZigbjlo88vcuuLnY0jl8RJK/AyCRt/Ogv 8iGs1FMI 2gY1h2MzAhZk3jURqZGO4jZXrviTKl33RRWPCU/7WvgizV9Ao2rO2s8rJRTpbFurk0EcBD/FEJaAouHVSG+YnlwemYtKbCzRZL/bngqQGrvArPdeDRP68PZ11fz/CRxpZntjuALin9kNnRatNALvF8axgkQhYTAqK6aLTjPyqYuybi1MiKwavP/fkWIaSOpiGrmJ0n55oJGAuLpFMi/SzJjeXl/ZuIGl3GqVd24de/y3iprsdK2HnOfrmk1nE2YE9QCHFOdT9+sHMwOKr+XqF04IMlDUdzHnD2K4+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, On 2023/12/21 21:23, David Howells wrote: > Make netfslib pass the maximum length to the ->prepare_write() op to tell > the cache how much it can expand the length of a write to. This allows a > write to the server at the end of a file to be limited to a few bytes > whilst writing an entire block to the cache (something required by direct > I/O). > > Signed-off-by: David Howells > Reviewed-by: Jeff Layton > cc: linux-cachefs@redhat.com > cc: linux-fsdevel@vger.kernel.org > cc: linux-mm@kvack.org > --- > fs/cachefiles/internal.h | 2 +- > fs/cachefiles/io.c | 10 ++++++---- > fs/cachefiles/ondemand.c | 2 +- > fs/netfs/fscache_io.c | 2 +- > fs/netfs/io.c | 2 +- > fs/netfs/objects.c | 1 + > fs/netfs/output.c | 25 ++++++++++--------------- > fs/smb/client/fscache.c | 2 +- > include/linux/netfs.h | 5 +++-- > 9 files changed, 25 insertions(+), 26 deletions(-) > > diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h > index 2ad58c465208..1af48d576a34 100644 > --- a/fs/cachefiles/internal.h > +++ b/fs/cachefiles/internal.h > @@ -233,7 +233,7 @@ extern bool cachefiles_begin_operation(struct netfs_cache_resources *cres, > enum fscache_want_state want_state); > extern int __cachefiles_prepare_write(struct cachefiles_object *object, > struct file *file, > - loff_t *_start, size_t *_len, > + loff_t *_start, size_t *_len, size_t upper_len, > bool no_space_allocated_yet); > extern int __cachefiles_write(struct cachefiles_object *object, > struct file *file, > diff --git a/fs/cachefiles/io.c b/fs/cachefiles/io.c > index 009d23cd435b..bffffedce4a9 100644 > --- a/fs/cachefiles/io.c > +++ b/fs/cachefiles/io.c > @@ -518,7 +518,7 @@ cachefiles_prepare_ondemand_read(struct netfs_cache_resources *cres, > */ > int __cachefiles_prepare_write(struct cachefiles_object *object, > struct file *file, > - loff_t *_start, size_t *_len, > + loff_t *_start, size_t *_len, size_t upper_len, > bool no_space_allocated_yet) > { > struct cachefiles_cache *cache = object->volume->cache; > @@ -530,6 +530,8 @@ int __cachefiles_prepare_write(struct cachefiles_object *object, > down = start - round_down(start, PAGE_SIZE); > *_start = start - down; > *_len = round_up(down + len, PAGE_SIZE); > + if (down < start || *_len > upper_len) > + return -ENOBUFS; Sorry for bothering. We just found some strange when testing today-next EROFS over fscache. I'm not sure the meaning of if (down < start For example, if start is page-aligned, down == 0. so as long as start > 0 and page-aligned, it will return -ENOBUFS. Does it an intended behavior? Thanks, Gao Xiang