From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B01FCC54E41 for ; Wed, 6 Mar 2024 15:14:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DA8C6B0078; Wed, 6 Mar 2024 10:14:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 38A686B007D; Wed, 6 Mar 2024 10:14:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 252D96B007E; Wed, 6 Mar 2024 10:14:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 19EEE6B0078 for ; Wed, 6 Mar 2024 10:14:34 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DBAFE1C0E0E for ; Wed, 6 Mar 2024 15:14:33 +0000 (UTC) X-FDA: 81866960826.23.918B613 Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by imf22.hostedemail.com (Postfix) with ESMTP id E0971C001B for ; Wed, 6 Mar 2024 15:14:30 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=XZ08tBu1; dmarc=none; spf=pass (imf22.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.176 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709738071; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WI8wnl72Fr4kYF1pJwPsFlO/0vFnIYu1hp3He8klX70=; b=W9lSrBycxeKKS+uwYltOxDI5kmYxWx5qbVl3qFASD1NfNJ+/ZrL3FTH8pFVjACPrpCQEt6 53B74q1rYe+duh75P0/kYANpMX/DljIhtc3dwPfGCKsyrET8NW63saOz2bEnkpkEnsXbui 3ldXjKhMtq3WC9mGblT68oWrfic/q3s= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=XZ08tBu1; dmarc=none; spf=pass (imf22.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.176 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709738071; a=rsa-sha256; cv=none; b=iOzBsQvTjxlcYgDKeeqyP8wdZ60VE8Oinm7PFO8TEPIMgLLV2ekWJHvIC1V6cSpwSCKhTV q+Cup5M6Tx62x9KvsGQUn/MZkSQa2qSyXxrZK0J/lw4XfJz10G8zjExpX+QT8JpO8hvbjK CShYJctNl2rQ2ExHkclsKAnFr1qzmZ8= Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-365b5050622so1957995ab.0 for ; Wed, 06 Mar 2024 07:14:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1709738070; x=1710342870; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WI8wnl72Fr4kYF1pJwPsFlO/0vFnIYu1hp3He8klX70=; b=XZ08tBu1eEeGyDZemXPApNW9+QGYyPYkn585wG7X0zLz7YjJNxB7/Z6KbbdYsuMGcx Yb4lKz0xvHJYQFliBl0ngi+SGrpfd8DXbSbzrBaPH+U880+IgfVSkZon8r6C5G8+HulO 2lQjYSxbrJ8qY4MWv/BIWdgIJOhBSRq+liSk6FK4+8hE90N/jVLvjomBxHHr7HtkCKtN ouqEdFgLsX9AnHozT1MNF7zvkXPQcdz4NzL5JkJyhp1oe3QdTa9DpzjP0eFM1g8+IExo 6OyrdEQIN7Eq38cC4d4Qhg6RFRgSy7X82GnL6Pfj6Ai2XaAV9QGeg2Jh5EngCBRP7z1a eAEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709738070; x=1710342870; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WI8wnl72Fr4kYF1pJwPsFlO/0vFnIYu1hp3He8klX70=; b=jxXUxbz62pk3VMtHQp8Ce8FxDDxxPTzPEWDAlEeo/OTA3NEA8hWQS/iLHiLZ4iyFyi Nh78UFa6CRMCw+DgzgGRMfJlhLKqPFEvMjcPObBPIlABtJ/DC6GagIhOrA2NM0BhbG/X PJsEXkY9c/I5/9wR4OY+THjiUF3ZghKd6zMmHXc4SkMi00VkaHzbUrwzCjtPsBBEQvdi yBNFVbItVHF/7odkX7A4bbaox12rxVK954PTVXTN91uFNxyFma9JpU9Nwv0CLsIRKktg JQiGVEeAwd1LJ0qJNP8HkI7a8p91Y/e+ieOGHsgAH6tbX0ZVb5ho3omJ8QGi4D3MMyMf wHsw== X-Forwarded-Encrypted: i=1; AJvYcCWkIFPEDBrPpfJl6amL1MabKPUct2ErTFTxnaolPaMDYIr31VECYk+aij9i9ys4kCHVzuCeWP2kg7A56cfpKwc32pU= X-Gm-Message-State: AOJu0Yy1mCsfNCOtW1lgiE31x7abpZ8QTr54TWsc9+vhvwBrHIqLR9Fx wMeP0BXbvMLvLEcp5c06V1rCRTIBPv81oyrzvBfIOc3q4ucBteOisfA+e1qQlyI= X-Google-Smtp-Source: AGHT+IGUiMQGgwvlQMGKRXe7wCmRXYY4W7sYiKxMn4Ny9azh3Xt+7w7LX57Y2OOgwcaF/GvjESF0Sg== X-Received: by 2002:a6b:6611:0:b0:7c8:7471:2f59 with SMTP id a17-20020a6b6611000000b007c874712f59mr2532950ioc.0.1709738069617; Wed, 06 Mar 2024 07:14:29 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id y16-20020a027310000000b004767d9bc182sm380434jab.139.2024.03.06.07.14.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Mar 2024 07:14:28 -0800 (PST) Message-ID: <74fd60ca-6284-4817-8ec1-7f1a6c203473@kernel.dk> Date: Wed, 6 Mar 2024 08:14:27 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] block: Fix page refcounts for unaligned buffers in __bio_release_pages() To: Tony Battersby , Greg Edwards Cc: "Matthew Wilcox (Oracle)" , Andrew Morton , "Kirill A . Shutemov" , Hugh Dickins , Hannes Reinecke , Keith Busch , linux-mm , linux-block@vger.kernel.org, linux-fsdevel , "linux-kernel@vger.kernel.org" References: <86e592a9-98d4-4cff-a646-0c0084328356@cybernetics.com> <20240229225630.GA460680@bobdog.home.arpa> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E0971C001B X-Stat-Signature: 8y37ha3mx859og7m8siqihmgt4a8etty X-HE-Tag: 1709738070-25499 X-HE-Meta: U2FsdGVkX1/deBMfbTqLQeGyUT/Ah7QinpgL6fWAzS/uM51uM9ZglmjFRasOimQEXujNJxt1wwyxemyR7fMuCWWBeyA5A6qfGH/cagrMYCdKpc5/01qXxRB/+wIZYFtYkTn4x+Q1kyi/1EvDjVtSqjnW8sLU17C+6iRhEEzz9d8RqpxBOylr8Bw8l6NlFPga1HeQG+aThZxUlPLkjj0GNJk4CuXL83kPcHq0e3yylV9ZgWGLEer+Sff9vjIqCGJJ6gN33vLMzlwPKXgFaCgjc/vhTvhkLpLGsJ+SnDVE01IStZRoAoqttjAqw4o+fcO0LR2wNEs+taB5wVZN8F5pcK9krui1fC+tiulJs4S4My8tiSpwCF63NGFKECVgUMGzO4iRdBdW650udASsrWr7V3GNMyCgS0hfmCjC//jdfNpoxSked6WDfrmaIPJI9ssS9pmWRHFjFaOuU+fnoO+IvGMjEXpCjDQoPF/B+bG8ruTHVQOjVDwXji3+QXvzouRzRUDbavGrZPElu/2NwVOOTRi9QPks4tWTlI97Bes7IKNYURi7jpib8bzMzaxGnHgHG7GtxR/VOO6ErNPsPSkECL9RYCyEBTx7chUqmXVKWpplV6HCjnzeiGTdqpFGPdbUfvxXvJe4FoUsxIEljSAgogPjc4JLrLurtbJiIBHmOR7cRU9JMPuMP8dVsNBut8DfyVsLyba0fOYWrANNn1+JdRNbzfbg/ucJjmtTTaxMfv7EaGpubTs4k5nKyvvKx7x1np9r2+QhpP2pAdWaYt13aDj4YZok6Pg7eN9e5y1atMYu/RyG/A7NiLeUdu9aLq1G0EpTMRnVNJOk0wp0PjCDGLKfI8zc+cMWJWJfKq0TTEvHpytEPtzUE3WPmppSx0TivDl7g6hC5mBO9El5i5skq/I4ygpz4RAGIG4/Hjowhp/VqjOloaTVR6mxOC4C0dq0Me4Fc6FizN21f5ee3Ni 1fEXbT6k /D+NTvfpPKFC9U6o/FYgvUub4ramwqz5k+W1pAET1gsYRmofvAzze7UHpBUArNTT8WRQ5PmDKniUMbuAEGs8DbmWshWv+SvyBSSQULw0wYoMTMwOivG8cXA4d9NpFZC7p8qc1ukp51XGcXh/yU+RoaUGaZoogYjgXzIPTfJi4t2rpZAvV/EQzNhjStjQz6iKygy+fcfzdmfn9P4/m1m0CuJ6bDmGf/TzeHxHaNq0vH/giYHz2KWPxv4tD4iVDpX8iQ1Cl7yvgD/4BcsatnjtkW4J58LEHQzjVwAVTOGTA0IitI7fQGT1+XVTJ5rVIZ+6eglME289jJdy5hZPnmTxx+O7PA/4YjsW8A+cPWLDfQPZ556JwExu+rzf/E3cFgn/TRTZkJarmePKZ4hGZ4NWmL6HYV8JPyUGA5jLe1NfSYfflkgL/hMu2RxLLd8a4ygnTp8RZ2TlqtEU1u0s1aGtym6hhD9XtES0Sa1+UZCntSU8UavjxfjZk1WF1/f+8F7XNrY976qf6FPGdGbTPHfYD59TY9x5PPSL8OtmQ3gLFUsM46vmYKR/axwgcxnQE6reSqJDhHauAHJTFHl8aowrNacdctRUBFUU6mFLcPFxHjnEUyV1rdgv5KuAz9/5D0i9f0lBGsBZJnJDfzCZKuV+VF27abkMRmlOEeT2Xv1MNEYIBoMz37mnJhe+Drz67XOZKHd4v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/6/24 8:03 AM, Tony Battersby wrote: > On 2/29/24 17:56, Greg Edwards wrote: >> On Thu, Feb 29, 2024 at 01:08:09PM -0500, Tony Battersby wrote: >>> Fix an incorrect number of pages being released for buffers that do not >>> start at the beginning of a page. >>> >>> Fixes: 1b151e2435fc ("block: Remove special-casing of compound pages") >>> Cc: stable@vger.kernel.org >>> Signed-off-by: Tony Battersby >>> --- >> This resolves the QEMU hugetlb issue I noted earlier today here [1]. >> I tested it on 6.1.79, 6.8-rc6 and linux-next-20240229. Thank you! >> >> Feel free to add a: >> >> Tested-by: Greg Edwards >> >> [1] https://lore.kernel.org/linux-block/20240229182513.GA17355@bobdog.home.arpa/ > > Jens, can I get this added to 6.8 (or 6.9 if it is too late)? Let's just go for 6.9 at this pount, we're almost there. I'll queue it up. -- Jens Axboe