From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6BEBC4345F for ; Wed, 17 Apr 2024 13:18:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31F8E6B008A; Wed, 17 Apr 2024 09:18:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CF616B008C; Wed, 17 Apr 2024 09:18:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 198076B0092; Wed, 17 Apr 2024 09:18:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F27356B008A for ; Wed, 17 Apr 2024 09:18:48 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BA490A2158 for ; Wed, 17 Apr 2024 13:18:48 +0000 (UTC) X-FDA: 82019078736.05.CCDF5B8 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf17.hostedemail.com (Postfix) with ESMTP id 4EF404000C for ; Wed, 17 Apr 2024 13:18:45 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713359927; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FDzWnSlq74AzsNs+2Gtmdpu32oqvbvNVWifQvd45vz8=; b=WCMqJB+jk068VLAj0pxFNwPYVfyovFxilEA3ro+CH1arML+6uvZpve0AYLfi0sBLWl5Q4p Hggr1kqHasOWcivj3NPXJF7HhtiFV9r/qY/sUTaR5SjbZ2+ToM7wvzj+8FTRt5zNUTf7aa bDvva/KBKs9ZRsaV67gJDF5jRm2dEMk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713359927; a=rsa-sha256; cv=none; b=napWb/itjcxaviBQ47ynt8/NnDymuE9CPfbl8Sk01K/RpTo/pzYGnfwQKuqd9PQ8HgpoFr m8nFQiBeywSj6fRYN4QJd7anHC4EdkHWK5Ao+ormv3TTjg1C2LCCw7Iz+pv2iAfUf9GsVy kCux8cqK3RNPqhE9CUUoW7esMtpseVs= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4VKLxQ3gh3zXlNZ; Wed, 17 Apr 2024 21:15:22 +0800 (CST) Received: from dggpemm500005.china.huawei.com (unknown [7.185.36.74]) by mail.maildlp.com (Postfix) with ESMTPS id 812AD140485; Wed, 17 Apr 2024 21:18:41 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 17 Apr 2024 21:18:41 +0800 Subject: Re: [PATCH net-next v2 07/15] mm: page_frag: add '_va' suffix to page_frag API To: Alexander H Duyck , , , CC: , , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Eric Dumazet , Jesse Brandeburg , Tony Nguyen , Sunil Goutham , Geetha sowjanya , Subbaraya Sundeep , hariprasad , Felix Fietkau , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , "Michael S. Tsirkin" , Jason Wang , Andrew Morton , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , David Howells , Marc Dionne , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , , , , , , , , , , References: <20240415131941.51153-1-linyunsheng@huawei.com> <20240415131941.51153-8-linyunsheng@huawei.com> <18ca19fa64267b84bee10473a81cbc63f53104a0.camel@gmail.com> From: Yunsheng Lin Message-ID: <74e7259a-c462-e3c1-73ac-8e3f49fb80b8@huawei.com> Date: Wed, 17 Apr 2024 21:18:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <18ca19fa64267b84bee10473a81cbc63f53104a0.camel@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500005.china.huawei.com (7.185.36.74) X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4EF404000C X-Stat-Signature: sm3n3pq98ey89rfugknw97715xhcebmx X-HE-Tag: 1713359925-555426 X-HE-Meta: U2FsdGVkX1/ZSP/YCVSrdpqXMa+ajsjxerVf2O2p742u3Dw6wOOlmeR8PyZwScBcj6ffNlgPpu1OFHUa9JtHPhRhQHXSUe2iuQ+UxeQ+J666ng7GKZ25fIgyaudtfESqrs6XVOw9v86GEwYAWNyJQn35ITfwRXXPwvwpD+2M/DSGnhx11FflVhUwXQnTDoh9XDoDt0KNB7Mn56QOQdAMI6O+Q57aiNAqHl8IL55p3S0vpf3WNfMD5ubrDsowAIFsE7AaUyfEyuZsRZeRJTFTNuW74h0cDPogSz9qFTshO3iX31sIHytrX7IeZb5V+jtLE5HA/LCr5dUMwQVicPljZF5fEOFL6Jz2SA67wPe2/OZ6PQnpP9da25FmlkfG+4dLQfj7y/ZUjeeVw+7L+M6GFuFAYd7n5YEdrTWMFr1BRJ0Ns1izqXRF7TpaNiIhPfRgivvREfK7d1elWWls7n6nmE/uLdp5eCvYhHnQQ0Oo036oICD/s+kdqXL5XS8QUcpzq4g9odH7FTOYqEQ4hruCkgd/yrP5Z2NCSaDOXMrcCgtpazd2KYoQHoPOzc4LdxrDE11DTqXNrvba4mMMNEUTmytvTJtKla6FyYNVbmYEkT+/Mhs5fBE92Ifn9cl7kVbiNqKiy8nVwhMSdDo3NfOZeEJYuSHwx3GOopQRBpM7sopw7YAd5CpQ6YvUS01aWKCMy3/ajyhLjJCPtxQQczs3FF5SgPrQckebhQrcScU2pqtqrHzV8nKKQVzdOWiqPdAnc5GoJXg7PgPihBWYVnP8U+vZRmJaAvP+CGC8fqAF9AtO/XyAqSq9zgkkKSnItZIIOr28fxxK7IDaCBVunXodoxLSwNL4ZpZk0PZmx7IVtWeDH9f1X0RQ1K+pbEKRIDibidNu8ZU1DdS7/J2UiGjDR6YqXyYptQWSIlrJG/Q5F64= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/17 0:12, Alexander H Duyck wrote: > On Mon, 2024-04-15 at 21:19 +0800, Yunsheng Lin wrote: >> Currently most of the API for page_frag API is returning >> 'virtual address' as output or expecting 'virtual address' >> as input, in order to differentiate the API handling between >> 'virtual address' and 'struct page', add '_va' suffix to the >> corresponding API mirroring the page_pool_alloc_va() API of >> the page_pool. >> >> Signed-off-by: Yunsheng Lin > > This patch is a total waste of time. By that logic we should be > renaming __get_free_pages since it essentially does the same thing. > > This just seems like more code changes for the sake of adding code > changes rather than fixing anything. In my opinion it should be dropped > from the set. The rename is to support different use case as mentioned below in patch 14: "Depending on different use cases, callers expecting to deal with va, page or both va and page for them may call page_frag_alloc_va*, page_frag_alloc_pg*, or page_frag_alloc* API accordingly." Naming is hard anyway, I am open to better API naming for the above use cases. > > . >