From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1011CC2D0A3 for ; Thu, 29 Oct 2020 15:03:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6A97E20838 for ; Thu, 29 Oct 2020 15:03:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="wGv2x8lX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A97E20838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 98EB16B0070; Thu, 29 Oct 2020 11:03:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93DE76B0071; Thu, 29 Oct 2020 11:03:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8539A6B0073; Thu, 29 Oct 2020 11:03:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id 4D8166B0070 for ; Thu, 29 Oct 2020 11:03:36 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DFC55824999B for ; Thu, 29 Oct 2020 15:03:35 +0000 (UTC) X-FDA: 77425281990.12.sign41_010bf632728e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id D820F1801A754 for ; Thu, 29 Oct 2020 15:02:33 +0000 (UTC) X-HE-Tag: sign41_010bf632728e X-Filterd-Recvd-Size: 5178 Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Thu, 29 Oct 2020 15:02:33 +0000 (UTC) Received: by mail-il1-f174.google.com with SMTP id c11so3330327iln.9 for ; Thu, 29 Oct 2020 08:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2ErZiibpE5H6uo1dJQvt55mz7cNylsiogjcwpdbZ1SI=; b=wGv2x8lXsF6G3f4qv3qxK3MCimjnV8hOl/t461GwdaE/Nx9RKCqLKvtLyZj6rbvori EgLuRZxdjn8+FoPwWW7beWRglKWhuLQvJWfCArOF0U+gQWJvv79YSJbg9o8hL1kw3jas WXrr2B+663nElS36CA+4q0PNtrk8E5wxxTJsQEzCZQjhh9Di/0TXBHGW0pkQKzGzzQns akSJYbpuNkhe9VGSE8RxrNr1EoDZUpaF0dtKG97HlC9jIDgvdi0i1oxWlQIwSEE/ZLNq dgb5cywsYRGzjY5MD54OhqwfY2NP9pEUVi69XGCgmAvEwhmk2lUCH5CXNbYmU2rK60w9 mHEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2ErZiibpE5H6uo1dJQvt55mz7cNylsiogjcwpdbZ1SI=; b=EbF+YAeSzXFWXSrpSegRyK+1me+i+zgN3EJe3gjymmrMbIcLRBfFJ2UQKd/9tmrj4z IuRqR9GeQ539wnCmnW2EXv2v/6I40InRS+AGm5UEN0rqxeO+4RtY2hjECVljBfTkV3rP 75ZrtVNNY0E0d6lrkJ2b0wHTeUuXPxLDhHD0ZkmeNOMWSBmcboBU+q9NgUuHH7imNYSD LwdVbf8bi5vx4lzP/AKskXpGOP3WrQ+fxVYL3Vr4fuLkbewLA+bKkWeTXBz+An+8xpxg VwdKVqZhJBURnDsqAzIBj/1m/Idu3wtMKdUqjo5N1vev3Gnq1fsCCx1lpP3tow/vvH57 TKCg== X-Gm-Message-State: AOAM533hOKNT700yMrmqIbls1kOXwdudWgi4jGM7g+MwbqZXRtGNAIkK QtuS71KGCGqiMv/FFWcZ/TS3SA== X-Google-Smtp-Source: ABdhPJwfIDzPQkxEVmabxSorpXGz6cfgiFWti3MGempjiT3vYivTQD3RL9Fu7+v7sbEF099i4sTx6g== X-Received: by 2002:a92:4b07:: with SMTP id m7mr3628919ilg.239.1603983752609; Thu, 29 Oct 2020 08:02:32 -0700 (PDT) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id d26sm3082055ill.83.2020.10.29.08.02.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Oct 2020 08:02:32 -0700 (PDT) Subject: Re: + fs-break-generic_file_buffered_read-up-into-multiple-functions.patch added to -mm tree To: Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org, kent.overstreet@gmail.com References: <20201025220817.XxXVE%akpm@linux-foundation.org> <20201027133551.GW20115@casper.infradead.org> <20201028152235.125172e46ae70ba4d7094469@linux-foundation.org> <543aa047-f334-cc40-8466-51bff70ac3b3@kernel.dk> <20201029145759.GA27442@casper.infradead.org> From: Jens Axboe Message-ID: <74d36f69-e14e-40e1-531e-edd1d2e3c344@kernel.dk> Date: Thu, 29 Oct 2020 09:02:31 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201029145759.GA27442@casper.infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/29/20 8:57 AM, Matthew Wilcox wrote: > On Thu, Oct 29, 2020 at 07:57:34AM -0600, Jens Axboe wrote: >> On 10/28/20 4:26 PM, Jens Axboe wrote: >>> I did see some wins when I tested this. I'll try and run some testing >>> tomorrow and report back. If there's something specifically you want to >>> see tested, let me know. >> >> I did some testing, unfortunately it's _very_ hard to produce somewhat >> consistent and good numbers as it quickly becomes a game of kswapd. >> Here's a basic case of 4 threads doing 32k random reads: >> >> PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND >> 462 root 20 0 0 0 0 R 65.5 0.0 0:08.02 kswapd0 >> 2287 axboe 20 0 1303448 2176 1072 R 46.6 0.0 0:05.35 fio >> 2289 axboe 20 0 1303456 2196 1092 D 46.6 0.0 0:05.34 fio >> 2290 axboe 20 0 1303460 2216 1112 D 46.6 0.0 0:05.37 fio >> 2288 axboe 20 0 1303452 2224 1120 R 45.9 0.0 0:05.33 fio >> >> Sad face... Unfortunately once kswapd kicks in, performance also >> plummets. This box only has 32G of ram, and you can fill that in less >> than 10 seconds doing buffered reads like that. >> >> I ran 4k and 32k testing, and using 1 and 4 threads. But given the above >> sadness, it quickly ends up looking the same for me. > > What if your workload actually fits in memory? That would seem to be > the situation where Kent's patches would make a difference. That was my point, if I do multi-page reads then memory is filled in seconds, which makes it pretty hard to provide any accurate numbers. I don't have anything slow in this test box, I'll see if I can find something to stick in it. -- Jens Axboe