From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F6D5C4332F for ; Tue, 14 Nov 2023 02:09:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBCB08D0037; Mon, 13 Nov 2023 21:09:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D45688D002E; Mon, 13 Nov 2023 21:09:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE5B58D0037; Mon, 13 Nov 2023 21:09:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A966A8D002E for ; Mon, 13 Nov 2023 21:09:40 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 837B5A0272 for ; Tue, 14 Nov 2023 02:09:40 +0000 (UTC) X-FDA: 81454928520.12.76746EB Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf15.hostedemail.com (Postfix) with ESMTP id 04D6CA000F for ; Tue, 14 Nov 2023 02:09:37 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=none (imf15.hostedemail.com: domain of riel@shelob.surriel.com has no SPF policy when checking 96.67.55.147) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699927778; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ACwAQzPrNgYB5yhWCr/X67CgNzFsnoqbLlOycNlhTYw=; b=hlVw0iOJCe6ERswky7Gbvo7zqd00oANauLaU59Q2gm7kcNDLgZGeJXf4Ip5is7KPSuh1n2 9OKsgMCTW9eHWa5CMugf7F9qCwORyHX6tH9VFEQgQyTELb8+QpDeu2hYBTFXw5VvfWX+KM 26DENNzI4CQLVE9geuOK9MJJRlmaTF8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=none (imf15.hostedemail.com: domain of riel@shelob.surriel.com has no SPF policy when checking 96.67.55.147) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699927778; a=rsa-sha256; cv=none; b=LiyaAD9K3GJsLYQhfiCkWyMcLdZc++FLyc5vVw9nHs8hz4eUUn3ewH4FprjCtJZwFaBplk GcnY7RNwvo31U0IihoB6LquVNBIeRavyZS5afNnexqHTmF9L399uCxbkLuj/BLUZ8EtQ9t oF1e/TYlIM2Qi/987ddH6B1t7ZHwaWc= Received: from imladris.home.surriel.com ([10.0.13.28] helo=imladris.surriel.com) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1r2iqM-0007BR-2R; Mon, 13 Nov 2023 21:07:58 -0500 Message-ID: <74c9d165c2e09f962467364319c2a2a4e05583a7.camel@surriel.com> Subject: Re: [PATCH] hugetlb: fix null-ptr-deref in hugetlb_vma_lock_write From: Rik van Riel To: Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Cc: eadavis@qq.com, nh26223@qq.com, syzbot+6ada951e7c0f7bc8a71e@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com, trix@redhat.com, nathan@kernel.org, ndesaulniers@google.com, muchun.song@linux.dev, akpm@linux-foundation.org Date: Mon, 13 Nov 2023 21:07:58 -0500 In-Reply-To: <20231114012033.259600-1-mike.kravetz@oracle.com> References: <20231114012033.259600-1-mike.kravetz@oracle.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 04D6CA000F X-Stat-Signature: u6w1jjt3f358p8uq8kre9qqs8397om81 X-Rspam-User: X-HE-Tag: 1699927777-5584 X-HE-Meta: U2FsdGVkX192rk1w0zPwtB0xvzlXL1gutB+NisZkke4RPJBJUoEqKsILIioKsx2Rb/kuGbeAEkvjfUq7k7ydn3atF9e9Rbmwl2V6TLqmqnNGrnkZjGlvdYwL8JenPU1udt86g2Mct6rcfkQKAkfdAVeExyzGoCWCqrtG55flpTgifZFIbHRK3f3Rj3Jt8vtfiChFOaNHFsBPXksjSnLUBBJ7c6VQ7VTUw0qMCpMHCF6Bs8n2wVTFkXBrtiBPjqT1BHAEJkW4j5NKnSumSQjDtuP2fgItxyxn8cYFDzTiu0yCjO1w/MBg5MJByIwfQHGSor8JjT10U8/mYfPlAQyMgF4CathVSLEZ3Z0NEZs8g5T14pWwvZIyK/R5loFgvuqYcLLCfJjwHdUBIyn/dYwFAS7PSsmosYYWH2t0iOGJz2y7Ar6MenAIR62h2VdSE/ASbdosq+S6MjWLorudKulX5onS3ORjVfMhHUvDVE0Zkt1CmB6/qvajJLbWywbk4Ta2piiB8sBduMd/zLkk5vBXOB26fWD/7gXIQU1cMr3W6gqhRRK0PGwU828TFwLCL7zGNGgDeI/E5U45qrfPyzm3xcF5EOQyPh+fpDfmqvdQT01gKAz2yF5e4muxRJu/2vTs6zQq/C5fGwYhhPgH9zFhU5+/vwAmRWJAkdXaCUuIwV2r/N6CYwGqY+grxTt+WLkae4v7RDoX84R3uM0r+KauB57rKpslt+dnv/+dqqiGgKzxogUVuKrPbWSnn6+7UZNgHCWWmMAEpS5Vu7CLgOmrJUs+pPfNWAES1Ra3mnpcpyyZ8Qk8rKV5h0+ub1BUOW8zuGZjRVRXacSFZhYseiWy81cDHnhdBoTvPF2gPrJUOAzJtc0Zt0oHOj+UHk5GmG3eSqrKbCmwwz1/B+R3Knk3EgBW+KWKi41nRO2KYhXtz8v/MBVODd4xLOxM7/huMSNtpZBn1o+G6BDmKFRGdiF G5wii6TG AZwL3QrqGvWwTSEnkmm/ylF0qlnn/RPB9g68XDPioHi9jI1jxjQeqX+R9Bs77ol8vHB+1L/Hmm3BKFh8TATRdHxOc7WRFqYI3esnYCLlZ2NdXk+I+UseVXI9DwR/6LR92ufNyF0pkSkSkA/UThfRkiP3SmpG84RPeeSugfKnkmGpdrTOS0Wul0z+wnC8+QXOiihPKae1ylhldacjELKon57pwlFZXlJ/S5ZmkMAaIvpWUJP1O25RlagaMSlzvvfTyanT9VG9Pq2B+7tepmSugINrv9v+A5PM0BXYVhHZHJjsBrJC9Jt764SM/4c7lQ/E94FQad1xJNigh2XQpjDrQ4HUU86TOwStcULA5Rh7yivBGcfFLNVUSA2vCf/L7c415stbRk2R+dCrFKGSJpoF1vKvNjYAs5lgJMR7HtD6+J8dGgvmZij8+pjDngmr7Y8DWBTkFmCteBUFolXGhJgdpdsshzyrpQB8v5K4VFHEVTkR9p6SujhFEZ3/riSAnHnkwimCGM2wP+wj2ylcpQ/nmkxmUp2r/yddAIzMRCiTWqL8IDe6psNV9EplH9mkFH790/k2gxVzHqERD0EjjUv/t/SS4h2FJIFV6bZm6ReRms9R50GpFMbpsdJ+FPkKsdVOegZfm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 2023-11-13 at 17:20 -0800, Mike Kravetz wrote: >=20 > Mask off low bit flags before checking for NULL pointer.=C2=A0 In > addition, > the reserve map only 'belongs' to the OWNER (parent in parent/child > relationships) so also check for the OWNER flag. >=20 > Reported-by: syzbot+6ada951e7c0f7bc8a71e@syzkaller.appspotmail.com > Closes: > https://lore.kernel.org/linux-mm/00000000000078d1e00608d7878b@google.com/ > Fixes: bf4916922c60 ("hugetlbfs: extend hugetlb_vma_lock to private > VMAs") > Signed-off-by: Mike Kravetz >=20 Reviewed-by: Rik van Riel --=20 All Rights Reversed.