From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36D92C369C2 for ; Mon, 5 May 2025 07:38:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C39326B008C; Mon, 5 May 2025 03:38:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0E9D6B0092; Mon, 5 May 2025 03:38:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAF156B0093; Mon, 5 May 2025 03:38:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8BEA86B008C for ; Mon, 5 May 2025 03:38:50 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E61671D0DDE for ; Mon, 5 May 2025 07:38:51 +0000 (UTC) X-FDA: 83408052462.23.97B2602 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 8285440003 for ; Mon, 5 May 2025 07:38:49 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=C0anQvmD; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746430729; a=rsa-sha256; cv=none; b=SCBIBMa3ELMc7TgGR6OcBnuNJXajsRaNd2fK7fQsxk+i1aAJI7Td1pXLaY3MsKForJpJz+ x1NsHTD+GwOHl+4HJy9UC/fBiuaLiY30gjpnNEoJMJzfdRP6Eei9WyluwCtpsGOJWxvIS+ KvUK5FakfNX9maQ3yL4j/N6dXfGfyF0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746430729; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MCO47hCm5SCIZwQbqs6/TwYIkzZu4R4yD4YHYqtYwZY=; b=gOHfWrGoKBhPAYWSd8+wwCBdDCRZNEmNpzs4y+NW7p3Kcjl3bAzai5OBDlanYq1lWWUZPU Zt0yzBmRgqVrHnucMB5i+SGMbwWBZJRYKrlZ/fNx+f0FW+bor5HJHyGGHrdPT4dJrhcoJj eFCU+7FT/PPMnuruR4USB8Fncfxb/fA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=C0anQvmD; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746430728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MCO47hCm5SCIZwQbqs6/TwYIkzZu4R4yD4YHYqtYwZY=; b=C0anQvmDHbG9lZCC3vNkQJIG7OOvluk7KbpkyucW+oX5ZBdiEPiZC352IzNa7kj5CNUOYP WjDSg0GHMMoIisJ9ivGL1yjcuErbsJ0fjTp3NAA8tbRNFy3D9u9Zyp/jAhs4zmLs8vlqRZ Ht+vplyeXkHGCKp1sM0ZVzKW3zUU0CA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-FZiTj_xfNgW3uTC5hawd7w-1; Mon, 05 May 2025 03:38:48 -0400 X-MC-Unique: FZiTj_xfNgW3uTC5hawd7w-1 X-Mimecast-MFC-AGG-ID: FZiTj_xfNgW3uTC5hawd7w_1746430727 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43cfda30a3cso19521185e9.3 for ; Mon, 05 May 2025 00:38:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746430727; x=1747035527; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MCO47hCm5SCIZwQbqs6/TwYIkzZu4R4yD4YHYqtYwZY=; b=MmHAYQGIpiJlZ/6VF3K9CKywON37P76V/l2b9hoSNVaSyYqxRF8iDbydT1PFD4Udue Rw9cv9GNQLtoLs11bX2+vCyIxXpCI3sRIRFuFPUBNzT5bro4t8SFmgXeWt4WW6OTK2+M x1w9T6UB3IXceSldCjzHwYtFLWvOWgC8HSBX3axkIfMbZ0d/WVt0A/lvq3XJ9HW4Dr/0 OZ+YtveXn9UXVPZB3nHBCYZUKO5UOo0L4wbXv4Yr9NO968CJHyQ4dY9r6RND1Ivu72fd Y+Q/JTl7qJFVrB2Nvng7nYKjvNTYuJcWhkH0aSw9CI42A9VaWNEaaZSzXIQUP+nEK5eF i08w== X-Forwarded-Encrypted: i=1; AJvYcCVA/iMrRbEbj8bC3iptifCMdldPCW4SVyR4/9r2Irc60vttHg4o73LOxrFtSs4RhLLmGMWFPxabVA==@kvack.org X-Gm-Message-State: AOJu0YzI/+zZ4MYHYQFAoaEQH0hT4SPhavzR9oiAVOd+OWKPqZmFQxjL C1THKj5xhUzlAQYshz4FlxbD6h42U61mKruzOw7KL8iasnSF0MrPD7D5ikq8CZCocORRDVA/Uzg hn+/5k8TZphD/Od1vmv0Uvk1XfUtGEM9xOZsmgTR/Zk5HsQMo X-Gm-Gg: ASbGncs+YXS9/60lMbPC970NnrZGakOz9CO2F6wKCZwZpa6GWoIIzrlvohC98tBDfv6 SMJQbzMh1k3g0QHvXxZ7a3UR0q11FZpPpK2GC47O8E0ipnQG0npoPo4dyWK2mYAKtF2H9rLqToU MXqRZ5TT/Dpgh3TQnEpyf+16RL5m0LlKJODhBnhBFfJt6xroPpZDyad+WCJlrnJtr/VpeHNhG/H aUYM9EG3kuWfEyKQoh5i/bkhQxjjQVtwi/zBo63WQKljuWhNFQWbQg3HJTFAKDai9OseCNxjYS8 TYYAfn/wQfrjYfMrD4pqJG3MetkStUjTkDXmJAID79Zh+yIsXSVdll0pbTMqRF1370RCE9UzJLs FPU9I5NlLCQSfb1eQg6DKDlibIEBKKyoIWZfOuLM= X-Received: by 2002:a05:600c:1e88:b0:43c:f513:958a with SMTP id 5b1f17b1804b1-441c48bdf64mr42548375e9.13.1746430726869; Mon, 05 May 2025 00:38:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEwlYiadMAWcRUEGecMRAz2hmkwus/eoEukjd7/nB+UjcUBgG5dP+wL6krd1Wzr/GS4vzplfA== X-Received: by 2002:a05:600c:1e88:b0:43c:f513:958a with SMTP id 5b1f17b1804b1-441c48bdf64mr42547275e9.13.1746430724700; Mon, 05 May 2025 00:38:44 -0700 (PDT) Received: from ?IPV6:2003:cb:c73d:2400:3be1:a856:724c:fd29? (p200300cbc73d24003be1a856724cfd29.dip0.t-ipconnect.de. [2003:cb:c73d:2400:3be1:a856:724c:fd29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b89cc4f8sm126409795e9.1.2025.05.05.00.38.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 May 2025 00:38:44 -0700 (PDT) Message-ID: <74c500dd-8d1c-4177-96c7-ddd51ca77306@redhat.com> Date: Mon, 5 May 2025 09:38:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] driver/base: Optimize memory block registration to reduce boot time To: Oscar Salvador Cc: Donet Tom , Mike Rapoport , Zi Yan , Greg Kroah-Hartman , Andrew Morton , rafael@kernel.org, Danilo Krummrich , Ritesh Harjani , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <188fbfba-afb4-4db7-bbba-7689a96be931@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2-zQJQeCYU65TT0YGKCASV3uPpmZmsl_8sg7U38pzQ8_1746430727 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8285440003 X-Stat-Signature: toc3uq5i89ianephct3tke7soqgejne1 X-Rspam-User: X-HE-Tag: 1746430729-85686 X-HE-Meta: U2FsdGVkX1+2qaNKXRULCq2m3s+Jh1uyzQ/dGZYvdQHzWApiVOErDUYTuGhVmJPkRdncUTmke5lz3m8+1rjplzzsv47QrGuQUTSfs70IIt+khnjfvsbzUmLjQfM5IdK3et3tCET6Nuqh2Dk0NTQj989MLEZLcwaprK1qEypTSKCdN8aqkycbCCpIrc6dqAKZPNaH84LTfab99ds8JRk1ozYYFunj4vgSvcQhy3vOGHI9fL0nm+L+sGuGfpfXCRvEP9oqA2tqS65m6aqXz0pzWuEJdJK3QNGW+mSSmScehMnrcp+kfEw3t3RzmvfNUb2ouiAuoTAyr0udV9Nb0zDZa88uAIev8tQ+pFyklXtY1ANOa//C8tvmGTCm+wp6f/mt63HNwsVOptaEGcR/Z2RkiYkZwVxkFzxvCPkZi8yHB+Hqbi2GEPOIFn9m8AbqqR/65+ZUOcBZI/ti71YQTHh0RyQwLg0LM7rEf5WG1HmCD7rrNGp1gL9DhLmm5hFGFqgIwHi7SMelftusIIziwdA73V7D8YVff5jyyXB6KYT31zXn1PigyYpIdvhiolwcp/iHNr4XnteoS3wOFlCyGgH5c1SJnShsY02yBBBlnya5AE/rhapYw7Q+b29soCG/Fy6oYzyAuTW/WFtapuuoXznsvMtsHASbg/2VEZTFCWSa2OxxsL5u/92qP968d6xQL+ZzpFr72amThfWbIMKKIU85Ff3y+Y8lkigwlgiyhyheFdrS0YAIm9FECJlrMByITHRXNC9nWV99YYPScUtqDTiZDU/BW+8V05yyUylFDZsgf435UBMg+e5KkaSjHy02yubeOGjQpfJ4QIT52TflBdR2zVN3P/KVg2HAIZAOvotbEQb7jRjqqe43iXqj8CZdnbCOgzbQKN5qk1cmogcOTf9OX6jOc3TP4HLQx0eSQeCJI+HVmlH1yTfHXqEj7hgaEvnIRn4dhabWMZzo25VjpzE s4eNttm3 UvyQjTffme0RGDfcCvrzmRnl+vXs+e8Wmgl4YnGZTkSxXwN/xNQZBP7S1ljusvaYlnfO0+hRu6Rw1cs5Aern20iXAKeb4lqIJl86+2Lz6MoeP6vWzYLZKTkg7+pKM+AbWBGuKYTnyTH5DJUmPsJUUlXjSMJpewporBkVKIxjAukrziLFfsRCLptSCpzJV6Zk5YfI7lCtNKJeZPs0JIuCdmtttpUFiH3vdLPlMg2iPgkkKR3hC7IcTJYxi0TNguwWZOnTk/gKun/oTrTV8/sN7OysHhqg3IJyFQUScx+dGKs45swnD8vE5lpkuEm7AnZ//Lt6s9Mwlr0R3BRzwiXGq6/dbXA0GEt8Y8dZx0iCgsPSdn8rQ25i84wCTu5oO5MNwyJeXU+2i74qYoGjSw0tMfNSFmDu5flm4NWVQKax3TZOPsOak/iQNdv3CIWm1nlHDL5kLG5GBzKCfcpfGR1d+YEAZFfbHI6ug7s7M X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.05.25 09:28, Oscar Salvador wrote: > On Mon, May 05, 2025 at 09:16:48AM +0200, David Hildenbrand wrote: >> memory hotplug code never calls register_one_node(), unless I am missing >> something. >> >> During add_memory_resource(), we call __try_online_node(nid, false), meaning >> we skip register_one_node(). >> >> The only caller of __try_online_node(nid, true) is try_online_node(), called >> from CPU hotplug code, and I *guess* that is not required. > > Well, I guess this is because we need to link the cpus to the node. > register_one_node() has two jobs: 1) register cpus belonging to the node > and 2) register memory-blocks belonging to the node (if any). Ah, via __register_one_node() ... I would assume that an offline node (1) has no memory (2) has no CPUs When we *hotplug* either memory or CPUs, and we first online the node, there is nothing to register. Because if there would be something, the node would already be online. In particular, try_offline_node() will only offline a node if (A) No present pages: No pages are spanned anymore. This includes offline memory blocks. (B) No present CPUs. But maybe there is some case that I am missing ... -- Cheers, David / dhildenb