From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDC22C5479D for ; Mon, 9 Jan 2023 15:14:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EAA38E0008; Mon, 9 Jan 2023 10:14:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 89B398E0001; Mon, 9 Jan 2023 10:14:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73B808E0008; Mon, 9 Jan 2023 10:14:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 652DF8E0001 for ; Mon, 9 Jan 2023 10:14:18 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 40926A0245 for ; Mon, 9 Jan 2023 15:14:18 +0000 (UTC) X-FDA: 80335606596.28.EEEC17E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 44882120010 for ; Mon, 9 Jan 2023 15:14:16 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OtRBx1sx; spf=pass (imf29.hostedemail.com: domain of jlayton@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jlayton@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673277256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jGx6PoEsb6PR924auXdkWMaue8Cj4xm3jkKMVjCj6Sg=; b=nJDnoosoh833oWKpC2/dLgG6Gl+A6S4fBH3+7TEEmH1W5kOWD5RxAZt1MVeYMI8Vh2U602 tSMuhA+zfBL/fpzkwP2IwPBCFe2zXGaAnhx29oQ5bmTLrJmBf28fWi1ML8pX6rxQRT2jQa oUR0oP3qrGTRJA4nkbsVHKuyUx/AkSk= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OtRBx1sx; spf=pass (imf29.hostedemail.com: domain of jlayton@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jlayton@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673277256; a=rsa-sha256; cv=none; b=zE2eROnvLHGt7AqlZxf20/FqDRwpYK0PVgS5fUFvwO63ihhSIiAc5iG30Vwi0ib1qI6T9f y2Dw8ih1g/t4tTS+dk3d5SHSUArtZdBY3jemK852bhwqzER3k83ArqkLWYqXKP8WEYPrnV MqGdXRO7oluP7wwcXae5+YGlsSkhOI0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673277255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jGx6PoEsb6PR924auXdkWMaue8Cj4xm3jkKMVjCj6Sg=; b=OtRBx1sxEFVJoakxq6Diz7iSF776cKSXjCjLd4UHbQyQsvqulD4sjrq/SrSABMZqkmKoFL x4fm9aTgmwnLKH4PZs0pmZf+VIz5ta6UBXzSzwwAQv6H2Xze2KEJDaENTnH5dRdf5ycF6S fG84jGxOyQvBIMKyX6cpUYzrWeSMuZs= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-610-23fiOEq9OB-sthqOvA_zfQ-1; Mon, 09 Jan 2023 10:14:14 -0500 X-MC-Unique: 23fiOEq9OB-sthqOvA_zfQ-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-4755eb8a57bso94927807b3.12 for ; Mon, 09 Jan 2023 07:14:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mQ8tZs5IQ8tViKAxZPeB3mhvDmuPPKwdwZwivLRuLtc=; b=majgqxSehb6sUXNUAV0m99Zr6lOekmUnveH+9WKOxn+gLTVhpd7AoCPnO0WYp2EC1d 86bL1Hwa4aqlZy4udVQSBrqTEv97I/wsdvsDk0M44y2u5C5ycMhhmk4rOmehwlqnfCuD Rer7hD5U75AVNYvhiGEMb3pZ4xsCkp/5re6yqJ/BN0MAHBnfnEOcPNhR2QLOWSRVOnio VExBg6TTqJ17NoyZ1bHi6pdSRNgqDlB3+PHLNfLJ4W8VyFbWgrEFFj/qNPWohky7XuHo TDXXpaMceHE9INN9vlr9Si18+d8dCKqlPKbgvKpOn6qlx/R6cvccLU+cIQhFT3cJ34af nEYA== X-Gm-Message-State: AFqh2kqEFy9gvRbtKopJqDWoDHUcBR2dgJU5ofbTNvQcM9a1V2zskfnn nhyJprLeX5zmSGvgVO718YrqA1n6C6awnJDNn8bPaaV8OH5Ew3vap1/7S6mhNjbWP7zqYXGDgBn IGnGlOzUAp2o= X-Received: by 2002:a05:690c:c05:b0:475:b3a:a4c5 with SMTP id cl5-20020a05690c0c0500b004750b3aa4c5mr2912335ywb.45.1673277253899; Mon, 09 Jan 2023 07:14:13 -0800 (PST) X-Google-Smtp-Source: AMrXdXt9FjiiWVTqShq0QW4xLjo26npQJ+ctx4FFo80NRDY7kXjEQdY4rWHuTqgPXE3e+uOyy0lqsQ== X-Received: by 2002:a05:690c:c05:b0:475:b3a:a4c5 with SMTP id cl5-20020a05690c0c0500b004750b3aa4c5mr2912319ywb.45.1673277253670; Mon, 09 Jan 2023 07:14:13 -0800 (PST) Received: from [192.168.1.3] (68-20-15-154.lightspeed.rlghnc.sbcglobal.net. [68.20.15.154]) by smtp.gmail.com with ESMTPSA id t11-20020a05620a034b00b006fa31bf2f3dsm5446848qkm.47.2023.01.09.07.14.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 07:14:13 -0800 (PST) Message-ID: <74c40f813d4dc2bf90fbf80a80a5f0ba15365a90.camel@redhat.com> Subject: Re: [PATCH 08/11] cifs: Remove call to filemap_check_wb_err() From: Jeff Layton To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig Date: Mon, 09 Jan 2023 10:14:12 -0500 In-Reply-To: <7d1499fadf42052711e39f0d8c7656f4d3a4bc9d.camel@redhat.com> References: <20230109051823.480289-1-willy@infradead.org> <20230109051823.480289-9-willy@infradead.org> <7d1499fadf42052711e39f0d8c7656f4d3a4bc9d.camel@redhat.com> User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: abgkqbzgf51q7ugss7rm77tozqxhqi3c X-Rspam-User: X-Rspamd-Queue-Id: 44882120010 X-Rspamd-Server: rspam06 X-HE-Tag: 1673277256-395304 X-HE-Meta: U2FsdGVkX19S4u+HWnTpxmkjhRIT6DsM+zswX9iCo+kzo6KI0felV+MXTIsP0N+D0CCUCRMcWWsX2llx5dDpkKTkzlMFcaT9otbGZ5h7hs12hSH4sXqqHRwlqaSXIj068QsRcnU76nGJneRvpX5t0sTWOk9yuHpTCidJXrblZHPHQ4znBaVf8kRSzllpRR9itsArUAgf1C3emWND7gDHKariZR/Wec1sXef9UhnwQiMfJt0OCZYY43iE8DnbFOzCPfHvYO/oL4aY+X2CZ8QZ1eWNGLkAKjE5wfbBjHc8SdVaBczq+JuaDUj0f0JJxH1p/VMuB73QdBfA4KZyHT/sP7hbTVoB+P2CFyeKLxPIxBFhEWemOjOfAUiQibCjrlIt78xLO5d3d85EiSFNrcAiE+DTZsKSVQAPdRaQf6ctb5WmjYLPXAkd7ymE10Tmybh6NWTlw7CLyJfCy7lXPkRgYal/ZvxL3GZtIfVZAXA1e6VZXZwV2QR8qxR0Wg4hJHvS5Qk/UaP3mafL+XaJzWbKvtuudH+TmemBeIe0Gl9ybRRFsRXXn2eXSpZGa9j9N39M6YsHydZcxFvYx/Hf93tOw7kM4O2Fy23CII/TBcFm1s+hc5D806JaL6kjhFAdXkeNso3jD+mdsjQkzZwo7bCCoR8P9jIfKqUui0V+y9y/Z+pMGJyDTxjwo8lkuo4L+PoaTFFoSoRmOsqJghCTuSvT7LX52zedXVMfMZlJjle+bQYvc8fbO4JGPpjsxfGU/endEia4DnMzeeOpo8xB7oULpDtYpgFV2Rtgw+SG6hSzyKOuMA/6oys8PTfOTUkbIJ64xUFbdtC7uFig24yB5T0tFN1WKeDfbfuPOzipx25s7lvQuVpilZO948eS4gxUXkztCVeudXfc7OJ1fJEmF0SPYkJ1xdYR3OLnkqMrn82RL4/5dsHl5mahe1kvoYCdaB/K9xIo90HPrY9ZXvta5e9 mrBXP9s5 cbrwVeVd43PNTu1bOtl+hZbKkw9hARlIIJ+KGmbIbL9JpOqel3P3i/roQo0RFgftDf6M3WJZOnxPs2bWr2lsIya83lxULWTGCehBBymxfmF8dG4H+yAXdZ6eEcPpp97xoKcKdbEwQb4WuwKnGqZhO9DHmrA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 2023-01-09 at 09:42 -0500, Jeff Layton wrote: > On Mon, 2023-01-09 at 05:18 +0000, Matthew Wilcox (Oracle) wrote: > > filemap_write_and_wait() now calls filemap_check_wb_err(), so we cannot > > glean any additional information by calling it ourselves. It may also > > be misleading as it will pick up on any errors since the beginning of > > time which may well be since before this program opened the file. > >=20 > > Signed-off-by: Matthew Wilcox (Oracle) > > --- > > fs/cifs/file.c | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > >=20 > > diff --git a/fs/cifs/file.c b/fs/cifs/file.c > > index 22dfc1f8b4f1..7e7ee26cf77d 100644 > > --- a/fs/cifs/file.c > > +++ b/fs/cifs/file.c > > @@ -3042,14 +3042,12 @@ int cifs_flush(struct file *file, fl_owner_t id= ) > > =09int rc =3D 0; > > =20 > > =09if (file->f_mode & FMODE_WRITE) > > -=09=09rc =3D filemap_write_and_wait(inode->i_mapping); > > +=09=09rc =3D filemap_write_and_wait(file->f_mapping); >=20 > If we're calling ->flush, then the file is being closed. Should this > just be? > =09=09rc =3D file_write_and_wait(file); >=20 > It's not like we need to worry about corrupting ->f_wb_err at that > point. >=20 OTOH, I suppose it is possible for there to be racing fsync syscall with a filp_close, and in that case advancing the f_wb_err might be a bad idea, particularly since a lot of places ignore the return from filp_close. It's probably best to _not_ advance the f_wb_err on ->flush calls. That said...wonder if we ought to consider making filp_close and ->flush void return functions. There's no POSIX requirement to flush all of the data on close(), so an application really shouldn't rely on seeing writeback errors returned there since it's not reliable. If you care about writeback errors, you have to call fsync -- full stop. > > =20 > > =09cifs_dbg(FYI, "Flush inode %p file %p rc %d\n", inode, file rc); > > -=09if (rc) { > > -=09=09/* get more nuanced writeback errors */ > > -=09=09rc =3D filemap_check_wb_err(file->f_mapping, 0); > > +=09if (rc) > > =09=09trace_cifs_flush_err(inode->i_ino, rc); > > -=09} > > + > > =09return rc; > > } > > =20 >=20 --=20 Jeff Layton