From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1AC9C4332F for ; Wed, 13 Dec 2023 02:57:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40DEB6B02F8; Tue, 12 Dec 2023 21:57:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 36F626B031B; Tue, 12 Dec 2023 21:57:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20FE46B03AF; Tue, 12 Dec 2023 21:57:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0D6516B02F8 for ; Tue, 12 Dec 2023 21:57:37 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CCAFF12065F for ; Wed, 13 Dec 2023 02:57:36 +0000 (UTC) X-FDA: 81560284512.29.BEFD6BA Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by imf27.hostedemail.com (Postfix) with ESMTP id E48DB40002 for ; Wed, 13 Dec 2023 02:57:33 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=UTdKH3Sg; spf=pass (imf27.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.167.172 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702436254; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vLWQ3Y/puZnM0632pjGmh7GqZF/HieDMjCcRFXmLY5k=; b=w4TwuLWu4tMqt5779HnHjZ27umTPGBy9cFBqoLkSKIRCpVyR1utD4nEeWsmqu4I/UbPJvZ tTOKDYhjKKk2u0/No9AWB+wdQX74hocYW9zm6RJoVH0/0TxtLb64IQdC4qEw8M0YETEihZ Qw1DXbgAuyUchopcm2k+TCUVtr0MxDo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702436254; a=rsa-sha256; cv=none; b=iGw0dvyqErNj3rDFvbw5NySqrDOvlTJq+UTm3kFhb86vlfnPG2F8bYwRBuNQWUayi3KIj7 TBuMyxCzWq0CLCP086DSBUZQpOOvziKsBEXjrpZ94GakKQouwDYMpPQ7TsImjvKia9vqUk KbKRmaBLi+m1cdjonPS/5MkOuYQjHxo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=UTdKH3Sg; spf=pass (imf27.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.167.172 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3b9ef61b6b8so3811586b6e.3 for ; Tue, 12 Dec 2023 18:57:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1702436253; x=1703041053; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vLWQ3Y/puZnM0632pjGmh7GqZF/HieDMjCcRFXmLY5k=; b=UTdKH3SgUIlhOeNpGXUlzlMVyPBLOciaxhdLBKGytyNotKCAgHGLSC9+l2TLQlGOqo 6UAyHQ0bW8OU9E3TA3OLvSPtPss5fU5mcpQUmpdMZTiPUIHglZK1PVr30xoBd3DntBwq 11Io7LBcv5PwTBMHbvU5gGP+JsAwcSGNfuiQ/iO7fjyvDcvn+lUgkS+VAs7g8RjHr26F gzisN6FzfEp0p1rYNhvP8EyudQ40OhpXZ3/xn7ZTza4yDGc6Nl8Afvmo7W8NgwaSk4YT ra70z3gYOgQXCVljpcHjwDgb6vB9+Jjt+pr/M0BJnEr/vS5aOSpM+/QZz0Val9snArRR aNLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702436253; x=1703041053; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vLWQ3Y/puZnM0632pjGmh7GqZF/HieDMjCcRFXmLY5k=; b=ZZIwyb2uCUwtbN6xNkSm/E4GWvSLsg8FMpkOER5aouKbx48XbLKvvEPNdfc9jxGpcU oKx2Fg6o1nMX5e22UftlOThEpo7bU6njpceXn5ihohjACawvTDbHDN8MmAK2kgW2kEzV 3VPrdXUf/HVa2nVtQ3yGfcSbBjVbsXPZ4609gYRuIf1dNUooTBsvbgtjUiHTOQ64FlQP jobOC9A9blSDKpS/5VYlZ2dbtjRGWyu6aNTYJebypyOcgwHaykRQFe3M3J3MuKwurmqB 3trTn5d1+y2jKbmt48vYNvLuH8N3vTqRNghCnnWybO+HUINcYmiBYnpzXuk/bsq7cJeF ZvUQ== X-Gm-Message-State: AOJu0Yx8+ID0j0NmLJgZPBaD91mQPCUBp59DrApM3TR7oBsoV5KnWT1g emBWw27lZJEdXu9UzfZatLwj/g== X-Google-Smtp-Source: AGHT+IEmkUbxSzpAz7MuEqoDgiRYykwXuYHAFRa816gEyRibtPZ1yK1RdGQq9t/8rodmc6Zejh4FOQ== X-Received: by 2002:a05:6808:140d:b0:3b8:4125:c1e with SMTP id w13-20020a056808140d00b003b841250c1emr8582165oiv.31.1702436252893; Tue, 12 Dec 2023 18:57:32 -0800 (PST) Received: from [10.254.248.243] ([139.177.225.230]) by smtp.gmail.com with ESMTPSA id x20-20020aa793b4000000b006ce4c7ba448sm8851643pff.25.2023.12.12.18.57.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 18:57:32 -0800 (PST) Message-ID: <74bb08ba-25c8-4aca-af04-18a45208bdad@bytedance.com> Date: Wed, 13 Dec 2023 10:57:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] mm/zswap: optimize the scalability of zswap rb-tree Content-Language: en-US To: Nhat Pham , Yosry Ahmed Cc: Chris Li , Vitaly Wool , Johannes Weiner , Michal Hocko , Seth Jennings , Dan Streetman , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox References: <20231206-zswap-lock-optimize-v1-0-e25b059f9c3a@bytedance.com> <77d628dc-ab8c-4d8c-bc63-7e4518ea92d7@bytedance.com> From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: E48DB40002 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: m5qj5mxc6dnbwr8bmkm61dibhkom1d6u X-HE-Tag: 1702436253-525645 X-HE-Meta: U2FsdGVkX1/YwjOPWFDpuc5/D6QMZ4+jzeVc1S37PJGBPG+6kJQglC1PRMSKe4HtnaVtW3PH3bKflGWEBg8FjcAYRvfesyaFpid8MPAHoCpyHUPkDpdJDQJAqaCqgF8by6mfB+ck7+h0ixYnTjFeYgV3+wBcEWKDPxAKOiHoPXKRZJyBBMM7C3h7iYlm8LvzfDT8Qdo/8PGAkATaW269GVhnzyIZO5oCUHhZcM2Hxl3Q0r8a66qviJZHrh3/6EXAhbL0qRxSzZ5hT1F5J30IFJ3BOw4A1vMkIXm+QtaEGIyNbp+INeESXGyzc8Mt25zLzDa+mPU0raj4hPP3lVzSvJyyWVfkQIybsNEoDMzcivubtFPxaNnVi+rGZvjVun7kcKMJAHLJeKpsYh42ge33nlo/TfTriXW94XGKG3A7p1k/i39AMDU74OYhk4jtG2eE+K0r/Fpp9xW/eAr0xJWQx4piwnzVV/b6nDSIcc34hHGmY2Q0n0cYU9M0bv5zjaeIrVFkd9cv3EuAp6ekUrBbHcSbPwaJJka3OG3dXEygqaVwLiqY5SaOv2kzXN05eW4nrVm+pQcrO0rc01nCkDsep8EcHD+F1MNGQIXhrJZEQycEx27l3biudvGKPRbSVzCjSa8cDNGWGDb3QEeyWvUFAGlNF9W73f348hAUXyztRv8iPNyFHu7VI7uXBvzk2d5M4srAI60Ftw/UimC2oo9duF/4t/zUMNNs52QxS0U9sIDcbQcGDYzJ3HRyYJ7NQ907jLleTOrXw6Zc/10f97nMKxwqtLiBmXLXZBUdg5cQAN45tTptkflt4jg6ryv6ovrxl/1wH6sK+xHNqF22VIAx2AOel3Onkk3zAuJ7FAdw08i7XD2BnNZHpMGBZVnEJ8sRrHn6oaIn9Gi6bMEDwzb5oTv9OJ3tJ9pI1+0W9nohJaUdVzJC5Re9A1KygAzqNUOFR6xK4qRrac2LPN0X0DV 7I4Skzt1 FZdAAi1XHD7Ho/hQUb1sjGzdZKDz1naeJDzLU7r3mAxiKejTG2BnWmW5YRNMo7UKqmmHxvyh7NEKaBWklMow/lOiqxvwJ3jSQIoTb0O7oyNNzSDT94OFSafUlYxa8KBvRSQ0EeZBREW4aI3fNnMlvz8Dj6YPPaMjXj+Nyr7UJsCUABq/bE4eSqe8NLPxb7yxAfMg87UMJSB5SUO/SSitfIK3DZo+faLqraLcKdg5Qtxlai0HUGjdPBbz+5NnnxiJux9B0bEOKHuzqvBEhIlyeYUFpGZkVZmEuVWibSr1XWdomX84h9dUoY/87uq6MIX3Q/ci++FxQuqD+2MSo8p3tSSNfpAm6W6BYEWAAghWCg3/XZMtxi6Iz3uy6Lvyu5uQF2cQaK3khyZRQPo8NZEAo1IudE6qWR120zkm1UqV+6RdzKXGOJUxaj9wD/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/12/13 07:33, Nhat Pham wrote: > On Tue, Dec 12, 2023 at 3:27 PM Yosry Ahmed wrote: >> >> Let's split the rbtree breakdown into a separate series. This series >> has irrelevant (and very nice) cleanups and optimizations, let's get >> them separately and defer the rbtree breakdown part until we get data Ok, will split and just send the cleanups/optimizations with dstmem reuse. >> about the xarray implementation. Perhaps the tree breakdown is not >> needed as much with an xarray, or at the very least the implementation >> would look different on top of an xarray. Yeah, will retest on the xarray version of Chris, the implementation is easy anyway. > > Actually, kinda agree - I quite like the cleanup/optimization done > w.r.t dstmem reuse :) Thanks!