From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3273C02181 for ; Tue, 21 Jan 2025 02:47:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35CFB6B007B; Mon, 20 Jan 2025 21:47:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E57E6B0082; Mon, 20 Jan 2025 21:47:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1860C6B0083; Mon, 20 Jan 2025 21:47:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EAE4E6B007B for ; Mon, 20 Jan 2025 21:47:06 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A6CF71A05EB for ; Tue, 21 Jan 2025 02:47:06 +0000 (UTC) X-FDA: 83029922052.02.4695286 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf15.hostedemail.com (Postfix) with ESMTP id 88C53A0009 for ; Tue, 21 Jan 2025 02:47:03 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737427625; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oMkw+zZtVwAoBYUsUMhmOuT8XcyaL0GO7Ri+t/R8CBo=; b=eFps1maKwM/SWsGppROF8hNsKN+Zn8J1y9J7Nxs5RBDYznq9LWATh/oVGXJnKTZkmVotJ7 FkkukJUpkq4W4+nk7K/VhEyPmU1fqTvNhwReh/XznSrt7nHNkVSIC5qCYDNgvB8hfTValO Kt8V+ack0dd+eevj3ouHMaDof76oyqI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737427625; a=rsa-sha256; cv=none; b=ENMaTuiIYk2B3zlVKm+DfSLkGdnXgTQGV0WSxUrF5SiIvlSzLN3sT+e1LHBShaJd14f9Mc WZrldWE7u4HKyVC0Pxg/i6we1zL0jxPAkNUjWPFqmNy6hv0GfmWoop4NlE/Ua80vzcvM+A +3zx0lKuprocD+0Wnd6SHvO9Az+/rk8= Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4YcWj10PSXzjYDQ; Tue, 21 Jan 2025 10:43:01 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id 7BD971400CD; Tue, 21 Jan 2025 10:46:59 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 21 Jan 2025 10:46:58 +0800 Subject: Re: [PATCH v2 1/3] mm: memory-failure: update ttu flag inside unmap_poisoned_folio To: David Hildenbrand CC: , , , , , , Wupeng Ma References: <20250116061657.227027-1-mawupeng1@huawei.com> <20250116061657.227027-2-mawupeng1@huawei.com> <21674fcc-bd5d-3e32-6e45-f0a16ab93202@huawei.com> <34ccd133-7623-4cd8-aad7-08526a97c472@redhat.com> From: Miaohe Lin Message-ID: <74b97e70-fa21-28c3-cb51-3a4ffb1b581a@huawei.com> Date: Tue, 21 Jan 2025 10:46:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <34ccd133-7623-4cd8-aad7-08526a97c472@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemd200019.china.huawei.com (7.221.188.193) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 88C53A0009 X-Stat-Signature: 3bjx7cqx5t36fwwahzi49ke9fz7g7ed4 X-Rspam-User: X-HE-Tag: 1737427623-817931 X-HE-Meta: U2FsdGVkX1/AxGGswiHEbQxLTzH4UE4bTne5fecZ0WUz4hruBApZNnv5Nk9q9jseObybtVxzZxQEL2pnKIRGHUWXfihGHC152zpgxjA3+9hxgbqlCmG6bekNi3cX+wyjOIMPDo6u6wDh6K0QAzQX3fhZW0uJgqB6B5jnikXw5d82gC9gf8WIi6u0JKCOg51SFY/HbeJ1SxPwKHJtjmgTeO0CdD4cI3bbKWmKpEwGdeFfyNmk05G5HxGZOeOMwsiEPKnNi7n5032K6yfeopaWgGAA4bOLVWoOKi3k5LTP74IkfSWycC72fyt1FNI1DtGNpFgYQnP/jr0SQV7f5lGH0oVrU0kDDU9SXb7nOV2WZ/JMisNAHFOqnn550/cFtyx5Ok8ChGC4D/w6/9mAzGUrrFgLcy56LsnD1WK8dVuRlqSRW96Iq5UM8znjlVSnePp2u2Rvb8HG0uKpLPYj6yylfiADhJ1PK53pE3aDn3wq5WHhCkS1LYE//aSRYAp+TFMNWSoKMDyS3mk2bxsmbL01oKJICVxJnGLeJSz8mECTkph+3KApV0kDwIwbS8eJWDU8yMjxw8D5/4dloQEjBNAffL22oGtyJah+NINUCdKwYRxytlOe9r3KOPBZszTGtGrrsxixN/DUaeUshO0TnMDaM2vmh1YQf9d7bsSfeH/LKf9eoiQsoiJe7nLvzEnYvEyOPOON8VtRyXLgIZCGnPXkVdyWbVe7bLGdlhPGbJ5NSo2bEyXmOm6B6X8KUfe1gy9+hVOabfJAS2G6vvZhz5JLMc8/ptlxGQLkUxZRNx+oNjfFmMnXFA0VejQNTfvmYmPkp22ZTfFOp3oZll/JqQFQCGquynKMlb6KgqlPTNknhlJHtkcNtylibUKb+XZjvAhVKY/fZKnd1srEV2dVG2ECla4px+/8erCzLjWa33jlnwm/E1+emuG9ztLLpll7WkL4ehFfGznyQwzDvitqb8f f47wqy4d uQhLsCJVvAt6TildHTJRNepiKWIpUTx15DsSt3y096qhWXqeHXZE6NjaSfRzDLZFaeEJ5jp4x+tCe/4S1HqyMbqdNTHigwg9cWaqtLBXpbgRqEBT6w+BrVTcGUFcZEC1P/KDhT4zGzC7AQimplNBeGIAruzlpdKIczgBxz2mzh39nzEA0iB9zUhA8JPZlQ1jghuP/pEBK16S5/SzqUBi1GS9T2WaTLWvAQb+Lrg6cJ3J0IjiANzseDGTOTcg0ZO3WFcN8uZKmNc6tUdNkU2soF3VABg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/20 15:49, David Hildenbrand wrote: > >>>       if (folio_test_hugetlb(folio) && !folio_test_anon(folio)) { >>>           struct address_space *mapping; >>>   @@ -1572,7 +1598,7 @@ void unmap_poisoned_folio(struct folio *folio, enum ttu_flags ttu) >>>           if (!mapping) { >>>               pr_info("%#lx: could not lock mapping for mapped hugetlb folio\n", >>>                   folio_pfn(folio)); >>> -            return; >>> +            return -EBUSY; >>>           } >>>             try_to_unmap(folio, ttu|TTU_RMAP_LOCKED); >>> @@ -1580,6 +1606,8 @@ void unmap_poisoned_folio(struct folio *folio, enum ttu_flags ttu) >>>       } else { >>>           try_to_unmap(folio, ttu); >>>       } >>> + >>> +    return folio_mapped(folio) ? -EBUSY : 0; >> >> Do we really need this return value? It's unused in do_migrate_range(). > > I suggested it, because the folio_mapped() is nowadays extremely cheap. It cleans up hwpoison_user_mappings() quite nicely. > > Any particular reason we shouldn't be doing that? I was trying to keep code more clean (IMO) but no strong opinion. Thanks. .