From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCD53C7115C for ; Wed, 25 Jun 2025 09:03:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AB5A6B0098; Wed, 25 Jun 2025 05:03:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 482EB6B00B3; Wed, 25 Jun 2025 05:03:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 372716B00B6; Wed, 25 Jun 2025 05:03:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 251E76B0098 for ; Wed, 25 Jun 2025 05:03:21 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D02D6123A5C for ; Wed, 25 Jun 2025 09:03:20 +0000 (UTC) X-FDA: 83593334160.19.8FDDD22 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 94B6720017 for ; Wed, 25 Jun 2025 09:03:18 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="UAjk/2VR"; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750842198; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j6SPvABO8EkhAEJk1LKxiZOae6QeSJKDl11RtcagWeI=; b=QoY0i/ojicFT8EWgp0zQ+ljZEJXPnL3NR9VUDcHpAAHBXXtJ7FrotNgd4nZkLm6cfw4pdB 6aBQcKIZBACEFtytnW+fCCSPuEvgqzJziugQhkKFp0lUz+EfX0lCu2JAiswdKYraBOd9SV yP6VHunAjuxfM/KzaD3eUq1ij85l4Uo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750842198; a=rsa-sha256; cv=none; b=Az9uG7yrpekRyXakpTrxnH93kun22+UAtYEzx4qgne0dQ1tbhyWbzdnoAf+JjrFxRRGVBS GtUZOLPPflPxRPlRQl00jOeUy+opB3JWf147f1rn/EvzRFyByvTNgshUopVwYSLINRqU2x NZAbky5PFzVIcpb9dFPw9lgyQ+s5UEg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="UAjk/2VR"; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750842197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=j6SPvABO8EkhAEJk1LKxiZOae6QeSJKDl11RtcagWeI=; b=UAjk/2VRtRnHF3GtSjUPmKTuRSDVMkumeSgRuWifOXL58phOVaxFa+ftIZsjtata4QNA/s k5G7vwOdmLd+WI+9pVn0FnlNuGtaxbrmP0R9fXn8yt8RSZVVGNSwSNZlEIyNKXgqJpaQUO ThgpVn7GK3h8RUDVurntPLjSAOzwOCE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-112-ir_2cpCQMH-WYmf_yRRKzg-1; Wed, 25 Jun 2025 05:03:16 -0400 X-MC-Unique: ir_2cpCQMH-WYmf_yRRKzg-1 X-Mimecast-MFC-AGG-ID: ir_2cpCQMH-WYmf_yRRKzg_1750842195 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a6d1394b07so709688f8f.3 for ; Wed, 25 Jun 2025 02:03:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750842195; x=1751446995; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=j6SPvABO8EkhAEJk1LKxiZOae6QeSJKDl11RtcagWeI=; b=q+HoJrMIkP7A2k/qHsYFX9ehJ+EUgTaTNKe6u5g5A7Z34NMNIxWpuQHt4/8D4LZihV J7ESGdNeWCQDzQ6BlGHXmLookPLFbb3p+mFFkVTwVJevWRYtBMRjhyQpbysUANEtEiNr f74jppxU9gXGz0rDbVaIDsp1aM2h7ydtDmZm9kyfq1W1C1//KmJ5JVAI1tQXkWluYa3Z NmE/NFxMEIcxTBa6DSLqh1VQ0FXzlxFbfxKSRhJZVaqGxq2NFsOBscNWEFLEPua2SmKx XkIrqtPpe7FL77eZgWyF98Qd9KZlf86K1CE4S21JIIiko5SryTFLeLvnsOOM+R7NwiCI hIhg== X-Forwarded-Encrypted: i=1; AJvYcCUP37AnXd48k3KdTg591j2rpCekp4p252EYaLyKhCm48F+e+drGhU6VNqkYzWTpHsjue8HJn4praw==@kvack.org X-Gm-Message-State: AOJu0Yzft95U9NBQ+Dd3Zp2KOoyKWGRUE/Tp4TDh8ovB5+xX/kNlml+s /tikISpQz7miUTxy1mOCkOdrJlQxyegNwdNWWmYBkjQmI+WcyOGITdUxYOHvefAdyi6YRFf73bo ngmzeaefCHuAjtHU0M4o5S107rSorvrcFsWRdk+JVC5qtAv2zgvCz X-Gm-Gg: ASbGncswxJK5Vk7q2bbIWBjnUFTn7Ef81JFDO5yaKCveTEz0gTq3gIspb98RuV7KcXE bVUkCkOlbKE4nJsmDGxoIPxTu7QKn2ioNyzG2bgWREAm5CnZy4ow4CNEZWBq9ajKRETSAUZlvty g+oQGfvv50N9WACH5RZOfqMxQGr4ELD9NBdmtdC8bxzKAeYlZp52rVmqHvw0HAd4mkueW6ZqsqS hziXmxFarMcwtgszsx5dxs4fZZWH3mvFOhQ8HesGjD8VwP01iR9vAl9KVc2dyhpWZpcTh66eQk4 OYS985X1gQ9SyKtfMUn0nW+WV6bqjfifjjp1jdkgpxbPulONzitrfueqD8nOitqrtkXqhWap4V3 Mp+8s3PveH+qeYygkraB784GmuSNCTg+USo9yl9GonzIQ X-Received: by 2002:a05:6000:2709:b0:3a4:fe9d:1b10 with SMTP id ffacd0b85a97d-3a6ed646c16mr1271816f8f.45.1750842195151; Wed, 25 Jun 2025 02:03:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHazW5nWUfQCM5Vf0SuwnpR0088kA+f/uiZKl6Om44U23eQf/ruKZPkuQodKAJMBqp+4oD7Fw== X-Received: by 2002:a05:6000:2709:b0:3a4:fe9d:1b10 with SMTP id ffacd0b85a97d-3a6ed646c16mr1271782f8f.45.1750842194712; Wed, 25 Jun 2025 02:03:14 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:1b00:5d6b:db26:e2b7:12? (p200300d82f121b005d6bdb26e2b70012.dip0.t-ipconnect.de. [2003:d8:2f12:1b00:5d6b:db26:e2b7:12]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6e805d342sm4022122f8f.21.2025.06.25.02.03.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jun 2025 02:03:14 -0700 (PDT) Message-ID: <74acb38f-da34-448d-9b73-37433a5e342c@redhat.com> Date: Wed, 25 Jun 2025 11:03:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 07/14] fs/dax: use vmf_insert_folio_pmd() to insert the huge zero folio To: Alistair Popple Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-8-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FCWkm1SHom14CmO-Hm84u6koQjnyPYlrWlu6uWlsF8g_1750842195 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 94B6720017 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: srfwnt7zdspiyy4hcmo1wdfadwoeoe5e X-HE-Tag: 1750842198-540332 X-HE-Meta: U2FsdGVkX19yco3r2iqZbza5EDlobekQ7bnqdfpPn969d7XLgsk6GKQg/f/mC2AOVy+e/oTvxOYMNVCM6HCyKlze3XKxKrznf7EU5DiLnTKabTOE6JaDhs48CivYePxjrPE0uERsggEjvJBrMdDa2sTHKZxbvib/qoi8YXupuWiFfTYSlQ/vQ5G/ZHGu5MntEhWscvshmohrwqjwLlNAtmhXPT4MadumCkKhaDJXBg43um1WplLzIoXDGcEMP+z6zuPkpdxj+Q4rf3caCmw8z1qjJznHgGCN2i+T4GD86D0eMDruxm9FWjd50gdlR36GZEOHgxXpyOGmFQUZKWBnP7lVEjCuCRX07lL3y82AQAzMkipTBFlvPa9EqAgbZzh7u5hsG3rRIuYkHmkwBGpFGEDet3H4ZzM2THgjZGrszq2i/qqtZuCstByWSOonwx3pfdxB/0RdhWNRJZJVTLzVZJ7+pIEA1oNvBySLjWyzeATUwnNTbso43Xi5d/YsMSLmEr8+T+U1S9JMhSKAjtSyRudkZDVTg5Hlp1GHb4kG1/gJ66wol/iZJ9KJ/jqsKJQUw8IzkI4aFR77HqLUvOSSwfiu3AlZ+6BA1ScKTiV3KbG/tSd/B+HzjhxaQF0lOOudywpCxu2h5HmDbLHbFLBy6G7qb8888/maZRP/CKy3R7nXjP9deyHoYhnIoVeQyGMBmNyLTNAMoZF4rQk7Z7RQm63IGtkdQarEsHUoyHU5cXLFeK6y4uRA4YqTP6lEcLXigRM/jDLGn7vdxmouZ1/l0VaXS4WNMJpCJ9TrttvaQadgtJyxJSHe5f2SVA1JWqYDcf04HObbQ4IPCOD165IZi2snyiRX35dGdyTYyUIZBO8a1hHB7Au3TpEoSql5ekMUfrsm4KWl5ghxfpk45L/aZRWhjqPAtSWj6l0ZJVh2a+lkwCGl3zPkzKHr7kY92ZZf9DEPtpJimR9ewPPzoQb E89TG1t5 iIrtjSFLDVhnrDMi3Do4Jm9h2Cf+vmqQrLVM32/3h7LG8nn57KFJRTIHzoHrz8hXxoZnh5/99GnG4ObqdrHbZTyu7WIWM4mPidujfLdxdgsw+E0LzKEU5RyoCcKcmT0Hq8AAO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.06.25 03:16, Alistair Popple wrote: > On Tue, Jun 17, 2025 at 05:43:38PM +0200, David Hildenbrand wrote: >> Let's convert to vmf_insert_folio_pmd(). >> >> In the unlikely case there is already something mapped, we'll now still >> call trace_dax_pmd_load_hole() and return VM_FAULT_NOPAGE. >> >> That should probably be fine, no need to add special cases for that. > > I'm not sure about that. Consider dax_iomap_pmd_fault() -> dax_fault_iter() -> > dax_pmd_load_hole(). It calls split_huge_pmd() in response to VM_FAULT_FALLBACK > which will no longer happen, what makes that ok? My reasoning was that this is the exact same behavior other vmf_insert_folio_pmd() users here would result in. But let me dig into the details. -- Cheers, David / dhildenb