[linux-next:master 8679/9815] drivers/of/platform.c:570:2-23: WARNING: Function "for_each_node_by_type" should have of_node_put() before break around line 575. (fwd)

[linux-next:master 8679/9815] drivers/of/platform.c:570:2-23: WARNING: Function "for_each_node_by_type" should have of_node_put() before break around line 575. (fwd)

[Julia Lawall]

---------- Forwarded message ----------
Date: Wed, 1 Feb 2023 23:18:21 +0800
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: [linux-next:master 8679/9815] drivers/of/platform.c:570:2-23: WARNING:
    Function "for_each_node_by_type" should have of_node_put() before break
    around line 575.

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Michal Suchanek <msuchanek@suse.de>
CC: Rob Herring <robh@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   66eee64b235411d512bed4d672c2d00683239daf
commit: 2b54c9b44c7e7ac4d6b2e67a10db591e227c9c07 [8679/9815] of: Make of framebuffer devices unique
:::::: branch date: 11 hours ago
:::::: commit date: 2 days ago
config: microblaze-randconfig-c043-20230129 (https://download.01.org/0day-ci/archive/20230201/202302012320.Rl6PHBdQ-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@lip6.fr>

cocci warnings: (new ones prefixed by >>)
   drivers/of/platform.c:557:2-23: WARNING: Function "for_each_node_by_type" should have of_node_put() before return around line 563.
   drivers/of/platform.c:557:2-23: WARNING: Function "for_each_node_by_type" should have of_node_put() before return around line 566.
>> drivers/of/platform.c:570:2-23: WARNING: Function "for_each_node_by_type" should have of_node_put() before break around line 575.

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

Re: [linux-next:master 8679/9815] drivers/of/platform.c:570:2-23: WARNING: Function "for_each_node_by_type" should have of_node_put() before break around line 575. (fwd)

[Rob Herring]

On Wed, Feb 1, 2023 at 9:29 AM Julia Lawall <julia.lawall@inria.fr> wrote:
>
>
>
> ---------- Forwarded message ----------
> Date: Wed, 1 Feb 2023 23:18:21 +0800
> From: kernel test robot <lkp@intel.com>
> To: oe-kbuild@lists.linux.dev
> Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
> Subject: [linux-next:master 8679/9815] drivers/of/platform.c:570:2-23: WARNING:
>     Function "for_each_node_by_type" should have of_node_put() before break
>     around line 575.
>
> BCC: lkp@intel.com
> CC: oe-kbuild-all@lists.linux.dev
> CC: Linux Memory Management List <linux-mm@kvack.org>
> TO: Michal Suchanek <msuchanek@suse.de>
> CC: Rob Herring <robh@kernel.org>
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   66eee64b235411d512bed4d672c2d00683239daf
> commit: 2b54c9b44c7e7ac4d6b2e67a10db591e227c9c07 [8679/9815] of: Make of framebuffer devices unique
> :::::: branch date: 11 hours ago
> :::::: commit date: 2 days ago
> config: microblaze-randconfig-c043-20230129 (https://download.01.org/0day-ci/archive/20230201/202302012320.Rl6PHBdQ-lkp@intel.com/config)
> compiler: microblaze-linux-gcc (GCC) 12.1.0
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Julia Lawall <julia.lawall@lip6.fr>
>
> cocci warnings: (new ones prefixed by >>)
>    drivers/of/platform.c:557:2-23: WARNING: Function "for_each_node_by_type" should have of_node_put() before return around line 563.
>    drivers/of/platform.c:557:2-23: WARNING: Function "for_each_node_by_type" should have of_node_put() before return around line 566.
> >> drivers/of/platform.c:570:2-23: WARNING: Function "for_each_node_by_type" should have of_node_put() before break around line 575.

I've reworked the commit to avoid all these. Thanks.

Rob