From: Minchan Kim <minchan.kim@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Hugh Dickins <hughd@google.com>,
Minchan Kim <minchan.kim@gmail.com>
Subject: [PATCH v2 4/7] swap: Change remove_from_page_cache
Date: Mon, 3 Jan 2011 00:44:33 +0900 [thread overview]
Message-ID: <74a0a108b98f304efc2e28cea413fa3c9682ca15.1293982522.git.minchan.kim@gmail.com> (raw)
In-Reply-To: <cover.1293982522.git.minchan.kim@gmail.com>
In-Reply-To: <cover.1293982522.git.minchan.kim@gmail.com>
This patch series changes remove_from_page_cache's page ref counting
rule. Page cache ref count is decreased in delete_from_page_cache.
So we don't need decreasing page reference by caller.
Acked-by:Hugh Dickins <hughd@google.com>
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
---
mm/shmem.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index fa9acc9..079cced 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -1081,7 +1081,7 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc)
shmem_recalc_inode(inode);
if (swap.val && add_to_swap_cache(page, swap, GFP_ATOMIC) == 0) {
- remove_from_page_cache(page);
+ delete_from_page_cache(page);
shmem_swp_set(info, entry, swap.val);
shmem_swp_unmap(entry);
if (list_empty(&info->swaplist))
@@ -1091,7 +1091,6 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc)
spin_unlock(&info->lock);
swap_shmem_alloc(swap);
BUG_ON(page_mapped(page));
- page_cache_release(page); /* pagecache ref */
swap_writepage(page, wbc);
if (inode) {
mutex_lock(&shmem_swaplist_mutex);
--
1.7.0.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-02 15:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 15:44 [PATCH v2 0/7] Change page reference handling semantic of page cache Minchan Kim
2011-01-02 15:44 ` [PATCH v2 1/7] Introduce delete_from_page_cache Minchan Kim
2011-01-08 22:16 ` Johannes Weiner
2011-01-10 15:39 ` Minchan Kim
2011-01-02 15:44 ` [PATCH v2 2/7] fuse: Change remove_from_page_cache Minchan Kim
2011-01-02 15:44 ` [PATCH v2 3/7] tlbfs: " Minchan Kim
2011-01-02 15:44 ` Minchan Kim [this message]
2011-01-02 15:44 ` [PATCH v2 5/7] truncate: " Minchan Kim
2011-01-02 15:44 ` [PATCH v2 6/7] Good bye remove_from_page_cache Minchan Kim
2011-01-04 1:44 ` KAMEZAWA Hiroyuki
2011-01-02 15:44 ` [PATCH v2 7/7] Change __remove_from_page_cache Minchan Kim
2011-01-04 1:45 ` KAMEZAWA Hiroyuki
2011-01-04 16:18 ` [PATCH v2 0/7] Change page reference handling semantic of page cache Balbir Singh
2011-01-05 4:53 ` Minchan Kim
2011-01-05 8:52 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74a0a108b98f304efc2e28cea413fa3c9682ca15.1293982522.git.minchan.kim@gmail.com \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox