From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82DD0C432C3 for ; Wed, 27 Nov 2019 19:03:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2281120715 for ; Wed, 27 Nov 2019 19:03:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="pzHN7zvk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2281120715 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 813E66B04DF; Wed, 27 Nov 2019 14:03:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CCF26B04E0; Wed, 27 Nov 2019 14:03:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B2EC6B04E1; Wed, 27 Nov 2019 14:03:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id 5518A6B04DF for ; Wed, 27 Nov 2019 14:03:26 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 08B2982499A8 for ; Wed, 27 Nov 2019 19:03:26 +0000 (UTC) X-FDA: 76202980812.22.play94_3b04cddecff2c X-HE-Tag: play94_3b04cddecff2c X-Filterd-Recvd-Size: 4852 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 Nov 2019 19:03:25 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id a137so18686958qkc.7 for ; Wed, 27 Nov 2019 11:03:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=Ns8iu9D49xQ4IeMW2/4gv78eKGaXwmWoNevNMNlTk40=; b=pzHN7zvkbUTkQa4WJmX1slaYlJ5eM0y/srER0U9JFmrrKZgkfCntUm58vjFRciwZ4T 6TCcWfaYF+zDxmNgHb8sVScjj4QM3XFf831namegspvyfhL2x7SODdxhkKSRzYJajzAc OUI7IX79X6Lfqhz7c9BG3xQ/MPOaupuXfxPwC1usEyEx05/fPQeSyCoAUkqZfkbpJv1U Y7AqriiCVPd/q62rw2jDOJg+dc6mV3lSzNzDqa2NtGc78ByHVNxVoouEMCXnIoGDl7oQ Wde7lkJYpzJm2t4D6yoCNMVWMh8KxiPaMwW8kTrkUWAgU5m8x4B9YKfjGjAZJtjAN1A4 MWmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=Ns8iu9D49xQ4IeMW2/4gv78eKGaXwmWoNevNMNlTk40=; b=m5DnCkquy5M49u+SYFO3uNeqCCzvAGz7UXGPlk3HP947weBRWI/FWts4dxBROcBESW vjI4vBPF5e4UB673IO/bhOH5HVVA3rtCwnnVjx6OxV+qxmDUCNFMbsDqctz5jZVlV28o AonTO9o1uyXLivZIImjTMq590ZfFhaFu9gBlTEIul+8eAz+gpLreRWBnNc9qCb2JXz3w ESOqLS/Jpxii2HqVDmUx/FicTFUgjxoMP7KxEGNtT86wnHY4mjlQxS5WvlbpIT7CFkrW JeLq0Ds2TihnB172EofgX+6kYmVZsbYdgBmptTT9vUYhGRqZxPqmbCn4Xt4hyHG9K1Gp 8KrA== X-Gm-Message-State: APjAAAWYDWzv+UfsBXNo809zt99NCcLPZMWxX55zdE9x6GH7zctT6lVp zpLo8mAqZgCDeG46N619WPY7gjPa1lOv0Q== X-Google-Smtp-Source: APXvYqxiQmN/hmDQO7QTsbci5YUMHjW00APmZIZjqmyjyZBbOtcihhNld5EdGDbvmdS/4Sf6ulVOqg== X-Received: by 2002:a37:bc81:: with SMTP id m123mr6216808qkf.358.1574881404551; Wed, 27 Nov 2019 11:03:24 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id k196sm7242887qke.97.2019.11.27.11.03.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Nov 2019 11:03:23 -0800 (PST) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v1] mm/memory_hotplug: don't check the nid in find_(smallest|biggest)_section_pfn Date: Wed, 27 Nov 2019 14:03:22 -0500 Message-Id: <74CE315E-319F-4D2D-8276-7F89293286CF@lca.pw> References: <20191127174158.28226-1-david@redhat.com> Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Michal Hocko , Oscar Salvador In-Reply-To: <20191127174158.28226-1-david@redhat.com> To: David Hildenbrand X-Mailer: iPhone Mail (17A878) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Nov 27, 2019, at 12:42 PM, David Hildenbrand wrote: >=20 > Now that we always check against a zone, we can stop checking against > the nid, it is implicitly covered by the zone. >=20 > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Oscar Salvador > Signed-off-by: David Hildenbrand > --- > mm/memory_hotplug.c | 23 ++++++++--------------- > 1 file changed, 8 insertions(+), 15 deletions(-) >=20 > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 46b2e056a43f..602f753c662c 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -344,17 +344,14 @@ int __ref __add_pages(int nid, unsigned long pfn, un= signed long nr_pages, > } >=20 > /* find the smallest valid pfn in the range [start_pfn, end_pfn) */ > -static unsigned long find_smallest_section_pfn(int nid, struct zone *zone= , > - unsigned long start_pfn, > - unsigned long end_pfn) > +static unsigned long find_smallest_section_pfn(struct zone *zone, > + unsigned long start_pfn, > + unsigned long end_pfn) > { > for (; start_pfn < end_pfn; start_pfn +=3D PAGES_PER_SUBSECTION) { > if (unlikely(!pfn_to_online_page(start_pfn))) > continue; >=20 > - if (unlikely(pfn_to_nid(start_pfn) !=3D nid)) > - continue; Are you sure? I thought this is to check against machines with odd layouts, n= o?=20 /* * Nodes's pfns can be overlapping. * We know some arch can have a nodes layout such a= s * -------------pfn--------------> * N0 | N1 | N2 | N0 | N1 | N2|.... */