From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FFCFC433EF for ; Fri, 11 Mar 2022 09:55:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3F398D0003; Fri, 11 Mar 2022 04:55:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC88E8D0001; Fri, 11 Mar 2022 04:55:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96A5F8D0003; Fri, 11 Mar 2022 04:55:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 856258D0001 for ; Fri, 11 Mar 2022 04:55:50 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4F8CF613F9 for ; Fri, 11 Mar 2022 09:55:50 +0000 (UTC) X-FDA: 79231648860.08.01E7C80 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id C3D241C0028 for ; Fri, 11 Mar 2022 09:55:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646992549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0SbZtGCQk+RjFIs2wZUGH3GgdAqVUCvyBNpcfJWzG8I=; b=JlgEmcYzfuBiWCh3t3ulwyS8HjLGdQEvQ1mZvOkF+qY8GFoO84cZOSNGYGSv7GQQFO0OlP Jk5NbYETF7Th6J8pNBPkejGyM4e7jakT/UwHKhkHyA/GZ/gsp52VCGXrSLiwh7dj9Atg33 yEP3wIAMiYChpCtScKV+9atudusJXlo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-595-dG6f1279NXGDKuphm9z4qg-1; Fri, 11 Mar 2022 04:55:48 -0500 X-MC-Unique: dG6f1279NXGDKuphm9z4qg-1 Received: by mail-wr1-f71.google.com with SMTP id q14-20020adfea0e000000b002036c16c6daso2618991wrm.8 for ; Fri, 11 Mar 2022 01:55:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=0SbZtGCQk+RjFIs2wZUGH3GgdAqVUCvyBNpcfJWzG8I=; b=wRjk1uRZnZ6rKdStos5XSLLcDvRY9c6ahgxT08SbKmnyyqyrezPfp+vHstibgt1VOD jyGS+MJ2GTncxmoMXjlGzkXbD9B5b5NqKnnKziAqERkFEZHgjkpgFbJAVPs1yORi87W+ VNSDYOx89J8eT+W+stgI7iLhgkriDGRdiCZ4E6gNzn3xHZTWLNUFXxgVMwwHkrIlxNvC Gp/AA4uB6PIBj9iPaLpAquvBh9UfBEKAsUulzSTdMdmlGYUdWA8+PP7kfijqOaSSuFCi aUnWLawFZGm/hhpHW6uCjfG7HKYdsivATB8popsB3G4ExW38AVeolRR48KaduzxslGn9 dXBw== X-Gm-Message-State: AOAM531c8PcukWO16UBoCvvhz9FOiOadl8MWq5pG05fL1dOMYy2fh7eU vxag7XPojGJwDvw6kXzb1TQaaX6VI25R71b2RdV9DbpxrnCJeT1jih4KLDXbPUZ4QTImy/VbFiz 4TfDaV/ZswOo= X-Received: by 2002:adf:f70a:0:b0:1ee:33bf:3864 with SMTP id r10-20020adff70a000000b001ee33bf3864mr6498091wrp.4.1646992547129; Fri, 11 Mar 2022 01:55:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJwy7/m6Ad24W702h4xglXhkhq/XRbfI+NUlig4g23i0BZ8F3TjeAKyQUG7wWs7g/FTmvb0dbw== X-Received: by 2002:adf:f70a:0:b0:1ee:33bf:3864 with SMTP id r10-20020adff70a000000b001ee33bf3864mr6498077wrp.4.1646992546843; Fri, 11 Mar 2022 01:55:46 -0800 (PST) Received: from ?IPV6:2003:cb:c707:8200:163d:7a08:6e61:87a5? (p200300cbc7078200163d7a086e6187a5.dip0.t-ipconnect.de. [2003:cb:c707:8200:163d:7a08:6e61:87a5]) by smtp.gmail.com with ESMTPSA id r13-20020a5d498d000000b001f0587248c4sm6093300wrq.3.2022.03.11.01.55.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Mar 2022 01:55:46 -0800 (PST) Message-ID: <7496e04f-5b34-b37c-381c-8444199f2321@redhat.com> Date: Fri, 11 Mar 2022 10:55:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] mm/madvise: Use vma_lookup() instead of find_vma() To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220311082731.63513-1-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220311082731.63513-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C3D241C0028 X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JlgEmcYz; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf21.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: pcsb88mfkqr33tnueoxye61ox4iaoefn X-HE-Tag: 1646992549-33628 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.03.22 09:27, Miaohe Lin wrote: > Using vma_lookup() verifies the start address is contained in the found > vma. This results in easier to read the code. > > Signed-off-by: Miaohe Lin > --- > mm/madvise.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 5b6d796e55de..afd68bfc77d4 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -883,8 +883,8 @@ static long madvise_populate(struct vm_area_struct *vma, > * our VMA might have been split. > */ > if (!vma || start >= vma->vm_end) { > - vma = find_vma(mm, start); > - if (!vma || start < vma->vm_start) > + vma = vma_lookup(mm, start); > + if (!vma) > return -ENOMEM; > } > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb