From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB70EC43461 for ; Thu, 8 Apr 2021 11:01:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 36C1F608FE for ; Thu, 8 Apr 2021 11:01:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36C1F608FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8FD986B0078; Thu, 8 Apr 2021 07:01:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8ADCA6B007E; Thu, 8 Apr 2021 07:01:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 726ED6B0080; Thu, 8 Apr 2021 07:01:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id 591106B0078 for ; Thu, 8 Apr 2021 07:01:02 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 090EE6122 for ; Thu, 8 Apr 2021 11:01:02 +0000 (UTC) X-FDA: 78008907564.33.D03F09C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 3E47F3944 for ; Thu, 8 Apr 2021 11:01:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617879661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WQhqnjeZkCOh2eK1FDK8AD+p6DMcS/hFEdzGcfPMAFo=; b=Ec63m1aTQBul7FiRa4W1fUa+u8Y3xF7Rt5hKP916XhJsNnAkzHDHEGY/1YLa02TqagJW+I FQsnPiGlcOVV/FMGEQjMxKdSqeWZl3g4qndfEUnWmdlbNW0ckgm7Nu0nGMKw2nt7vTve2p bTwr+nKMLI/RuUF0MnU86rQ3U4NttXE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-546-cf3ok8EPM6mmTtU9zSKjug-1; Thu, 08 Apr 2021 07:00:57 -0400 X-MC-Unique: cf3ok8EPM6mmTtU9zSKjug-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4E56F83DD21; Thu, 8 Apr 2021 11:00:54 +0000 (UTC) Received: from [10.36.114.231] (ovpn-114-231.ams2.redhat.com [10.36.114.231]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF0CA5D9D0; Thu, 8 Apr 2021 11:00:48 +0000 (UTC) To: Arnd Bergmann Cc: Linux Kernel Mailing List , Linux-MM , Joel Stanley , David Airlie , Daniel Vetter , Andrew Jeffery , Lucas Stach , Russell King , Christian Gmeiner , Mike Rapoport , Bartlomiej Zolnierkiewicz , Linus Walleij , Michal Simek , Masahiro Yamada , Randy Dunlap , Peter Collingbourne , linux-aspeed , dri-devel , Linux ARM , The etnaviv authors , Linux Fbdev development list References: <20210408092011.52763-1-david@redhat.com> <20210408092011.52763-3-david@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Subject: Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv Message-ID: <7496ac87-9676-1b4e-3444-c2a662ec376b@redhat.com> Date: Thu, 8 Apr 2021 13:00:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Rspamd-Queue-Id: 3E47F3944 X-Stat-Signature: kw9ukfxe6naptotoakda87gpsgyn4s8e X-Rspamd-Server: rspam02 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf04; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=63.128.21.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617879660-137621 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >>> In particular, it does not prevent a configuration with 'DRM_CMA=3Dm' >> >> I assume you meant "DRM_CMA=3Dn" ? DRM_CMA cannot be built as a module= . >=20 > Ok, at least that makes it easier. >=20 >>> and 'DRMA_ASPEED_GFX=3Dy', or any build failures from such >>> a configuration. >> >> I don't follow. "DRM_CMA=3Dn" and 'DRMA_ASPEED_GFX=3Dy' is supposed to= work >> just fine (e.g., without HAVE_DMA_CONTIGUOUS) or what am I missing? >=20 > I thought you were trying to solve the problem where DRMA_ASPEED_GFX > can optionally link against CMA but would fail to build when the CMA co= de > is in a loadable module. Yes. I was trying to say: it works with this patch just fine. The issue=20 you described does not seem to apply (DRM_CMA=3Dm). >=20 >> Your example looks more like a NOP - no? >> Or will it have the same effect? >=20 > The example I gave is only meaningful if both are tristate, which is > not the case here as you explain. Okay, thanks. >=20 > It is a somewhat awkward way to say "prevent this symbol from > being =3Dy if the dependency is =3Dm". What would be the right thing to do in the case here then to achieve the=20 "if DRMA_ASPEED_GFX is enabled, also enable DMA_CMA id possible"? One approach could be to have for DMA_CMA default y if DRMA_ASPEED_GFX but it feels like the wrong way to tackle this. Thanks! --=20 Thanks, David / dhildenb