From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BF20CDB47E for ; Fri, 13 Oct 2023 08:04:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A49656B01FB; Fri, 13 Oct 2023 04:04:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F92E6B01FC; Fri, 13 Oct 2023 04:04:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C1B28D0015; Fri, 13 Oct 2023 04:04:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7A4F76B01FB for ; Fri, 13 Oct 2023 04:04:21 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5106C1CA668 for ; Fri, 13 Oct 2023 08:04:21 +0000 (UTC) X-FDA: 81339700722.04.0D0190B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 15475C0025 for ; Fri, 13 Oct 2023 08:04:18 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="MMAb/LPY"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697184259; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jnw6CV1in12hPMuWpKYAfFREANvgubRLaHRIuqtezJI=; b=KRzhC3ZRHrZhWz/qqEioMky7hNZhrmUsfkAKV0rOSHadYbIyNWY7CSZk6IOR3afzPCFSyN rJzFtsszAofNxfJP+/aGSSxNS8b0Zu4igjDgM0C0NsQkrXUiFDoR5xfwD2riD5jFqX6Zgb wJHDct2gEw/o0lRogFEECEHOupjdLuo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="MMAb/LPY"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697184259; a=rsa-sha256; cv=none; b=zvzS1bEIzAVfYbE/FWTAfLZ3Le9LfyHokUrxNs+Qqql/EUZk4WiliJohaTpPcrj6QjxRW7 sMowvECSXHLStWl632K+TT4Q2fgJnf6Bx6uBMMps67XCubxnHfJ8FZtPdxaC+EALY3Vdjb U6xGHofJSHI7rUGd9lyyzxaXQ6o8dBQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697184258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jnw6CV1in12hPMuWpKYAfFREANvgubRLaHRIuqtezJI=; b=MMAb/LPYjNSLIkM2RDgXyaGsae9bF2uIZ9WmTojalLO8CFb6SHmcbqiP5/C094IATsmO8+ D3wqUDApM8JiM1bio/9ude+YIA3lxXrvs9IJtU0aOqgA9jnUlbAOzIBlWRSPLVPGJwc6ko ISs8PHrEKMiG4IOo6loqRJPCiqv+IZU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-gtgDIXy8NCyzN3KmJ0S63A-1; Fri, 13 Oct 2023 04:04:16 -0400 X-MC-Unique: gtgDIXy8NCyzN3KmJ0S63A-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-32d879cac50so1081644f8f.0 for ; Fri, 13 Oct 2023 01:04:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697184255; x=1697789055; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Jnw6CV1in12hPMuWpKYAfFREANvgubRLaHRIuqtezJI=; b=ZHo7ykWb02ixCW7nbjYiGucaXy+91GZ04yV9jSfq2thV65QeICJd2VlKbqM0wqKk5j b4gbBy8vMI/sgRzLTvF7R30CVbD2TJUEEz5btvdcScZ+pcnpVtHtJJen9HF/NMlBEmwA YmBuALM09S9FVUQVGlgtiqH8mZhYndQKkT2WnqUS4/tS6FMZdjWJw+AQnGDsC+Wcs+q0 q9WTfgC5SrBjOEqsnyfymzFAjrnuOwDuZXDjxfisxsNFO84TgMM4Se8r26S/nZNUzUcY 4Uy3bvAJCnZs5HLVkGQ7SJh6LLBTzyR4WpeFWIcIboMP1uy0k3Esbbnsnu6OHnKLI75P GbqQ== X-Gm-Message-State: AOJu0Yz4LFFI560wBEmgweX/3B1HGD08PNsyEcSVBf7V9ufKArmPNq+o lkkPggc4ncym4D8WGueNCSmXF8vv1kUVbqHM1ubNS/rhbimTOdarGtmuY86NM9KpyKpsbZOSkAA Cu59c+xzXH+k= X-Received: by 2002:a05:6000:68d:b0:32d:88fd:5c65 with SMTP id bo13-20020a056000068d00b0032d88fd5c65mr7476686wrb.1.1697184255427; Fri, 13 Oct 2023 01:04:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFD0RaO/ot8dyeG7Uo8SggGQU+QRrkA+qeVDmJJk2llvQffd95k8QMI2UC91Kh+CNR4GjHY2g== X-Received: by 2002:a05:6000:68d:b0:32d:88fd:5c65 with SMTP id bo13-20020a056000068d00b0032d88fd5c65mr7476648wrb.1.1697184254961; Fri, 13 Oct 2023 01:04:14 -0700 (PDT) Received: from [192.168.3.108] (p5b0c6028.dip0.t-ipconnect.de. [91.12.96.40]) by smtp.gmail.com with ESMTPSA id g7-20020adfe407000000b003232d122dbfsm20377154wrm.66.2023.10.13.01.04.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Oct 2023 01:04:14 -0700 (PDT) Message-ID: <7495754c-9267-74af-b943-9b0f86619b5d@redhat.com> Date: Fri, 13 Oct 2023 10:04:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v3 1/3] mm/rmap: support move to different root anon_vma in folio_move_anon_rmap() To: Peter Xu , Suren Baghdasaryan Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com References: <20231009064230.2952396-1-surenb@google.com> <20231009064230.2952396-2-surenb@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 15475C0025 X-Stat-Signature: dmd7fxwb6n3g83qdwc39wh6x8dsibxio X-Rspam-User: X-HE-Tag: 1697184258-169434 X-HE-Meta: U2FsdGVkX1/Yp52z47CeM0kwNTnHxAXK0q4As8MXx56QA+lUDIfoaXT37p56SOLYP4tdtkijQR90i3Pj8BBW1YBIitbY6Qijk9mtmbOfFhDbfqDkC9X+IiGKYlh2QrQisguizM24pjaHGoUebVmKun1FLzajb8ZKAwPfYiTmOw9p/8fpdaYdF3ypChH5wA8dJ6ID0kGPSMHll264rekIImy4+E3Ngtp7vCDrTVvZSK6NKV5TLaiJtAES+RIEnTEV6BD5b7zYwChq8Ec6akztjrHnWJtOM3Nnuw2FDlq8yf/IWBuy7K484oQDGKQ4Uqcf+cJV/NekcfnYhQmBU/wnA57rlLanDzpX1IVvAruZKTqXQ23d7xAhcMl+WudwF+lyVnb52zH7qad4BuC6/vvjDvtvIB2h+RFRCiTWMlPlLBqzlsc4xsoWhyEE6Rrkd6vzdh7CkzfwyqOCVZFFNUVY2ovRCkujEGDJpvyw3gJlRY7d3YtOpZ4l2byll9+4YLKNc6AAlogReUQSa+G+6CRUmFqEg5H57V3GfXPhxMD2MnJdX6v9jLryXhx9/JOZ5u8LbJZTlzRp5ET9pDyP2ULC6Sie9xg7g9AkJq7eDoZSIXXHqqXapZlDKv1cjT+VPX6FcwX5wfc88SI21/dWHZLcfzV7fbHmO7acdbRL+mhPtCuL78KCwWzlBByPwDY1MZ7c17nGHl6EHpBM52nXPgKgp2lfrRyB/c4tD45MV/hYVfY79qcV6tw1y08aEeEV6P2vfwiUv81LskQu+bPrdWbY9NvVAmkpmSijxqouXiNU0hIcCwxolNkpD2KT2dV1LoDjqIm0n6eJvxJM/dPDkVkwXF7jEygCpqIC4GlDXlqDOfwkVt+YDG+qgvuRxtD1inSawxJCGh3iuGTWMQBOkmTaHLNsOX5u9Fw9JuCR78HS+nfL86OQYBK84ozGCy2OX0w/gP7X/lxCN2HJcFU7rvS CnW/yaOP 1cFsc0D65aaO6KMwBVa89Iaipu/AtTtuUshwFZA9kC0I0lHsABDpdAh9b+xlIFZyVQfSAsrCEzm4OLuV3UMmnXANtFsJXWLFlZCOQ40PVKUJE+Zww7F6PBztaqExit/valhwVJxRiVhLQncBJK1umXmVdax54aNsol+zYo6N4kGGeUijf1+qNSGLslzQDzalV4CP6TSJlRVffr4+oL6+uUb8eJHALQDv+yrF0NL9IuzQKMQVc0KGO/4YXqUStkhdLVBQv0ag2n48PcOHa6NSlaWjPSbTGU+EpOxmPaAl7XJPZrG5liGATjcUdjqMCzZVaUFZ4cN+c0jZL3VMi/naJ7ShQ5Wazeo9DyKG6A3TNkxzNWIY7ckZY9iJOG2TXvP0ZOzVGpSzUatQDG8O+hRuTT3GpOVvApggfUdidBfQvM6RmpgWR9aex2tqe8xI+HT0aKqUzAC+dY7cePYwhITpyzsW6JhXqwkVZKjZidtCAj2E5DMNBjRFyW5QA9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.10.23 00:01, Peter Xu wrote: > On Sun, Oct 08, 2023 at 11:42:26PM -0700, Suren Baghdasaryan wrote: >> From: Andrea Arcangeli >> >> For now, folio_move_anon_rmap() was only used to move a folio to a >> different anon_vma after fork(), whereby the root anon_vma stayed >> unchanged. For that, it was sufficient to hold the folio lock when >> calling folio_move_anon_rmap(). >> >> However, we want to make use of folio_move_anon_rmap() to move folios >> between VMAs that have a different root anon_vma. As folio_referenced() >> performs an RMAP walk without holding the folio lock but only holding the >> anon_vma in read mode, holding the folio lock is insufficient. >> >> When moving to an anon_vma with a different root anon_vma, we'll have to >> hold both, the folio lock and the anon_vma lock in write mode. >> Consequently, whenever we succeeded in folio_lock_anon_vma_read() to >> read-lock the anon_vma, we have to re-check if the mapping was changed >> in the meantime. If that was the case, we have to retry. >> >> Note that folio_move_anon_rmap() must only be called if the anon page is >> exclusive to a process, and must not be called on KSM folios. >> >> This is a preparation for UFFDIO_MOVE, which will hold the folio lock, >> the anon_vma lock in write mode, and the mmap_lock in read mode. >> >> Signed-off-by: Andrea Arcangeli >> Signed-off-by: Suren Baghdasaryan >> --- >> mm/rmap.c | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/mm/rmap.c b/mm/rmap.c >> index c1f11c9dbe61..f9ddc50269d2 100644 >> --- a/mm/rmap.c >> +++ b/mm/rmap.c >> @@ -542,7 +542,9 @@ struct anon_vma *folio_lock_anon_vma_read(struct folio *folio, >> struct anon_vma *root_anon_vma; >> unsigned long anon_mapping; >> >> +retry: >> rcu_read_lock(); >> +retry_under_rcu: >> anon_mapping = (unsigned long)READ_ONCE(folio->mapping); >> if ((anon_mapping & PAGE_MAPPING_FLAGS) != PAGE_MAPPING_ANON) >> goto out; >> @@ -552,6 +554,16 @@ struct anon_vma *folio_lock_anon_vma_read(struct folio *folio, >> anon_vma = (struct anon_vma *) (anon_mapping - PAGE_MAPPING_ANON); >> root_anon_vma = READ_ONCE(anon_vma->root); >> if (down_read_trylock(&root_anon_vma->rwsem)) { >> + /* >> + * folio_move_anon_rmap() might have changed the anon_vma as we >> + * might not hold the folio lock here. >> + */ >> + if (unlikely((unsigned long)READ_ONCE(folio->mapping) != >> + anon_mapping)) { >> + up_read(&root_anon_vma->rwsem); >> + goto retry_under_rcu; > > Is adding this specific label worthwhile? How about rcu unlock and goto > retry (then it'll also be clear that we won't hold rcu read lock for > unpredictable time)? +1, sounds good to me -- Cheers, David / dhildenb