From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 456F2C54EE9 for ; Tue, 20 Sep 2022 08:15:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA6E380007; Tue, 20 Sep 2022 04:15:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D564A940007; Tue, 20 Sep 2022 04:15:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF92F80007; Tue, 20 Sep 2022 04:15:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AE8CF940007 for ; Tue, 20 Sep 2022 04:15:25 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7CFF01406A2 for ; Tue, 20 Sep 2022 08:15:25 +0000 (UTC) X-FDA: 79931754210.14.C565794 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 1A3104000B for ; Tue, 20 Sep 2022 08:15:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663661724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/e/evqGTFru+f3l3LD+eG8BtO8WljnsYCWvP+vFWoVo=; b=gJQTRcanVExgz9n6/+0BVIEZAXSTpBbwLFuPsbYoA5yQipnzhvQCuJ2131/TyP1UWvSLLx 2LnDLL802JxUHK8fRmMMn39M6XoPKCMJEwanuyS77zaMWDq+18GKBavbwisY5Q+voSUdh7 jrSJu330HMuyfNP8/SY9G9kFfNZUS04= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-438-wbOaqaowO4KnmiRLZW68-A-1; Tue, 20 Sep 2022 04:15:23 -0400 X-MC-Unique: wbOaqaowO4KnmiRLZW68-A-1 Received: by mail-wm1-f70.google.com with SMTP id b5-20020a05600c4e0500b003b499f99aceso5932295wmq.1 for ; Tue, 20 Sep 2022 01:15:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=/e/evqGTFru+f3l3LD+eG8BtO8WljnsYCWvP+vFWoVo=; b=FY/vHC9JPYI6bfvvgnf4qlgmkS/k37PXzn0+0ZjxWLmIswRO04vdqVquz0mHSz954g 0Ui4BqFgNWUGXMRvq3gzEla8b0SAEUr6Zh7coY9pYLqw33d45I6MemUo+09aV3pcqzpV d1b+Lf1TKGkQx6x763t52Ym/zafclpdXvSSLvswaT5K9UNGeRm1CKFvszhmJwhZ6O+Zm NiPMlKXFVa93m4l+5R59PKsvb82RHgypX0bdDJ7fs+XWFxZWqB013V+mytilbKreymk6 WB05Vw8J+4Y4A7KmuEY1ThjpU0k1A/U7BhRrWLNoV7RtAz9my/rC3rvOHpyZbXDp6+Jc AGlA== X-Gm-Message-State: ACrzQf3sRHjjnk3EGlruDzzFR1Sq0WXDDKXGD7G44T/x1J+Woc7C/UM2 bwmcsx+p8SWV25NH0OnQSYXc557Io5AtFL92B2sob/xFbALPREySm+/HoERqJAexrO2uGCA3UuL TROnamGd6IUY= X-Received: by 2002:a05:600c:23ca:b0:3b4:6199:8ab9 with SMTP id p10-20020a05600c23ca00b003b461998ab9mr1396452wmb.20.1663661722217; Tue, 20 Sep 2022 01:15:22 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5pb0rzdBr6watv2OP+RIFajUY8ofPhVTXwU2pExV8u2gef6cxMTASlsrhhKQd0N+G4n5cOww== X-Received: by 2002:a05:600c:23ca:b0:3b4:6199:8ab9 with SMTP id p10-20020a05600c23ca00b003b461998ab9mr1396424wmb.20.1663661721920; Tue, 20 Sep 2022 01:15:21 -0700 (PDT) Received: from ?IPV6:2003:cb:c712:2300:e82d:5a58:4fd8:c1e6? (p200300cbc7122300e82d5a584fd8c1e6.dip0.t-ipconnect.de. [2003:cb:c712:2300:e82d:5a58:4fd8:c1e6]) by smtp.gmail.com with ESMTPSA id a5-20020adfe5c5000000b00228de58ae2bsm901775wrn.12.2022.09.20.01.15.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 01:15:21 -0700 (PDT) Message-ID: <749470a3-e1c7-dc60-d7b7-4e5e3ffde8dd@redhat.com> Date: Tue, 20 Sep 2022 10:15:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 2/3] lib/notifier-error-inject: fix error when writing -errno to debugfs file To: Akinobu Mita , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-fsdevel@vger.kernel.org, corbet@lwn.net, osalvador@suse.de, shuah@kernel.org, Zhao Gongyi , Wei Yongjun , Yicong Yang , Greg Kroah-Hartman , "Rafael J. Wysocki" , Alexander Viro , akpm@linux-foundation.org References: <20220919172418.45257-1-akinobu.mita@gmail.com> <20220919172418.45257-3-akinobu.mita@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220919172418.45257-3-akinobu.mita@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663661725; a=rsa-sha256; cv=none; b=S1RRIHuqgy3g6N8zNjc7vMhTq+kJB9m9CzVN4CjDcc1pEUn1Z5zqiSRRjKBXPghj2A/zRz 2nB9QRhbCDJa77gOWxvYnohgJWQsgP9m8Zu6Ooebn4S3cxaUp+v/kVjpZ76b9kOw/CxYm0 qZr1yy96V3Z2awP6wgjxeI5GwwiSEv8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gJQTRcan; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663661725; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/e/evqGTFru+f3l3LD+eG8BtO8WljnsYCWvP+vFWoVo=; b=yuccoHIz0pQw3q2YA8QGB2rqS1HsO3tQtDfS3doEmevU9IciV2zZrzSyU9qTa226lo/peJ Gs5z3G4jxJMMR6mPc2SHo/Zw3hqkV+fEqbajCqTS13IOWjokkF6ohlbjlVCOP14IdOz6Sc vLdJUhPtpPfWEfpvEyfy30Zkq4jOc6A= Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gJQTRcan; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: nzpoi8xy3ottkpbxikpgsisty1kkqmyd X-Rspamd-Queue-Id: 1A3104000B X-HE-Tag: 1663661724-16083 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.09.22 19:24, Akinobu Mita wrote: > The simple attribute files do not accept a negative value since the > commit 488dac0c9237 ("libfs: fix error cast of negative value in > simple_attr_write()"). > > This restores the previous behaviour by using newly introduced > DEFINE_SIMPLE_ATTRIBUTE_SIGNED instead of DEFINE_SIMPLE_ATTRIBUTE. > > Fixes: 488dac0c9237 ("libfs: fix error cast of negative value in simple_attr_write()") > Reported-by: Zhao Gongyi > Signed-off-by: Akinobu Mita > --- > lib/notifier-error-inject.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/notifier-error-inject.c b/lib/notifier-error-inject.c > index 21016b32d313..2b24ea6c9497 100644 > --- a/lib/notifier-error-inject.c > +++ b/lib/notifier-error-inject.c > @@ -15,7 +15,7 @@ static int debugfs_errno_get(void *data, u64 *val) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(fops_errno, debugfs_errno_get, debugfs_errno_set, > +DEFINE_SIMPLE_ATTRIBUTE_SIGNED(fops_errno, debugfs_errno_get, debugfs_errno_set, > "%lld\n"); > > static struct dentry *debugfs_create_errno(const char *name, umode_t mode, Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb