From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F9C7E77188 for ; Tue, 14 Jan 2025 16:05:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79BB36B007B; Tue, 14 Jan 2025 11:05:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 74BE36B0083; Tue, 14 Jan 2025 11:05:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C4C66B0085; Tue, 14 Jan 2025 11:05:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3ED926B007B for ; Tue, 14 Jan 2025 11:05:53 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D14E54470F for ; Tue, 14 Jan 2025 16:05:52 +0000 (UTC) X-FDA: 83006533344.14.FDC1CEF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 35D97120021 for ; Tue, 14 Jan 2025 16:05:50 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PteL88LU; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736870750; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VMkCYOsyvm47TSe6Vd45OKr+yexY9Ah5sYc4Xs9in04=; b=bbVn7lin56sMfhGrArlXIDothmlCXW0k5OGirGDUgz0hzc1NB3uZC2Dgk4ebn8co+1RU5S 2AWRmaYklih1N3mlElGr9oaEX1qr6lFD0aT08b+nPYLF/kKgHtUbMmPV4H7kwntJHbxfJK VwfwUVaGYcIZ8UICz0Tx2/miaWshHf0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PteL88LU; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736870750; a=rsa-sha256; cv=none; b=0BnypTkna3bIRCqgh4PkJXhfJVx01Eetu46nC0okaskSjxLgC/rgUj1zm9i6HEGWO+x0mf fGJra273gtj8G1OGYUKz3JoVznMDHKf/53xu+a3CpNGoLaNSIALlYDSrQyrBkfwyfbsytE +AUS/M2PJWLfgNEoySfc8QVitYDIvBE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736870749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VMkCYOsyvm47TSe6Vd45OKr+yexY9Ah5sYc4Xs9in04=; b=PteL88LUMWpSjWEjrOc24jCsRrZlk8BNdV0ex2uUxnFXwwjtRMSc1Y67zLdueoa9yqXdG8 zhF6H53F6HyPTOsIkPkHWfw7XvfWzxm3FH9Wui8I+4t8Wwg0ub36sUz1YVctGmeKoZfJNj L3xiFsYOep9WlCacB+eRdJ/yxGHXxJA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-hoEzxp7MMV2Ek8l1WayLjg-1; Tue, 14 Jan 2025 11:05:48 -0500 X-MC-Unique: hoEzxp7MMV2Ek8l1WayLjg-1 X-Mimecast-MFC-AGG-ID: hoEzxp7MMV2Ek8l1WayLjg Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38a873178f2so2849066f8f.1 for ; Tue, 14 Jan 2025 08:05:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736870747; x=1737475547; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VMkCYOsyvm47TSe6Vd45OKr+yexY9Ah5sYc4Xs9in04=; b=Bo8yDYlEkzwjtYh1zBfWpUeazWwteAGJxzcShbKu/FdagWL05i82sp6LMGGgv6RtQK aema1YpVUxtJi7FZ+FPtO6bl1WlTqEJ6iS+s9AVZmomnELWKZUuGV3op9qi8Vrp77L9l S0DMdNjD7ERsvM5v7O4VQ3ZjZX1uJGxHCWcAv23DaI+kp37maB8BQVALwqYktx0YqkKb m2zKhPb8MvyDxnM/vcOeiYLQ62ASESawb9R3fLrTrrCGZercxpeXbbCUuFtBLq1g3KJj KYjKWN2bbHF0nOpQY686rrv8by2CVBqNx24yTAkGW2NrAPyps3cuKS6Nhq4JVblHxvtV hMUw== X-Gm-Message-State: AOJu0YwuRxcocewvUaC5ZNrDNlq4dovv1pkd2iO+FVnUtR6CUGSB9a36 0zRaabQPuh0GbUHecLC75aOQFr5Bdqco90a7LO+RGVNiNqx+XHkX56n2zakcXfjsndNjYn/Y/8h tOicYl7b70n74cTJ1YjKTAFY1jNpSXXt6u2hKmgPBKIgU12BP X-Gm-Gg: ASbGncv9pI9TRONU3fjNhLiu5mIGa8dQP8Fq9+45A6H1UOgJKVNXbIq59mUgegLmoTG jJC/yz65cxkZ42vVvIzBH7Oi5pDjErD0wDJSm14E6yU3b6Kw5pP551LkN51qsSWoPjoXgOxO0Ws ivqfdWdZwxJaoflWWcFAt5ZumtI4VFV5rxKrBUOYAAc6Ofd/VYoK/k6waILhmZMFZvu0RLNYoXr nZFJ3EkmjCoo+smuMLMV1tWWB66UzBFz7QBBtzdoMrtiEFo5e/sH+aMd/ahullojqj5B6hg2XMb OoHzt1izkOAXHnJSMjLsoPQxUfVx62FuJekp+cxEec1PyBdj2XxOyhLtvHwCaeNymRyca3aoibA xHw3PwWta X-Received: by 2002:a05:6000:1a8c:b0:385:f677:8594 with SMTP id ffacd0b85a97d-38a87336b29mr23628226f8f.43.1736870746818; Tue, 14 Jan 2025 08:05:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IGs9YS2msqw5L28+0H4IC2QOw/GUIfGbzadBCdsTOQu3IaDPwgnpqFU9VHHEOsiFIcxgS2ITA== X-Received: by 2002:a05:6000:1a8c:b0:385:f677:8594 with SMTP id ffacd0b85a97d-38a87336b29mr23628041f8f.43.1736870744788; Tue, 14 Jan 2025 08:05:44 -0800 (PST) Received: from ?IPV6:2003:cb:c738:3100:8133:26cf:7877:94aa? (p200300cbc7383100813326cf787794aa.dip0.t-ipconnect.de. [2003:cb:c738:3100:8133:26cf:7877:94aa]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e37d090sm15089833f8f.2.2025.01.14.08.05.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 08:05:44 -0800 (PST) Message-ID: <7493daa0-b15c-43e8-9235-78a0a1a8c8a6@redhat.com> Date: Tue, 14 Jan 2025 17:05:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/fake-numa: allow later numa node hotplug To: Bruno Faccini , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, akpm@linux-foundation.org, rppt@kernel.org, ziy@nvidia.com, jhubbard@nvidia.com, mrusiniak@nvidia.com, "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org References: <20250106120659.359610-1-bfaccini@nvidia.com> <20250106120659.359610-2-bfaccini@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250106120659.359610-2-bfaccini@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 40_qAa3pAyRyB1Xh8Yuq0R4eTeeU5GG9PB98pgU75g4_1736870747 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 35D97120021 X-Rspam-User: X-Stat-Signature: y9xohfdbaoz5zh3ozupwqizhyxgfpa9t X-HE-Tag: 1736870750-607318 X-HE-Meta: U2FsdGVkX1+XDkN9OTpruiYApuEsEiVji4pSaJzhVpOb1ncgOgXZrfL7uMvivQpgWYWHESXXDGiwEeMmpT+8QKZZPHBuC0tXiZSnTCtcLn5DQdMofKwybHWQlS8XzaIg07QmFxefMB3isCCNx4V6rfUVJ5PDK5HNh8VcUv399sPL15SyIGdWp2jKdeJl9WiBrorJRlGSMVyGvI103R19GPnGoOLacbjbTL9whCWOye2LLLXi0fgXfjeTiQ/GrFbqa0EGoQMw44pbmbkmzO0ZLeKa/QgoiRUT5rCFii39g/8qWfRm+Y8sQ192xH10M4A6bz76jHrNZqVF4v8WXHly/eCr75RovWft1bmX7dv2ubHQ3XYUUGQsRSa+N7DoKAxQlNQXJ0u0n0TQ1gCbD2oumpBs9FRYX9j9aKDWj3Mz6rBITbMCkk19tNve8/aVxIB6hRYYTld39qvqaqc4zo3y4dAE4q8i1p1rNVYceIPUvGUbSKyN67yd4Ifn7ohRMfHvI++B2ugBtGsi57tXgo/HNtG9g7vpt1+yFofJkW81Wv00bAdQGa2ABaJvqNcA8mqAhlRHf0glQYO6IaGGV0HVyOezbFGW3el/yGkwyh7VWyNJISlVSTOolncI5okIsNYyZaxzNT4+oAxSZY3IL7fFXX9uQrhd/hiD7o+L9CFve/auUn1PkNqzbdGwXcFmkEnOIctTX/zHOKWElr8POLwce6/sxL8ghWCK2P1ixaCDRhifqnog0FdvIlUbs96ncAXojMcwGSLu9dIJqXnmQK6k/QbMqvhu4q2p7YQnIWbScwCPUOB29tA1J/m+KSJtaRYABTULyPDZtG+RghGY9ItaHi2gU/42v8oSz9GC7kISPuxxMMOc6eowevGRzT9dTFQvZWbedfKlLZTf9AgE55jhN8sZbk9oT9fhc7Zl1VvWXKVVJIDZEdDG7rSarvdQ449vK8i7XxcQExh3BYRUf2x Ks5dLZsQ R7dJRrNWr+c4S8EJyBhZ9HmBE7WcYkVhlievKQwurd8HDM6XuKE51TYti2rrD37CF0kUPYsPhgSr28ZHqKAWenvzM3OEbTC6y9GH/aUXk+sqEAQ/neD9WF9iTP+dcTklk09ZXdtYgIfFVPVQ1d22DPMwfSEmXlh2wIYUyFdWjp1u2yCbdBNgsKMWEN2lwwv4PeJ7tpv0LtrhkSW1mziGxTFuNLJArYlVrwYUqZHtxo5NMcY4XnqMYjJGIQIXSzqFvewIZwAsrAxBrmWSsaZ9rzDMCHQpAeHrNL5YboQXWoiHovIwjPx4VbEWUcgIoaIKFjoqTsE23PYtS81ywS5ExwFXVtKk8C9+wre3nIvQ2q3qczGE4UJ8wJ2AEFtCez11HK6L1Y3Esxlj7x+W4qIE0L6McCjf8UOPs1f9k X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.01.25 13:06, Bruno Faccini wrote: > Current fake-numa implementation prevents new Numa > nodes to be later hot-plugged by drivers. > A common symptom of this limitation is the > "node was absent from the node_possible_map" > message by associated warning in mm/memory_hotplug.c: > add_memory_resource(). > This comes from the lack of remapping in both > pxm_to_node_map[] and node_to_pxm_map[] tables > to take fake-numa nodes into account and thus > triggers collisions with original and physical nodes > only-mapping that had been determined from BIOS tables. > This patch fixes this by doing the necessary node-ids > translation in both pxm_to_node_map[]/node_to_pxm_map[] > tables. > node_distance[] table has also been fixed accordingly. You're allowed to use up to 72 chars per line, and adding some empty lines might make this easier to read. Did you forget to CC ACPI folks + mailing list? > > Signed-off-by: Bruno Faccini > --- > drivers/acpi/numa/srat.c | 86 ++++++++++++++++++++++++++++++++++++ > include/acpi/acpi_numa.h | 5 +++ > include/linux/numa_memblks.h | 3 ++ > mm/numa_emulation.c | 45 ++++++++++++++++--- > mm/numa_memblks.c | 2 +- > 5 files changed, 133 insertions(+), 8 deletions(-) > > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > index bec0dcd1f9c3..59fffe34c9d0 100644 > --- a/drivers/acpi/numa/srat.c > +++ b/drivers/acpi/numa/srat.c > @@ -81,6 +81,92 @@ int acpi_map_pxm_to_node(int pxm) > } > EXPORT_SYMBOL(acpi_map_pxm_to_node); > > +#ifdef CONFIG_NUMA_EMU > +/* > + * Take max_nid - 1 fake-numa nodes into account in both > + * pxm_to_node_map()/node_to_pxm_map[] tables. > + */ Having the fake-numa stuff in here looks quite hacky; but I'm no expert, so I'll let ACPI folks comment (on CC) on the details. -- Cheers, David / dhildenb