From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C093C4345F for ; Sat, 13 Apr 2024 20:19:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C59796B008A; Sat, 13 Apr 2024 16:19:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C09116B008C; Sat, 13 Apr 2024 16:19:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD0E96B0092; Sat, 13 Apr 2024 16:19:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8AF526B008A for ; Sat, 13 Apr 2024 16:19:24 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 268EE14015C for ; Sat, 13 Apr 2024 20:19:24 +0000 (UTC) X-FDA: 82005623448.01.970231B Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2047.outbound.protection.outlook.com [40.107.236.47]) by imf27.hostedemail.com (Postfix) with ESMTP id 233DC40005 for ; Sat, 13 Apr 2024 20:19:20 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=S1gt+E5s; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf27.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.236.47 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713039561; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+3zxVzi717mniQ/Q0oMNOWrjnz0YowOHXKweMRWRf2A=; b=ZrXJ8wbh+xWPexlLUZ2d9Yu246UH0de4+XdEj5N4+KunRLnDZ4AliMG+hUouXYA7lOiVF0 TlR9tz6tnSHFvqsCtwUp5Nxi2sTw3aTHMeS/uYXRcgiYs/yV+PRlWhQ6Xb+7GfsiuaSylM IL6qNzxUDcebKBx5HKue56Fzl7YqD/k= ARC-Authentication-Results: i=2; imf27.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=S1gt+E5s; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf27.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.236.47 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1713039561; a=rsa-sha256; cv=pass; b=QYdKWPcsH1KG5HBPkPfhdEHgN4mkea7bmoKd0G+KjrVVY6Hw16E5Vcgg4evp5bk7PggtH4 W0R/X7iL+wgKlQSY1kZNsKGXymFReTTI20JBHRDB+jw3nQEzYkwgH4E4H7JUdXLl3s6qmz TVb9S/ZGMiMVATWh6zrxGAz4QKyQmL0= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WjyOuacicaImabQUJAX/6YEdWgNtGFMjIhlrq1Qi9Sn/j/S8b0vn9dVdNH7K4XdKSXZvLR4DNVzZm48HcT9wQ+UgRroak27aiPHncMiSCLR7R5hQXTTqIPsKur/qaeDBQQhx9KwvhigXUQP6CYdQUHDhjrMCUjED08X5p5biUaZHHeZCzlYtawCsVBX18Z02WTVddV1tbFU3MkTxgX8L2PTEB5WpltCQ+tO8SqR8PMayI+1I/+JYxm/gffWbSaLUhGW44/6ZmE1wqKg1nF2+Fzqv2+haT1b16epUQahuT60GRV7cfqCNz6N6OBESkAbR7rC+YfmgcFaDapeyo4ZYUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+3zxVzi717mniQ/Q0oMNOWrjnz0YowOHXKweMRWRf2A=; b=QvoZUTmxTTkQ7dSKKgSTBsedeACNxSFGVH8g1cCGlwQPvyBkb7k33lqYC/Cw5cv3T0lC2070Q0D9GKGCbx8ibEdKUl3qAVMkL8Y24HrhPh5UpnnJRcqDCiJqQYITkLLGNZ1zpNb0mmyrpKATCgFAisbcq18EsPJoSk8bTXHwLtUHvlQQR5dil+cQBsl6ETzGiDbT1FLFxLgNkcS0Bw9z9Oj3GGCk1vxPEvNCchX+uZ5V8RkR1AnMVIQftibJCRX1QbUunslaunWu5SIIO9PMSatvLskPeKsGQHuUqMnQadyh0uioH3Nis/lCnni6g0j9/RFdLP+MLcHJ8XSciPcGhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+3zxVzi717mniQ/Q0oMNOWrjnz0YowOHXKweMRWRf2A=; b=S1gt+E5sjQ0n/mnP9KindQdJwUd4B/5ET3sFiwYbc2pd1o7VGfYubayqC3Wjp/JNLceLKM0yBPwWXxO4+HoRQLG5Ge+zMgXxskzYL1CTHBMf6o+xLZ7R+/T8/trchy1KC45UfZqwMtHMbgKzF/pE2ldUducqhWXnwDhC02XlwG9ah734Adx2nTr8wNMgAQOEbsEKHS+O5yOYpDc7J5eGJy6/MJEJ1KCnlAN7Ob3c4PkGi3V0LORrHtrCAWGirKulT9k2qN7IQvG1tBTmY/muhtSWCakWoGABH8hBXLuYbTjnbvzFhcNJvOskWnigwdWC0lygNeXVHWh0mDW4zqmS1Q== Received: from CH5PR02CA0011.namprd02.prod.outlook.com (2603:10b6:610:1ed::28) by MW4PR12MB5601.namprd12.prod.outlook.com (2603:10b6:303:168::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Sat, 13 Apr 2024 20:19:15 +0000 Received: from CH2PEPF0000013E.namprd02.prod.outlook.com (2603:10b6:610:1ed:cafe::a5) by CH5PR02CA0011.outlook.office365.com (2603:10b6:610:1ed::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.31 via Frontend Transport; Sat, 13 Apr 2024 20:19:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CH2PEPF0000013E.mail.protection.outlook.com (10.167.244.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Sat, 13 Apr 2024 20:19:13 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 13 Apr 2024 13:19:08 -0700 Received: from [10.110.48.28] (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 13 Apr 2024 13:19:08 -0700 Message-ID: <748fb175-3c5b-4571-9278-1580747a746a@nvidia.com> Date: Sat, 13 Apr 2024 13:19:07 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 05/10] fs/dax: Refactor wait for dax idle page To: Alistair Popple , CC: , , , , , , , , , , , , , , References: Content-Language: en-US From: John Hubbard In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000013E:EE_|MW4PR12MB5601:EE_ X-MS-Office365-Filtering-Correlation-Id: df4664b5-8e54-4f1c-aaec-08dc5bf6fc45 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JCG8VNVq3BgIUuqErCw/53Eji52ytM24/Md0+CfvPjXUK7QVKMMhdL9wKkim3ucARZ8HwtviCb08624wWXf+G3EHdbzRcbCM8qi0gjD+jjf1ODv+KQNf/Otmgs7gr8EAQKViendJkpC3v/OzQS8UahdoR1jBWz3Rjs8uXFlspusuKr9Vr5/qMuS3qDElfbjenWzCYpYD7Kzn0sKgXvN00WJ9eF7i/ncIVebuP7eVDRcsInpoEqYJvKHp4zzIFIkcIPyUDRXQq6JYdfgW0VWxCBDv6x/Vxv4LIzc8cTsJhY7hSyvheuBIRzOrOBWlTKKuYPlLfbUf+hpUEguEa1ZF9j+FJWy4C6XjFQwPN1CeCtHvZXVQ6p78poVfPmJbBv3xonqTMDn+m8uCWjE4cdosRG2b5vKJJ2n1VUVyoALamx09vAKBVdbpqXlHM4RzSMP8fe1/bqy1IWFnvE77CxgrcdxR1Kpsd1SpanDWCulEgDMekf8TzFH8NakR8e/TKs4jELzeqcB+HPP7MFqS5QhX/S8QeX2/M5wOyn6xL9ui4uLlcEONAD3bkG0APt5eV1hFY45KAoE+h2iVv4mwIj0C7AiaBpIqHk+OCyhCW66NSZYlKGCP6VrCo4yE+qCQvBkAq4Tc+Fq8qpcwkdMQhHqvAc2eg1yOeIET3o5VvzIa6ouQyoi8sdCOEokN3xxmjpuXYj349NnMpnwyZWQsmY+CVfEy0uNezdtiF+PKOUGA4ACJ19wCudIvoHd5Qf0fScQW X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230031)(1800799015)(7416005)(376005)(82310400014)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2024 20:19:13.0711 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: df4664b5-8e54-4f1c-aaec-08dc5bf6fc45 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000013E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5601 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 233DC40005 X-Stat-Signature: o5o77h8zyufu1fm9rnodbw3nsi7xuty5 X-HE-Tag: 1713039560-794673 X-HE-Meta: U2FsdGVkX1+oTXLVSCL8pjmp7PDuGrUWGi1ODcIqcsw+44PADx4Znqi5X5ctmI6Q7nH7wmJOhhnBCrPndB/oUp2e2oird3IomIpLekQVcbNclDEfJk+2h2D9iU8TK9bbxQchRJcPACnhQkM8rdkrL+MHCtBlhrx4HmESEitt8ke0dL3u1Yfpz2FEpUdOVcPQN10SG2EBI6rJfi8mnn3UlIeIpwA9FlAT5IXDX3+HSgxwZHWAwf4knQlBHy2Uyyf9Y6Lb39Td2zzwvW6odd6h3eY15BTtzwnCftFUEaFDm5THMJEpPY3e93/+Q6IxEeVnDwSOnlJP/4psYyQkbgEb3ekMMVub6vooN0RL57mKwfV4iBCOvHVHw/ITIS6CAZqOtTHzD7krGz5cKUaNlTUooglUyRO4bLjzma5lavzcs9mNJTU1CAG1tp7QchbJAXNMHqCHlF3MLOtWHBfnv451Bc6VPYdbbyj8Opt2qycom/5awrq7fUnFjQbd/VrVhPPczOr361cyKvA0SqWBTBYyzrR4afGxUfY6Qub6pWgtD/1uBr2HuEw/coyWzWcxIH4zrL8dOQWU7pvazrmQP2uI4Ss8SYXZu4rMUgbomb3b6DrqKrKM9shEE+vJdKOKULpORFPZPkzyAqEYc6raASdDGzyvJLqYqN4spynkaY/Pj5f9FX7hlSDuTXTwLDHYe01DLMEX5+KuYUvjBEwax7Y1w4xjCPxjDou8Uh0TvI0KyTZzEK4Cx+kh4b1hQ14VmGq0CvIlZ2grf5XB7gDu2Rw1l5ZRQ/K4GK7uR8xumI9T73z0Y4GdOi+eyseo8UdpLdbZ8lvpl/e6A9OGfFa5/7+967Do7fHM01LuwvG+vc/vhwhThI7D+1P/Mzv4M9YowhujcZacx3ikLjKuziT3Cq/y41qb50T1rtBKrBwglkCVL5Ct985x/PVLEwRMsyVdgAY8VjP5MuoRuaZLN98gJpd RxMoh3Py O+E2ZVnZ/PlryDe+w44rZL4BORUm00c4Vwo9HDcuPjZX/eBqvZdhkqJLADupCTuIum6WYd9wyN6tRmhPe/EOWUkVjIEkSdXIfsY8M32orv0P9p3mpaGdrHv5yXLxGKiA9++1HKcdHNRpSBjVooQsoOdhIWGByg8ulVsNonrE1i/RhUNj1w4qyDGykpzrq0FATCgEZvX85iw4MHgZemeBgEqQI7a+Ms47VT4heGN0qAzz/naSAJIcSsl8Un9LvZn7o0LIad9tvn1XKS6Wde8IsHWlkmD3cv7RNbAmGU1lQ/IqEcGtBa6kLjgy5ZGQ2z0d4vEDBDLwUECY1oiHppUWHiEzpOUmELMdRxUefhCoEHAjTJME/G9Al6JOGes8jZW2pwrks X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/10/24 5:57 PM, Alistair Popple wrote: ... > diff --git a/include/linux/dax.h b/include/linux/dax.h > index 22cd990..bced4d4 100644 > --- a/include/linux/dax.h > +++ b/include/linux/dax.h > @@ -212,6 +212,17 @@ int dax_zero_range(struct inode *inode, loff_t pos, loff_t len, bool *did_zero, > int dax_truncate_page(struct inode *inode, loff_t pos, bool *did_zero, > const struct iomap_ops *ops); > > +static inline int dax_wait_page_idle(struct page *page, > + void (cb)(struct inode *), > + struct inode *inode) > +{ > + int ret; > + > + ret = ___wait_var_event(page, page_ref_count(page) == 1, > + TASK_INTERRUPTIBLE, 0, 0, cb(inode)); > + return ret; > +} Or just: { return ___wait_var_event(page, page_ref_count(page) == 1, TASK_INTERRUPTIBLE, 0, 0, cb(inode)); } ...yes? thanks, -- John Hubbard NVIDIA