From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43375C30658 for ; Fri, 28 Jun 2024 16:53:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADEEB6B0092; Fri, 28 Jun 2024 12:53:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A66F16B0095; Fri, 28 Jun 2024 12:53:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 892A06B0096; Fri, 28 Jun 2024 12:53:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 690646B0092 for ; Fri, 28 Jun 2024 12:53:31 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D5640A0D22 for ; Fri, 28 Jun 2024 16:53:30 +0000 (UTC) X-FDA: 82280893380.14.82A03EB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id 3D5D040013 for ; Fri, 28 Jun 2024 16:53:28 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="RMTcMcU/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=MqBjY2pg; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tvk8eI+W; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9o3ldglN; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719593600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sWSxPxOgOkG/YqMVteDJQQMXPZ+/l92epaen+YwQmB8=; b=KQhjx3sAPR9dS8vunERpbDj17svzcSOwXGt1TuLA5l/O2XdvENOAyx9zxvmiho3oDab318 kp81xk+JLiLM6Q0loOXTb3k5gVKirLV47gu4WgXhzTi47TRLQ4cOeZhYqECKsuNoxx61a5 c1c9hLUeQ4l54xPeDvvFHmOWKxAxzrg= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="RMTcMcU/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=MqBjY2pg; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tvk8eI+W; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9o3ldglN; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719593600; a=rsa-sha256; cv=none; b=xx39FZiyhi8ATLz4WT9PPysl9noR1OcxoFddSNKMTMZVgZY0uaYTGR95n15+12sVRVGFKE /9YSfpQXMy0vMcHgOX//tjOHIQWSzvj3eBfvmE1/NRYVceapv/ypvWNwo9uChzf5Qa9TSe jDod5KJuoMutwDF6Z9Fkdvi7zvzup9o= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DEE642197E; Fri, 28 Jun 2024 16:53:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1719593606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sWSxPxOgOkG/YqMVteDJQQMXPZ+/l92epaen+YwQmB8=; b=RMTcMcU/PLrk/vIgPd1Qc7vhIwZz6/HLJosq+P5O05bzWDo37Yb1AFNk1Iq3XKqRpIghIF NdwC8dgBVP34LsMJRj3Nd3GUiEIIIF0GvDWq7Cm7Uuz/qjoyWwfjhuKPC+6hy8f1HvXWlN +J42joYYCk2vuPBVxW2QGSWTgBI0fm4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1719593606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sWSxPxOgOkG/YqMVteDJQQMXPZ+/l92epaen+YwQmB8=; b=MqBjY2pgtSEZgmoG2dXNO+cBq/TnFrjf5ABWKgDwCP5COxs0QHe8GLPdVLT4PTrzoOXpCh rDdp6SJ30v7lPuCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1719593604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sWSxPxOgOkG/YqMVteDJQQMXPZ+/l92epaen+YwQmB8=; b=tvk8eI+WQtj3vetE1Dx92fZlnCt6rglJXzihC6j6tarVqysXgO+5EMekN9XmfYl4k9pB3f YKFYNyXb2jIfrCQIxtwVUruymi718ehk1HZqAEYqmNP7O57RE578YAlFEUOqI/CGQF+xi4 HbYvrDsD1Akjv7WfEJPtzkTuOvpq1gA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1719593604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sWSxPxOgOkG/YqMVteDJQQMXPZ+/l92epaen+YwQmB8=; b=9o3ldglNufRXQDwj1Qna2fjIh7VZIMueMg14b2jaMI/sG8Y3HY1X+zlLceVfLY8d4seQ8O 1lWG37U5jgTVUVBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B0FED1373E; Fri, 28 Jun 2024 16:53:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id mblUKoTqfmYhPQAAD6G6ig (envelope-from ); Fri, 28 Jun 2024 16:53:24 +0000 Message-ID: <74899318-1462-4c7e-b17c-28f472325755@suse.cz> Date: Fri, 28 Jun 2024 18:53:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 4/6] mm/slab: Introduce kmem_buckets_create() and family Content-Language: en-US To: Kees Cook , Boqun Feng Cc: "GONG, Ruiqi" , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , jvoisin , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Xiu Jianfeng , Suren Baghdasaryan , Kent Overstreet , Jann Horn , Matteo Rizzo , Thomas Graf , Herbert Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org References: <20240619192131.do.115-kees@kernel.org> <20240619193357.1333772-4-kees@kernel.org> <202406201147.8152CECFF@keescook> <1917c5a5-62af-4017-8cd0-80446d9f35d3@suse.cz> <202406280846.205B57F@keescook> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <202406280846.205B57F@keescook> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3D5D040013 X-Stat-Signature: xmw1ny9zxqjd779j4qxeuoah7hzyij5a X-HE-Tag: 1719593608-450177 X-HE-Meta: U2FsdGVkX1/p5zFHVlBif6j4vdasgWdQOXq+FS6ZnDaAkwcbhW5b9ZI9B5UXGKMdaMSA+H6AwzrAmpLBdTORJwpC1ThxsB+5UKhkTIDc88SWgG6pJ3kR1FuHlyUIhd51e+uQaY3iBoWY8+vgw8ILep5DzLhoKtg60dggqdqac9qOBJRBYG+BKr8x4qFcE6O+awK2lRKqybtLzvat5GGLu9/92DvSfy+9ecSo4SvfhqR5dwQykeVjdihrUE8D2DiOFrwyeaJizefaabQRTZ7C6NheMTQH8ZG+FGrHepUakoXBLvRfnXFDo4rm3U2o2Hjmi04IBtc+5TKfC8P1eqaXcTBxng7oaFeEHTE4Ldv7LlB5vlJiNOKD0V0EiJAhAZSO5nf5knCYdg/ypvLTR/2RzmDUAWxqGHBeXYyfaSdvgxn2g1v20IlEhzYHSqjeqVXPvHnbM/BoyHyXjy8jXj4K8eV3GElM5Gx5Vj+2N0S5RsCAA4bK4oc9O7UUUbStUeKVlSvNjU5sA76T6Zbf74CpKoGquA0JJP/9kSGG6mMIa/j2EVpYCaspjy69yDLkLBj4CxeWEOLy/eAuwSm+kH5Fh2IXa4RyIOI9id3oCMIBjxZUBMgxKcLLQbQElSVB6LbhoPR3TnTOWAZTcaMAye/Adkv96rdrjM8ZGOpA29jfGyDh4Evgups4dx9CiueBGClao1Viqie1j5jPjPuhzIMxkHX3NSqno8QXe+pQz23VLL2sxQen+Kdz1sAAXfVpFgRQjMn61hn5GgowlOh0h7n40s0UzLjxePWmSVAwtLJ/40qEKJXiKFUSfbbVdNRKVLfvZj2/SSCWZBhV9L5whVxMrxojweTqjWNX8ZodE/ZzjcDxDPLkbf2n3vzoirZ9GHANYGn0agtr8se/yo5q+yvFLZi2Q2nqlcMPhwpxCooAxZcHxdIa5vUf4ujeS2MZydMfITWvouK5fVtq2C8nvfY RJplnc45 0unVFYrQ+05Fr7agd0SLvYv3o4MJrpTBDo7jIE9gXV5T8BwtGhQ9nfNqUurSaLkKQdxaRpxZcLq48EaAlrVTGufsBPqWWqKpF0Ju8Glx5sazHSA83G+nk2fQs7uW+B89mgUqCWKz6uTRNvr8J1gnniGSp/NLeDScDNEkfRVJV31So9PKrc+bshGIgUGcyoCiPZcjqdHB7lTpLQQlqkSXQ6gzLo6k4vw3100CBVizn4MOH3sPWH/gUYj88vuicMfECmQc2YiqGNQkya2mcsnf8qr/WsJpzqXRiy3U2LbmWzt7WmYO0YqNuMo3+1djutCBrzWkKA6koRBQwJOdpXMcq8DGS5dP315cYVems6D+LljfYQZUFEIgb8J6w/9ZY747169CC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/28/24 5:47 PM, Kees Cook wrote: > On Thu, Jun 27, 2024 at 10:35:36PM -0700, Boqun Feng wrote: >> On Thu, Jun 20, 2024 at 10:43:39PM +0200, Vlastimil Babka wrote: >> > Rust people were asking about kmalloc alignment (but I forgot the details) >> >> It was me! The ask is whether we can specify the alignment for the >> allocation API, for example, requesting a size=96 and align=32 memory, >> or the allocation API could do a "best alignment", for example, >> allocating a size=96 will give a align=32 memory. As far as I >> understand, kmalloc() doesn't support this. > > I can drop the "align" argument. Do we want to hard-code a > per-cache-size alignment for the caches in a kmem_buckets collection? I think you can drop it as a single value is really ill suited for a collection of different sizes. As for Rust's requirements we could consider whether to add a special flag if they use own bucket, or just implement the rules for non-power-of-two size globally. It should be feasible as I think in the non-debug caches it shouldn't in fact change the existing layout, which is the same situation as when we codified the power-of-two caches alignment as guaranteed.