From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 586B0C46CD2 for ; Tue, 2 Jan 2024 16:11:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA9A56B02A5; Tue, 2 Jan 2024 11:11:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C59646B02A6; Tue, 2 Jan 2024 11:11:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFA986B02A7; Tue, 2 Jan 2024 11:11:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A038F6B02A5 for ; Tue, 2 Jan 2024 11:11:30 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6114C80751 for ; Tue, 2 Jan 2024 16:11:30 +0000 (UTC) X-FDA: 81634861140.23.7B44E8C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 16DF4C002F for ; Tue, 2 Jan 2024 16:11:27 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JMALASVr; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704211888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/Dqnlp0QuZa9c+QM3922FAqvaJxM3B30ScQX+9ovCQE=; b=vY3PGj3rfiTsuhXk3iMOKuOD4eOTZ09jn6uDoKh9ZknEry1izMuttswx4Uq44lHiwPUCGa cN+Ef7EoUk11vbdNPohgQswrgd+4LvTPt5FnwPxl6QjUmjMZFacO/Idatcy8KonJaoPwHA CF9AVki7sXKYmi3csC7GvNUegr7+HUU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JMALASVr; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704211888; a=rsa-sha256; cv=none; b=VnahxSqmqVevsIxg6j0k6LOGftR4TzsH+CC7VES1ZfaoOHdWZpheCqg+rF59sUHdjhXoKh NEH6EZpxLJZ2CBCbF0lIzw53h8PrLgcxfjCe2/VsNKSBIzMEMAQ7jL9C3WVpfbsDWAEM67 kdb5aZGv2sVjcNvDPbz+hc79o3ZxcTE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704211887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/Dqnlp0QuZa9c+QM3922FAqvaJxM3B30ScQX+9ovCQE=; b=JMALASVrNjrEpg1pWphLR3raEInTNZ2AoorN6GUz6F8NjnYvK/uTZd6xziFUmcLjTqB6T4 RaGN/xnG5Dfh20bNnylIpYIUu+LcWan8LFz94WHAckh8k1+Z51pI3oqgOTKkpLNIgxGLlw t02ZRsxXqX2fBGccveS2LX1wwde7fF8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-SGVhX22YPcWm-iBcMdCQzA-1; Tue, 02 Jan 2024 11:11:25 -0500 X-MC-Unique: SGVhX22YPcWm-iBcMdCQzA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40d1ffbc3b8so86583715e9.0 for ; Tue, 02 Jan 2024 08:11:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704211885; x=1704816685; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/Dqnlp0QuZa9c+QM3922FAqvaJxM3B30ScQX+9ovCQE=; b=GG/futrh+CImNlGbexap8rcCcny/mLUMMSXG3xk+2H7u24AynTJcxWu0tcU2/anBbk +qREuVpmc0c+8D8fVfP7Zqc2PMRcvFPq4O8HmX8sWllztrt4Yu1I9BY7uvf0gAo2DQw5 nsPN1hMTDin38xw2SuZLB9hAe0ilUKBL3NvxhzQ/8nt5w3xm49Wd4csk4PsYHb2D53qo edSQ1ey3s97r3Ayty4hl284F1p2PxVtl7GYmPXVTUdDYoZkfhvaCqmHwhY7TP2MAnDKX SRedZ3ZQwjoWPz9TGuPHGqP2GXp/dZi45FlcB7iwY2LNkVAiXdnU5bGWbosJbtwFytni QMdw== X-Gm-Message-State: AOJu0YxtwhYMU8dqhQJhQXVn+OzIEHXn1iJfrZ5Hv16tIUTc9P/XlxBE japBg1b5Ht35jS9iR3auyPl5+AxG+SjtWc/Ito5CE9dh9Zb+pzi44w6VGPs737lX9i/tKmFmHGl C1wxPLaXoTp8KO3ZZVbI= X-Received: by 2002:a05:600c:6a92:b0:40d:5c4b:fd9 with SMTP id jl18-20020a05600c6a9200b0040d5c4b0fd9mr2606433wmb.0.1704211884797; Tue, 02 Jan 2024 08:11:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IGe/SVJzs1eijpSEX7Ilks8orartCeLSPDNzo+XhzaExSXfALyJDRK2norhs9hbv2iBKtkT/g== X-Received: by 2002:a05:600c:6a92:b0:40d:5c4b:fd9 with SMTP id jl18-20020a05600c6a9200b0040d5c4b0fd9mr2606431wmb.0.1704211884424; Tue, 02 Jan 2024 08:11:24 -0800 (PST) Received: from ?IPV6:2003:cb:c713:ba00:5d06:97c4:3fb1:e21e? (p200300cbc713ba005d0697c43fb1e21e.dip0.t-ipconnect.de. [2003:cb:c713:ba00:5d06:97c4:3fb1:e21e]) by smtp.gmail.com with ESMTPSA id bl18-20020adfe252000000b00337182d5d24sm12125536wrb.93.2024.01.02.08.11.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jan 2024 08:11:23 -0800 (PST) Message-ID: <747e1c4e-6339-4b11-aaf9-9f8c4a428d66@redhat.com> Date: Tue, 2 Jan 2024 17:11:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: memory: use nth_page() in clear/copy_subpage() To: Kefeng Wang , Matthew Wilcox Cc: Andrew Morton , ziy@nvidia.com, linux-mm@kvack.org References: <20231229082207.60235-1-wangkefeng.wang@huawei.com> <9bb17dcd-4651-41d2-9982-4632147a82f8@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9bb17dcd-4651-41d2-9982-4632147a82f8@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 16DF4C002F X-Stat-Signature: q4mggcseitrz8o3531hoyzypu9rrbtyi X-HE-Tag: 1704211887-735087 X-HE-Meta: U2FsdGVkX18uSnYed1JCNSWVwjvxKRrUiI/qIhjGXFhf8+0Op/pLPkC0KyqLc9ZHkcnq9MpWiRkvFC0RioL1MdHPDqmbe+tzqC020h7y2AX0blESIGlGSLLnk6JEeE2WCFOvGXpXIS3KunvR9ua9GnjmObweKhGNWWvRQk/UwBKRIfemJ0OfA1rHprwuwTiNg6ur2xKbZs9ylj8mruCuWQpgzvWh7nFklW6XFryLUdXOs9F1vTyYMj5Ja5xct6yDS2ZU9LsMj0F8Eww+Fos1Ng7xvIMTxIu4eB1ykjenql2ntZgFX8cjeHj6NJok5VpKaM0cWelEyfR4SaLsFb5ywfi+qVkxAqsnbmhk1YFixf5VqnfcUeGacI/kP58KyW5bYOeEXXs3l151G8oa6lXeu1L9WisoPTGddpKxIor6F2lS/itLzReaepAuIu6hca/mKu/eoXw0/nr/fPzTsDHEoLJZ6P27VdDACHdKXcqLYBuNSiIWi8QUddX3CNnYaJeZrC4JF9ZTsFVSpGwMLNczqtMtss+bsveTBfN18XFr/3ohMd4hNSkZ8moA242RNEWB/m35vcMl+vdNEs8JC/FOJoq13QwdGYB1CiGuALKYMY2KMdtrjqEBrS7i3TL/dojryMR7fv9D/MEYltgcAkKd/n+rhSJjwGR1h1Zy1DhyU59VUMY6m4GEw9ZWDCZhpBZxB787jMddnbT3NHJeuJLhgaemCuWqcQAl5+GWD37Gl+uXWjHjmnjNQqilH7vYKJfxpxOSbCjETFoLwY5LCMR8BHmDdUlt8LcGukGzKm/pxbWQCz1yXW8B/FZKqm+JZrlBDvHel2RfUJO6gJQBPDHx8q03BO6XdOu+6S2KF0p0UjiooaKUoHU/ChCXR9Mz76XjeMqzdrm0oEO/bUBUlNmx8EDO18CaApw13yRDJbRdpx5Fh/DRyY8EGdgmYEatNzph+i5NkwMIfVwaMz9wdE6 yM86h//V vmHUQQxQHZkmnoGkuf5nH/4apxnLsBX5ucizk9M2NK7/fYyM0w7UtNet+sQmvPhXTq+OvxEPsPxnM73X3fy0J0FAyaV60hTLEYXxQjlGIdkxsaEqRpTVSqBeQ/S0vBO53CYMkA1XLboSDbocv84VW1JSt9O3pAU32Zxb9I8Exxmoma3aQuOq73Kfj+6RynNTxpLVSYNYoGA9W1xqf28FHG6054zXNT928Nj+zGgOuaXzDpZfAZ5qy5bCmz4ZARjsben4IuHe6xuBhOw/HQghmpl0zyP72vhgd7IHh1iFrVXut3asjtu+0KGrnP6U/sjzn5dMM4punVNerLHBWyAkdPAJEOu6gm7tco1OepvxgSKbVhhO7GHo2/Ehgrck516yiBtLmIoEE4nB7JNtR1kUs5ubjwD5Zqz6/Da7w5tIu/Db4pDMfjYo5bxOykHLtj5hA7VO7M8Bd/mgbFtI1N5GeqSNKAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.01.24 07:53, Kefeng Wang wrote: > > > On 2023/12/29 19:15, David Hildenbrand wrote: >> On 29.12.23 09:49, Matthew Wilcox wrote: >>> On Fri, Dec 29, 2023 at 04:22:07PM +0800, Kefeng Wang wrote: >>>> The clear and copy of huge gigantic page has converted to use nth_page() >>>> to handle the possible discontinuous struct page(SPARSEMEM without >>>> VMEMMAP), >>>> but not change for the non-gigantic part, fix it too. >>> >>> Can there be discontiguities within a non-gigantic huge page?  My >>> impression was that you can't have a discontiguity at such a small >>> boundary. >> >> No, we can't. MAX_ORDER allocations from the buddy always completely fit >> into a memory section. > > On ARM64, we have 32M(16*2M) HugeTLB, it maybe not within a mem section, > right? I recall the mem sections are always at least 128 MiB on arm64. Note that anything > MAX_ORDER is called a "gigantic huge page" in hugetlb code. -- Cheers, David / dhildenb