From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3962EC54E58 for ; Fri, 15 Mar 2024 11:13:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B846F80120; Fri, 15 Mar 2024 07:13:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0BE4800B4; Fri, 15 Mar 2024 07:13:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 985C980120; Fri, 15 Mar 2024 07:13:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 830C7800B4 for ; Fri, 15 Mar 2024 07:13:17 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 02242C06BF for ; Fri, 15 Mar 2024 11:13:16 +0000 (UTC) X-FDA: 81899012034.02.B41D54E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf11.hostedemail.com (Postfix) with ESMTP id E18794000D for ; Fri, 15 Mar 2024 11:13:14 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dMLbha13; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9Eh2KuoW; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dMLbha13; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9Eh2KuoW; dmarc=none; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710501195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=68obMeZP9GkgE+BaJ/q7IbPrJxRaYAC1bA2WaPLQkyk=; b=rxKnzGGg8tSPt0WfS+C7jqDqjTi5f4Xg9ZknL7wf0O09v6dI0GMJV1MHFeSgG9tJNFPc+C 9PGkkvYS198UveeOLam5+m15hF/4Mew/1WcMfnWyAxoBOtgMURwOYBJnICU4sc/95GrJ5a sJmw+8kVVIv3En6n3S95b0iVGYdRenU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dMLbha13; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9Eh2KuoW; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dMLbha13; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9Eh2KuoW; dmarc=none; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710501195; a=rsa-sha256; cv=none; b=4eDfvOnS+/XncT+9J4qmsfU2ko406rpWvxsULcKuEBDoLE/x2XnShYo8qqd/ZTc4jwQh2T QsHZenV0cOYmz/SuOCsoJDVZQaNoosW6EEEhrcuxLXlLOkJJn/Lqq6TLVpqCjXLvlPmIfp 8vtX5qsqLBxLfGy+k6wjWfPEJ4iN/h4= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3B3611FB58; Fri, 15 Mar 2024 11:13:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1710501193; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=68obMeZP9GkgE+BaJ/q7IbPrJxRaYAC1bA2WaPLQkyk=; b=dMLbha13ROIJpvpe3teSaEg6sQbyzUsn3nJ7iTg/NI7zHefAG+SepVd8dcieG2AjpO0qRt 5Z/veNI6frMsJpas+ZrICnIlmkzu4eBMLgIh2b2wAB85AfN32ziieU/iqE88CFh/tke5WI u+mHtnRGL4UuBMKBtDDRrRjSDjvL6LE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1710501193; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=68obMeZP9GkgE+BaJ/q7IbPrJxRaYAC1bA2WaPLQkyk=; b=9Eh2KuoWjZ9HSFeLDVgV2S3Fyr4hZhkscbzHeva3IXDu+MalTjb31F4FK2OHPQeq5V2dqB 8Iob6aNC73+W7ACA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1710501193; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=68obMeZP9GkgE+BaJ/q7IbPrJxRaYAC1bA2WaPLQkyk=; b=dMLbha13ROIJpvpe3teSaEg6sQbyzUsn3nJ7iTg/NI7zHefAG+SepVd8dcieG2AjpO0qRt 5Z/veNI6frMsJpas+ZrICnIlmkzu4eBMLgIh2b2wAB85AfN32ziieU/iqE88CFh/tke5WI u+mHtnRGL4UuBMKBtDDRrRjSDjvL6LE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1710501193; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=68obMeZP9GkgE+BaJ/q7IbPrJxRaYAC1bA2WaPLQkyk=; b=9Eh2KuoWjZ9HSFeLDVgV2S3Fyr4hZhkscbzHeva3IXDu+MalTjb31F4FK2OHPQeq5V2dqB 8Iob6aNC73+W7ACA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 28417137E8; Fri, 15 Mar 2024 11:13:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id c1x/CUkt9GX0ewAAD6G6ig (envelope-from ); Fri, 15 Mar 2024 11:13:13 +0000 Message-ID: <74675841-efdf-4af1-8505-3ad548a34b77@suse.cz> Date: Fri, 15 Mar 2024 12:13:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] mm/vmstat: simplfy extfrag_show_print with fragmentation_index() Content-Language: en-US To: Luis Chamberlain , akpm@linux-foundation.org, jhubbard@nvidia.com, mgorman@suse.de, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, dave@stgolabs.net, p.raghav@samsung.com, da.gomez@samsung.com References: <20240314005436.2962962-1-mcgrof@kernel.org> <20240314005436.2962962-4-mcgrof@kernel.org> From: Vlastimil Babka In-Reply-To: <20240314005436.2962962-4-mcgrof@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E18794000D X-Stat-Signature: o85fshg3tnjfwe5m4wxbc84fechpdbxo X-Rspam-User: X-HE-Tag: 1710501194-365484 X-HE-Meta: U2FsdGVkX1+VsX1IQVFpiDN29rO5MpUr/JTYLN8dIw8TGKqOiwCPDY3JiOWBfBtNiumoXZmq8SDX0/9DU9V3P1TTeyGmwcUWz/v9hPn+3rS19tC0qk7c+HX3yf+Ofdgs0cr8Kjt47ovtB5HcHyCa02Ctkr47LPXy3jWqprcvR/htFABk2HRbD/ntgnUogAD3P2hYjNDtHnljExvJVS5/eERveZW9zzXZ+pjypj15z0ZurfckT+ppmgPaxydQKLxwV6UN/bFg/3CAmL9kzOqZCmhXsP9GX/B4Mfflh11rrlF+Bva8fQDl9f8+cF8jDeNvlBuorJGw9duWJnfagd+NthdnL6SWxx26ZX7pLq9aREqS/E725lryN1TcClyv/Xj947kf3znr0Haw2zztibxK54+UcKr83108SaOg7hQJgQ9pAGM1Qzb4yqGP9cKC0oQt/8cOcLWvy4pG1WtROrgyyGQnhX+IW9nEHLtP5m6wvtBQA2QBc/E5C304mLk0wQnCsWfssZyOQTgJquJNyoSDHlnYXPAbuhdUXRUTzshihtvSI03w5pzqgQdLB6is/9kwMrWW9ojZw24AAZh6giTaSWa9gEXPuavZie/dmWNBujh8u3VhWskvfe9ALeKkAiXLbsAhG0kXFmxZ1e0p31Dal+Xw8zr9BJlZ/fnEygisxgHouxDqIv0ikfvuiSW6ZGwNvTeR4qX7wzUOCLwxcl4/cEjoCKsckS70LWxpS4iqGK4miMnAyEAc1YVZbFvuFfWzoAgDjCC7gHI7NmcP068h/Jf7wOgBfQWlBj6YoRbuqr0g6y0sy/y74LSqhr6PJPyWdrCP2AXHy06e1M6haX7dPLJgO99Lj6ES6vLZ/iFwYu4bkpchht2UwXtGM1gw/24Y2b++DLGvARmArIyKKj6urEFVPqCxfFWmKaNABqBS6khlNF7xGtdxVQgDb2yhf8HUYKaieZx8XPVsgZ+Q2iP rAmZQ2yW KImJZwLNQNCul+Nk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/14/24 01:54, Luis Chamberlain wrote: > fragmentation_index() already uses the stack for the struct contig_page_info, > so just use that and enhance the documentation for fragmentation_index(). > > Signed-off-by: Luis Chamberlain Reviewed-by: Vlastimil Babka > --- > mm/vmstat.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index db79935e4a54..582f89b37ccf 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1129,7 +1129,10 @@ unsigned int extfrag_for_order(struct zone *zone, unsigned int order) > info.free_pages); > } > > -/* Same as __fragmentation index but allocs contig_page_info on stack */ > +/* > + * Same as __fragmentation index but allocs contig_page_info on stack, > + * useful when walking a zone as interrupts are disabled. > + */ > int fragmentation_index(struct zone *zone, unsigned int order) > { > struct contig_page_info info; > @@ -2227,15 +2230,11 @@ static void extfrag_show_print(struct seq_file *m, > unsigned int order; > int index; > > - /* Alloc on stack as interrupts are disabled for zone walk */ > - struct contig_page_info info; > - > seq_printf(m, "Node %d, zone %8s ", > pgdat->node_id, > zone->name); > for (order = 0; order < NR_PAGE_ORDERS; ++order) { > - fill_contig_page_info(zone, order, &info); > - index = __fragmentation_index(order, &info); > + index = fragmentation_index(zone, order); > seq_printf(m, "%2d.%03d ", index / 1000, index % 1000); > } >