From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D914DC3DA64 for ; Tue, 6 Aug 2024 11:17:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5737A6B0083; Tue, 6 Aug 2024 07:17:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 524466B0085; Tue, 6 Aug 2024 07:17:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 412DC6B0088; Tue, 6 Aug 2024 07:17:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 210146B0083 for ; Tue, 6 Aug 2024 07:17:55 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C137B16096F for ; Tue, 6 Aug 2024 11:17:54 +0000 (UTC) X-FDA: 82421570868.08.E7854E4 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf07.hostedemail.com (Postfix) with ESMTP id CA3BD4001A for ; Tue, 6 Aug 2024 11:17:52 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722943010; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EFkL84CTkC3I7SwiG2n9KiyREk/+bQPaaB/2VIE17gU=; b=s32RSrdmh8m9eP5XzmPwo0z+fgTUP1k1fIP9DWQAj2CCzr24QCII+OQLeFRr3wdL8JqpfE QQkYg6eB/1UkQm9e2tpv2oEQvNAs7aDA5UywkavGjIXE1TYBv/5uSK4n10b2NhAA8vDPG2 ZREi6OUKbDzUAOXYMT9z6Z55v1Ix/iE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722943010; a=rsa-sha256; cv=none; b=fppU9tsMdgxAMTf2HuqPiZV3gvQTyqh5wjiDWE3ksPlHR8fMN573TQtmqhxEkUhF/J2iCR kY1IVXVnjFmwXlRtUiwJr/6+/Qbq2swahSoRMmxsQ/3tXgxSRJHGbeHjy/tSUsLZpOdcdr I7jgxyW8lQLp/kSB9TAwE4zZJdbd3/4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 65557367; Tue, 6 Aug 2024 04:18:17 -0700 (PDT) Received: from [10.1.31.182] (unknown [10.1.31.182]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ED8603F766; Tue, 6 Aug 2024 04:17:48 -0700 (PDT) Message-ID: <74536df6-98c7-43ac-9ae6-8106eea123ec@arm.com> Date: Tue, 6 Aug 2024 12:17:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 07/11] mm/huge_memory: convert split_huge_pages_pid() from follow_page() to folio_walk Content-Language: en-GB To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Jonathan Corbet , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Gerald Schaefer , Mark Brown References: <20240802155524.517137-1-david@redhat.com> <20240802155524.517137-8-david@redhat.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: kuydo6py4xodwoe6n8mpgqyi9msfsm1h X-Rspamd-Queue-Id: CA3BD4001A X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1722943072-624550 X-HE-Meta: U2FsdGVkX184mXWtaWChLDh5UVTGnxgQ0Acq0JeNhoQhjSaKJvovKRrBpFwVNtxU1pxi49B1o2hh246tuiRKFMBVT+vUb3aMrQbSldPyIQATZRZx8tZVTc8hIwQ+u2AsXot5yKshJzVg6MJVKwymDgpE+6Lylzw2/FR06kOhvBOOK8lIKKpobikxbCgN5u0bm6MjcJLZB2H7sC7BFmXWtdsLm/9QGZYpNiqXef7ZOUIqzxXyMDSdsvupJvx6mYRZHlzBcAiloX20OqfImQ04wMI6W7pAejl+HmUbeiw5ye5yjUHosgtU+q4k/fxQiUb7+Tb6TfR8VQJbrk0wfZj6zXecwwA3AzTlOeCMMVNyWtB5S57dFeGYZf3jLe74NwStC5BGX1gF/9+Pg0ytOjDXcss177qUfz1Tlc9uNtLVLBosV6U+YFYH9bK2N2p7turAhWggq2Fsh8mU0gm9Lr6OJahWbzuk6xwsEQr8/1sdM6REcRFI3VzttMPwSK6cIsVAlO16YXLLVYB5m8SwHLrQUdkhI+zlseCSaMvspPkQpGFn842lw7xs6ouFtQrNvAqOWsFi56EdDTHR8ZF3/OUxd8NH4RFdO+32r2Kg2HXjUHNuzpj9zZ28PeKtbnsTFnX/J9bIA5iPfkJ31DOShdY1lBtdX+VZELHhd2A/y2YIqf05eO5P/Y9f9UnAIRoWmKDrECPJEtIoc7lRvVE/rK7dmaC0mvHBOQ50HEE5RBq2i1o4K2FezkVZijPuZOnmc0z+1v6zfPx0ONdEEQmFbbVuuVm9O68pZPA+bYpY7H6Sp4vQYree/71TDqTwlZ1aWK7Mtu6zJzFlSIipS5Epaoa1nhrwN5LeCyBuHgZ1VpIqZwrLaZBNSfvIHvqja4bKgU2VVCmM9uefvKy+gKpMEYtC0oL9JRyFBOmqSzadviNPujoWef/i2MUa6JxBQnUttAxaegNc6nzUuIbsTMms8sP dlhCnGXe VJYSVW8nJh2htGk7eXuduOA/rcQ+FhcG07dcTBPW111yEL2kuv2s+xFF0E8vxy8KAgRtyGC3BCUmoMoO5O0ZNUZeiCNQnTlo80M3WYNC2UePhV+BvmuKsO5/SfsYPgFQyJ9d0v7AR4KW/NnPSlGzozXW7p487Y0kOc7QhoNGmrEuv/1eIuKIIAbHmP8oGReeI1IiWpDEF+nshy+J5tv0F51fcnZb1qVkn0NBf90cfroADA0W5/2l16DRmsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000075, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>>> It's trying to split some pmd-mapped THPs then checking and finding that >>>> they are not split. The split is requested via >>>> /sys/kernel/debug/split_huge_pages, which I believe ends up in this function >>>> you are modifying here. Although I'll admit that looking at the change, >>>> there is nothing obviously wrong! Any ideas? >>> >>> Nothing jumps at me as well. Let me fire up the debugger :) >> >> Ah, very likely the can_split_folio() check expects a raised refcount >> already. > > Indeed, the following does the trick! Thanks Ryan, I could have sworn > I ran that selftest as well. Ahha! Thanks for sorting so quickly!