From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A89D8C25B08 for ; Wed, 17 Aug 2022 14:04:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D646A8D0002; Wed, 17 Aug 2022 10:04:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D14A88D0001; Wed, 17 Aug 2022 10:04:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDB4C8D0002; Wed, 17 Aug 2022 10:04:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AF2168D0001 for ; Wed, 17 Aug 2022 10:04:13 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8094B1A1657 for ; Wed, 17 Aug 2022 14:04:13 +0000 (UTC) X-FDA: 79809253986.30.D6C9D3F Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf11.hostedemail.com (Postfix) with ESMTP id A52B1401DB for ; Wed, 17 Aug 2022 14:04:12 +0000 (UTC) Received: from fraeml745-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4M78rV4shxz67Pn6; Wed, 17 Aug 2022 22:03:54 +0800 (CST) Received: from lhrpeml500003.china.huawei.com (7.191.162.67) by fraeml745-chm.china.huawei.com (10.206.15.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 17 Aug 2022 16:04:08 +0200 Received: from [10.48.158.152] (10.48.158.152) by lhrpeml500003.china.huawei.com (7.191.162.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 17 Aug 2022 15:04:07 +0100 Message-ID: <743867a6-b266-58e4-a8a6-542757916f0a@huawei.com> Date: Wed, 17 Aug 2022 15:04:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression To: Oliver Sang CC: Damien Le Moal , Christoph Hellwig , "Martin K. Petersen" , LKML , Linux Memory Management List , , , , , , , References: <1f498d4a-f93f-ceb4-b713-753196e5e08d@opensource.wdc.com> <3451fa5a-6229-073f-ae18-0c232cd48ed5@huawei.com> <2e9cf5a6-c043-5ccf-e363-097c6c941891@huawei.com> <43eaa104-5b09-072c-56aa-6289569b0015@opensource.wdc.com> <28d6e48b-f52f-9467-8260-262504a1a1ff@huawei.com> From: John Garry In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.158.152] X-ClientProxiedBy: lhrpeml100005.china.huawei.com (7.191.160.25) To lhrpeml500003.china.huawei.com (7.191.162.67) X-CFilter-Loop: Reflected ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of john.garry@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=john.garry@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660745052; a=rsa-sha256; cv=none; b=HdUooSU2Hq5q9e5J0kkXaR7qnexCb10KxiiX4EAbannE5W9G9uJS0RkqyfE7AaHRgYSM7B G1I2i8JDlVyd0MXWPsUKmTM3A7DQKPMwqXyyHvpQiL04kJR69clb6psPAv1CmYSKkQTyjF 9QcXZBY/r+DdRva/3xroB1MBH+iBe5M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660745052; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SYHqzv3nXmfCVEbXBGtAuBlQcgtegK0c27JQzspcJR4=; b=OABoaNw/oezCRFndZgOiqSG6aDu7cgOtLu+ZmM+OE1y/WPomB8nnA+OYejK/0VgSW4pDm1 XFeXXTR6zjzT5NAdbeKA/HF8cGcaVWDe80erhRB48tbtHzIVJG6FrxTtHh1Aes2cXHVByb +5laI59wVvDS3zbmHikIKoJu6z6dkjM= Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of john.garry@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=john.garry@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: o4ryhpz1w7c6ij6wn9rphyx948dz1dad X-Rspamd-Queue-Id: A52B1401DB X-HE-Tag: 1660745052-696253 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17/08/2022 14:51, Oliver Sang wrote: Hi Oliver, >> v5.19 + 0568e61225 : 512/512 >> v5.19 + 0568e61225 + 4cbfca5f77 : 512/512 >> v5.19: 1280/32767 >> >> They are want makes sense to me, at least. >> >> Oliver, can you confirm this? Thanks! > I confirm below two: > v5.19 + 0568e61225 : 512/512 > v5.19: 1280/32767 (as last already reported) ack > > but below failed to build: > v5.19 + 0568e61225 + 4cbfca5f77 > > build_errors: > - "drivers/scsi/scsi_transport_sas.c:242:33: error: implicit declaration of function 'dma_opt_mapping_size'; did you mean 'dma_max_mapping_size'? [-Werror=implicit-function-declaration]" > - "drivers/scsi/scsi_transport_sas.c:241:24: error: 'struct Scsi_Host' has no member named 'opt_sectors'; did you mean 'max_sectors'?" > > not sure if I understand this correctly? > for this, I just cherry-pick 0568e61225 upon v5.19, > then cherry-pick 4cbfca5f77 again. > so my branch looks like: > > a11d8b97c3ecb8 v5.19 + 0568e61225 + 4cbfca5f77 > 1b59440cf71f99 v5.19 + 0568e61225 > 3d7cb6b04c3f31 (tag: v5.19, > > did I do the right thing? Sorry but I was not really interested in 4cbfca5f77 and I see where that build error is coming, but don't be concerned with it. However, for avoidance of doubt, if you have results for vanilla v6.0-rc1 then that would be appreciated. I will also send a separate patch for testing if you don't mind. thanks, John