From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61537CF11E1 for ; Thu, 10 Oct 2024 12:37:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 016C86B0082; Thu, 10 Oct 2024 08:37:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F09136B0083; Thu, 10 Oct 2024 08:37:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD1446B0085; Thu, 10 Oct 2024 08:37:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C1D376B0082 for ; Thu, 10 Oct 2024 08:37:34 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C77401C4CD6 for ; Thu, 10 Oct 2024 12:37:30 +0000 (UTC) X-FDA: 82657643628.23.DCA493B Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf22.hostedemail.com (Postfix) with ESMTP id A309BC0011 for ; Thu, 10 Oct 2024 12:37:31 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf22.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728563741; a=rsa-sha256; cv=none; b=XHumwmhYV0vnlvOjY0e1HNsGoepXa9rA1wivZlCeXP3r5EYhyflmYSjVbSOh65JPq8ffZB Oly7iaPzQ7b1EvMSMkEsDbdS+pVaCNVqd9zJlTb6TePGTGKvLPDpGFRTVbHDbblDpIp/03 AnlmaNXvuYnoEbHJBkwgxIAhauuE130= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf22.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728563741; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C+nrhf50fGAnU/z2Iz04ZWcTWEhWW1bjN5mWuq/srFY=; b=bo/A8gy0QqMVIpZSzUOojpkbAQjG/6sDtee4+7H2b3d7S2BhbJxPL2Kau43yYj0GdtzKIc UONuowJS5DwY/DihvfHu8DaMER1WeXSvCClpv1zWhtZ8AzX3Lc8JlW90G69zOko5PTDSSr 2wf9pyYGNVxonHoiwRQPMFRjSpHqCMU= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 73C78497; Thu, 10 Oct 2024 05:38:01 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3595B3F58B; Thu, 10 Oct 2024 05:37:29 -0700 (PDT) Message-ID: <7433aee2-a2c3-43ae-8ebf-2d9e4f66cf56@arm.com> Date: Thu, 10 Oct 2024 13:37:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h To: Michael Ellerman , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Cc: Andy Lutomirski , "Jason A . Donenfeld" , Christophe Leroy , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers References: <20241003152910.3287259-1-vincenzo.frascino@arm.com> <20241003152910.3287259-3-vincenzo.frascino@arm.com> <87wmihr49g.ffs@tglx> <87ttdlr3s5.ffs@tglx> <878quw7rrs.fsf@mail.lhotse> Content-Language: en-US From: Vincenzo Frascino In-Reply-To: <878quw7rrs.fsf@mail.lhotse> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A309BC0011 X-Stat-Signature: hzr6ggushmiew6dndf47eqf56frztta3 X-Rspam-User: X-HE-Tag: 1728563851-893098 X-HE-Meta: U2FsdGVkX19gClVbxjcIDuFJjuuBzEbjFfqtCmAq1I3o0AKHXix/95woWuLRJqKyC5MikpxbWcHD5jInV++jkLlkGyUcSWBHT1c1h0xF+f+uKhcqkfPLLwy7RJOfYaq4LeQJRA/v7Pyor0WOQp2sDdtU1RmQd51K7+/Ish628dasgWiOi3VpUoMype0O4VVxp80U5Qu14EHAdOzvrsrALdbYAjTLOv62o7zlHqr/mlJAbe17QFbenidu/k9mQazYlm9rJ3AQq5akBU1V4dfOsyTG754SoM28LrkykGM0WEW1J0qk8XF1Peuha5HVewO6T2jIkdXvXrA4mwYisRoDe10nS2uBOhiI7OIbwXXWIlK3qGHSvPC1x2iGlP8wRjY7b8epDqHRj2Y9rErJG68/UgHJ5QETm48klSRf7n7CdAZ3RMUeuY8ByUreiyZQcWl8/GEKrtQQMwlrI3Hv/hogpoVKRhu1+Egq/K/Bxf3khmP2znxWMrbhDMC1DI86slIyHNNqTQmqWoNBqyzOs676+/ia089heyInZt1V5vVlHOno6WjiYnvf9N7zUmgxynjWJOM1B0G+6dQa7t2jJNpKwhvgHyCTOz0un5i827bKzaZr40nfAqr0EYX9tgNWR6M0Hk53WUcFMijnxwCH6JkZ8BBJVxR+xLXFtZDTaP7A/NOjuJUbwQjmKq+JB9cL1bvYWb7rAvNiAj/+CeW3IYr4WvFtxdi5c2XJ1l/KZJNJKwk0llqN0JZvqlSkICIFmVJniTVYxWJPNrNO1/iVFHAA+oQwv4+x19hNN2c8Qqv5e6MnmrwrYzouN7/UExdhGQq0D1gpaOR32elbsZTitSQcWH3DS9m7gvOxmOesShO9Iuo9w8W5R1pMCf97ersRWrcCnbUViwi5SbhAqmX3GdO8CM2s04fq0nB9AzAqtXnjgftflpdHPv9FmiW26JiPZZwsv33puD26zfP3Oij/f1x 96vBDtZ9 K9/KMZ1i5MIp9CLyvnys1IdP71lGfzFJGzX5NoTf8Nb+uQ3xXisWoFttJpSHBAUMS7Hu6TYIfUJ5NcAZfsJTcV6yzqHj3WDro2vrqi3e+bsoRYViR74fKl7Rj01f15yRyH3EmTcl3eNc2kekHIEGTCwee9A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/10/2024 00:58, Michael Ellerman wrote: > Thomas Gleixner writes: >> On Wed, Oct 09 2024 at 11:53, Thomas Gleixner wrote: >>> On Thu, Oct 03 2024 at 16:29, Vincenzo Frascino wrote: >> >> Hit send too early. >> >>>> +#if defined(CONFIG_PHYS_ADDR_T_64BIT) >>>> +#define PAGE_MASK (~((1 << CONFIG_PAGE_SHIFT) - 1)) >> >> This really wants a comment. The magic reliance on integer sign >> expansion is any thing than obvious. > > +1 > > Vincenzo feel free to take/modify the one from arch/powerpc/include/asm/page.h :) > I will, thank you :) > cheers -- Regards, Vincenzo