From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFE61C433FE for ; Fri, 14 Oct 2022 06:53:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 147776B0072; Fri, 14 Oct 2022 02:53:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D0146B0075; Fri, 14 Oct 2022 02:53:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8C066B0078; Fri, 14 Oct 2022 02:53:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D2B626B0072 for ; Fri, 14 Oct 2022 02:53:05 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A436D1C5C5A for ; Fri, 14 Oct 2022 06:53:05 +0000 (UTC) X-FDA: 80018637930.28.CD24D47 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf08.hostedemail.com (Postfix) with ESMTP id F2DAF160026 for ; Fri, 14 Oct 2022 06:53:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A9A881F385; Fri, 14 Oct 2022 06:53:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1665730383; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UXBq2GZecaEmvotCXnmQMpFhZdLX4/98y393x3vVLfI=; b=IUqOVVSH0ZnLLJjdBVBRZ4iBOYT2Y1Cp9I9nWmUFiJeyqNwvFXyQOxwTYMbfBT61G1gmtK TNJZLWEwh0QNp1oU3XlQ3WhY3AaV1lFKF9jVTHMOZxMKYyTz9sBuR2kgluKgffhEppzxuP XJyUperk3Y9AOudCyrWzpkF/cXpE7e4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1665730383; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UXBq2GZecaEmvotCXnmQMpFhZdLX4/98y393x3vVLfI=; b=y+Kd3g2/E+cvNlYEU1buRTtgZmAH7njIFWyDBABC8ZSE29+ws/zzTmdg7WU8splSv7tJze +LImP5dj5m592rAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6391513451; Fri, 14 Oct 2022 06:53:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id atNnF08HSWPlRgAAMHmgww (envelope-from ); Fri, 14 Oct 2022 06:53:03 +0000 Message-ID: <74255a05-831b-0aaf-b265-e6af4cd0aabb@suse.cz> Date: Fri, 14 Oct 2022 08:53:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: hmm_test issues with latest mainline Content-Language: en-US To: Alistair Popple Cc: Shuah Khan , David Hildenbrand , Alex Sierra , Jason Gunthorpe , Ralph Campbell , Felix Kuehling , Christoph Hellwig , Jerome Glisse , "linux-mm@kvack.org" , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan References: <26017fe3-5ad7-6946-57db-e5ec48063ceb@suse.cz> <7e2e6679-3205-3540-f522-9eaed2940559@redhat.com> <44fcecda-31a4-7288-1848-63003dfe0a7d@linuxfoundation.org> <04114304-7b35-d42f-0155-087e3b6237c6@suse.cz> <0e02ace6-2fad-47d2-03b9-d8a46f256097@suse.cz> <2d4b8d64-f17f-90ad-7328-b5ca7537d08a@suse.cz> <87fsfrjgq6.fsf@nvidia.com> <87bkqfjdec.fsf@nvidia.com> From: Vlastimil Babka In-Reply-To: <87bkqfjdec.fsf@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665730385; a=rsa-sha256; cv=none; b=Ir5dq5NPKw7ILsCok/nyc+nbvxkISOq1Jz7JtBmyqK2J3H4pAJoEhxUZfPwC3G0jHbXRcQ DRE8Ks/1AnW1SzwwGiy/yBxnHf4tem7SLN357TUUOQJFT+woaEJywzKIsA3VQczUp/ZdMN oS9D1Usn6jjsDeC3c1+69olpKRryIMI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=IUqOVVSH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="y+Kd3g2/"; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665730385; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UXBq2GZecaEmvotCXnmQMpFhZdLX4/98y393x3vVLfI=; b=kbS0Tfuy+CFS64yKA1jDHXf6WAAu//fX3LS1nG880rgP22V9ZrL+uAGdghZKCgY2RcHrdc IVET00J9oVjKiV3Jc1Lr8IojMMTAvHoEt9og4oeb0VEU6qfU21NONjQeYmqvfrloT210e9 NK/uV1CujxYQEhXxZcPa3sIh2EPX8ec= X-Stat-Signature: pebamq4i9swgcw33q7rpdt74kph5gx73 X-Rspamd-Queue-Id: F2DAF160026 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=IUqOVVSH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="y+Kd3g2/"; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspam-User: X-Rspamd-Server: rspam03 X-HE-Tag: 1665730384-137725 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/14/22 05:21, Alistair Popple wrote: > > Seems like this would fix both the SKIP in FIXTURE_SETUP and ASSERT in > FIXTURE_TEARDOWN issues: Yep, that fixed the infinite error loops for me, thanks. ... >> Unlike hmm-tests though the above snippet reports correct pass/skip >> statistics with the teardown assertion removed. This is because there is >> also a bug in hmm-tests. Currently we have: >> >> SKIP(exit(0), "DEVICE_COHERENT not available"); >> >> Which should really be: >> >> SKIP(return, "DEVICE_COHERENT not available"); >> And with this on top, I got the skips due to DEVICE_COHERENT not available counted correctly. >> Of course that results in an infinite loop due to the associated >> assertion failure during teardown which is still called despite the SKIP >> in setup. Not sure if this is why it was originally coded this way. >> >> - Alistair >> >>>> thanks, >>>> -- Shuah >>>> >>>> >>>>