From: Vlastimil Babka <vbabka@suse.cz>
To: Alistair Popple <apopple@nvidia.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
David Hildenbrand <david@redhat.com>,
Alex Sierra <alex.sierra@amd.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Ralph Campbell <rcampbell@nvidia.com>,
Felix Kuehling <Felix.Kuehling@amd.com>,
Christoph Hellwig <hch@lst.de>,
Jerome Glisse <jglisse@redhat.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>
Subject: Re: hmm_test issues with latest mainline
Date: Fri, 14 Oct 2022 08:53:03 +0200 [thread overview]
Message-ID: <74255a05-831b-0aaf-b265-e6af4cd0aabb@suse.cz> (raw)
In-Reply-To: <87bkqfjdec.fsf@nvidia.com>
On 10/14/22 05:21, Alistair Popple wrote:
>
> Seems like this would fix both the SKIP in FIXTURE_SETUP and ASSERT in
> FIXTURE_TEARDOWN issues:
Yep, that fixed the infinite error loops for me, thanks.
...
>> Unlike hmm-tests though the above snippet reports correct pass/skip
>> statistics with the teardown assertion removed. This is because there is
>> also a bug in hmm-tests. Currently we have:
>>
>> SKIP(exit(0), "DEVICE_COHERENT not available");
>>
>> Which should really be:
>>
>> SKIP(return, "DEVICE_COHERENT not available");
>>
And with this on top, I got the skips due to DEVICE_COHERENT not available
counted correctly.
>> Of course that results in an infinite loop due to the associated
>> assertion failure during teardown which is still called despite the SKIP
>> in setup. Not sure if this is why it was originally coded this way.
>>
>> - Alistair
>>
>>>> thanks,
>>>> -- Shuah
>>>>
>>>>
>>>>
next prev parent reply other threads:[~2022-10-14 6:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 16:54 Vlastimil Babka
2022-10-13 17:01 ` David Hildenbrand
2022-10-13 17:10 ` Shuah Khan
2022-10-13 17:12 ` Vlastimil Babka
2022-10-13 17:29 ` Shuah Khan
2022-10-13 17:45 ` Vlastimil Babka
2022-10-13 18:00 ` David Hildenbrand
2022-10-13 19:38 ` Shuah Khan
2022-10-13 19:43 ` Vlastimil Babka
2022-10-14 1:45 ` Alistair Popple
2022-10-14 3:21 ` Alistair Popple
2022-10-14 6:53 ` Vlastimil Babka [this message]
2022-10-14 6:45 ` Vlastimil Babka
2022-10-13 17:03 ` Shuah Khan
2022-10-13 17:10 ` Vlastimil Babka
2022-10-14 12:01 ` Jason Gunthorpe
2022-10-14 15:03 ` Felix Kuehling
2022-10-14 15:47 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74255a05-831b-0aaf-b265-e6af4cd0aabb@suse.cz \
--to=vbabka@suse.cz \
--cc=Felix.Kuehling@amd.com \
--cc=alex.sierra@amd.com \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rcampbell@nvidia.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox