From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F218C46467 for ; Tue, 10 Jan 2023 13:36:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FD828E0003; Tue, 10 Jan 2023 08:36:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4ADC88E0001; Tue, 10 Jan 2023 08:36:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C4F38E0003; Tue, 10 Jan 2023 08:36:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 295A08E0001 for ; Tue, 10 Jan 2023 08:36:35 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EF54312051F for ; Tue, 10 Jan 2023 13:36:34 +0000 (UTC) X-FDA: 80338989108.08.AE5ED97 Received: from out30-8.freemail.mail.aliyun.com (out30-8.freemail.mail.aliyun.com [115.124.30.8]) by imf02.hostedemail.com (Postfix) with ESMTP id 1EA1080013 for ; Tue, 10 Jan 2023 13:36:31 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf02.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.8 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673357793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=79EipwoUGWr7Dt7aei0D+jzzxgqlEkuV8Uc+tPdrsQM=; b=R2qo3AlAOf1a7zV0/j4R6gAEqr03V0nMYIPIrLAg/41s3GuSYNyunLY5hvXCm22RmTgJy3 DqyUT0oS0alVpw3EsQd60UN5M5pwi9wtWvzuqe4fAisqqx6mVHpmdcGnzyi5cC1JLcDfRa wpD+Nf1vwWUWkWONB2Tsc7ghCpSRihY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf02.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.8 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673357793; a=rsa-sha256; cv=none; b=Ftd0SVnmnInfhZC3fAnXXsQM7dtu+cnlg9IY+Z6VWtyLx92Czs3uOm8Hi9EpZNllUftvcj 8+JxbQBWH+hOWolkhchtLRQE0P2EW4EYpHDpBhQfFfMZx7Deq8zemmsNgVwUSlrnjQ5Uva F+s2etXuONL1l9IiRZajl//y7WK5x54= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0VZJNeww_1673357787; Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VZJNeww_1673357787) by smtp.aliyun-inc.com; Tue, 10 Jan 2023 21:36:27 +0800 From: Baolin Wang To: akpm@linux-foundation.org Cc: baolin.wang@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] mm: compaction: Remove redundant VM_BUG_ON() in compact_zone() Date: Tue, 10 Jan 2023 21:36:18 +0800 Message-Id: <740a2396d9b98154dba76e326cba5e798b640ead.1673342761.git.baolin.wang@linux.alibaba.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1EA1080013 X-Stat-Signature: qce454het8mm1gjp8mbc7d1yt6j3k5ao X-HE-Tag: 1673357791-420306 X-HE-Meta: U2FsdGVkX1+VadUWuGHmdT8IR72BUxTcJpefO37CzsLvZzeLunb1N5QgqC08o1E0/2oADvISioy/Y2Rk34SLzbdeIxPA0fhQouuQSud8KxyO4zYtU68lYW71QOmgOY1uLfzi7Qwwj1N5ACmQ2xBngsG2dJ/5xXqp4sWxgGkBEZQt3taT5hWJoeqJuvWxX3owzjQ08NxSuloy0JwEzDMel5+R5wljviplMbckqCR5dUGIHLlP3VppulK1VLZHoPMSSmri0Oq//gebngAI7zBDs9GDOA/Z5orve7MiDPQNrUlzdCtw8P3rN5+A5kQvKLZKJNvTZNjfBYvFMW6UBQc50IFivSKaO8eyf9Ev8Qp5cC0bY1viVv2PpFo2lInrvZmpGgMcPFIdgUEaRVO74f8sYmnG2QyLmEwi2ar5RFUXbqaYsZ3W5zN+LuXl3fteki91R9KOJSsjbXs/3Sm1VY5FVS+32c6zqfDB5MBz2cz6BB+KtU3TXkW2yAIgWWkaF6yAKJjKgatJsFfaNG1uukf5WsekvNNB/O6O9TBWVneLSQXclEN77TdXc3ZOj7RsctbXhkdsJ88RAarrDeUJ0mSjCDVkMllGmsbjZmc4N/VDBIPvurwdmZFtTQKBUQORp+J+S4f2zfpI3uDif2quWuTXuu4CgjilOCgf9dl3/hWm+tNtHZqa427C9SeO6yb1CR2JuocwqAaKC+Y3e1Q5nse6Ms2QZnkW3mPUJLMOoxSUajfEVTGg6Qv5dYLwtNxYZG24/STJbk19ao/8fc94lCkXOcmtuyUrf08U6XRLz+JGcD78tfh+RgX5YIClIF7OHTYw8FhSUvJqqvX1RPdh2sZ4AfJ5b5ZeBNnzSwTGW54WJ0Ist+VsJtbizw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The compaction_suitable() will never return values other than COMPACT_SUCCESS, COMPACT_SKIPPED and COMPACT_CONTINUE, so after validation of COMPACT_SUCCESS and COMPACT_SKIPPED, we will never hit other unexpected case. Thus remove the redundant VM_BUG_ON() validation for the return values of compaction_suitable(). Signed-off-by: Baolin Wang --- mm/compaction.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 62a61de44658..5e6f5e35748d 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -2313,9 +2313,6 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) if (ret == COMPACT_SUCCESS || ret == COMPACT_SKIPPED) return ret; - /* huh, compaction_suitable is returning something unexpected */ - VM_BUG_ON(ret != COMPACT_CONTINUE); - /* * Clear pageblock skip if there were failures recently and compaction * is about to be retried after being deferred. -- 2.27.0