From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52BF6CF9C64 for ; Sat, 21 Sep 2024 21:08:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD4806B0085; Sat, 21 Sep 2024 17:08:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAA9F6B0088; Sat, 21 Sep 2024 17:08:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4B926B0089; Sat, 21 Sep 2024 17:08:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9587E6B0085 for ; Sat, 21 Sep 2024 17:08:08 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 04082140B3D for ; Sat, 21 Sep 2024 21:08:07 +0000 (UTC) X-FDA: 82589983056.01.C05674D Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf23.hostedemail.com (Postfix) with ESMTP id E1FE4140026 for ; Sat, 21 Sep 2024 21:08:05 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jr3azFp+; spf=pass (imf23.hostedemail.com: domain of groeck7@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726952827; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1ZyEP8RqiEX4aO8buEZUbFkfwoj9qwj5TS4bmseu6C8=; b=ohVc+r432ZBcZeNQaw2Di4UF53hrS7HQ/0Xb1t0gdnu1ItjrbXYWcHotZEjpx6F7Tu7q0R rr8MzAaW1KW/3UN+z2eCBvFTbNMMsk+doZHc3FoOzgOPJQqa53gFP0B9+M7Y0S5Yhgmj93 JFGeWRPcicmhS9gCVZEsUBmoiA8eW4Y= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jr3azFp+; spf=pass (imf23.hostedemail.com: domain of groeck7@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726952827; a=rsa-sha256; cv=none; b=kBrE1+RmnixnOMIifhh/xGkExzfrOJKynjmO4OJMFyTh8ZQFhGiKMM1TGr4LpQSeAEhCTw oMCQ4J2w391hyjg+ImStRJeLE4tBjlQPVhx2rAkhbuqRM5TXs1mCrfRTig0VpptCaj3Wxx mvjSAPw1K/+spdy/woEZgQVsUBtDseQ= Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-7d4f85766f0so2602281a12.2 for ; Sat, 21 Sep 2024 14:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726952885; x=1727557685; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=1ZyEP8RqiEX4aO8buEZUbFkfwoj9qwj5TS4bmseu6C8=; b=jr3azFp+Yy73+qERYXzEnE5B6AcHAwV6rzW+Qfcumi5VzN42qeqRUcMgys+jxkr7ME slbESgR0HpcfoMP4z3ay9jkVKTp+gk9nG7CXUpA9GSFqYk/+OCIeQzLJGDsWi1a/ZCfx /nanMkx5VITnNjhQVe7RjylDUitGcg/UOQlARc5SkA4C79vgg2quHaFWec7/ZfbJDnQl v158piTEHDIP5RpX+hXEpwYaABGhvqCOzXnB4vDWHcbZUa+guxIZ5vSjuVus+xTNv1e5 oIEsJFalNXKLcjhwZIlFLtjxVeqz0ETtdwGCa5+Mze/DMngA7+3uW6hRLaI13D3StDo7 aOkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726952885; x=1727557685; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1ZyEP8RqiEX4aO8buEZUbFkfwoj9qwj5TS4bmseu6C8=; b=biZrJjMLm3j+uJ6M9WJpL6JDvhgusO77lplTfwKxR4udEPwuTndEqdN65Oeal3k0ki 97HrzEQZLBvBokmQnCxbIFmtdUmnOsNf802VBUYQ5etv8Twulk/ES7xxPVsns+23D5x0 wZeN20F4X/R0MNiV1pupuB4PY4qPIgcQdDXjYsFV8fYqXpw+hPWjvrd3fOEKwLEn4H80 1Y8+nyxXg9Txp8w3KtOxQlV2hU3w/LrAVDpFNpWOANMqGmIVWyIX9euCDIQ9IqWhUpRM qo4QdnKVImAzB42qGMpolyvYMibtZCvAZxRB6yAnl0DUIwM3IqMSeAgz0vJraHSIKPbm 89zw== X-Forwarded-Encrypted: i=1; AJvYcCUhgy0H1xdVloyhYkC7RSAWjKpo++j2MINnSzCR5e8Pal+Rm925KnwvAS2pXsm77zVf0SssRSqoZQ==@kvack.org X-Gm-Message-State: AOJu0YxMTas5pL06FbZbnwATxmfN2pL/QKZ59g9QFBCaMYCPkXloDdeb rMUqqHrZs1p1xZGvUPvgfDXT3kbkPT+NCpEASXK0oZw4v89C+c2T X-Google-Smtp-Source: AGHT+IFsRje/0urX0VCD2ctAQ/mPIn2BatWB9vkwQboQK13ENiIwcBVwwzcPWMMiHGBy1DHazHIZFw== X-Received: by 2002:a05:6a20:2d0b:b0:1cf:6533:5c82 with SMTP id adf61e73a8af0-1d30a94b2f5mr12037658637.26.1726952884555; Sat, 21 Sep 2024 14:08:04 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944b7cfa1sm11657785b3a.104.2024.09.21.14.08.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Sep 2024 14:08:03 -0700 (PDT) Message-ID: <73f9e6d7-f5c0-4cdc-a9c4-dde3e2fb057c@roeck-us.net> Date: Sat, 21 Sep 2024 14:08:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/7] kunit, slub: add test_kfree_rcu() and test_leak_destroy() To: Vlastimil Babka , KUnit Development , Brendan Higgins , David Gow Cc: "Paul E. McKenney" , Joel Fernandes , Josh Triplett , Boqun Feng , Christoph Lameter , David Rientjes , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Julia Lawall , Jakub Kicinski , "Jason A. Donenfeld" , "Uladzislau Rezki (Sony)" , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, Alexander Potapenko , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, Jann Horn , Mateusz Guzik References: <20240807-b4-slab-kfree_rcu-destroy-v2-0-ea79102f428c@suse.cz> <20240807-b4-slab-kfree_rcu-destroy-v2-7-ea79102f428c@suse.cz> <6fcb1252-7990-4f0d-8027-5e83f0fb9409@roeck-us.net> <07d5a214-a6c2-4444-8122-0a7b1cdd711f@suse.cz> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <07d5a214-a6c2-4444-8122-0a7b1cdd711f@suse.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: E1FE4140026 X-Stat-Signature: cy1fhmpue989k345r8qyntmkejw9dswa X-HE-Tag: 1726952885-185942 X-HE-Meta: U2FsdGVkX19v9DzlfISFQ+r+PJ7fl3xHCtqF1ayRBbgoPEqkOgkgLIbNSQuNh0D3PqA1JQiXGBlZeHGYsboDXn2arA07PwDNhPpsPm1HibAJKQ/0o2UDyICoFe07qcaIvMWWD6j+L7NSyKh0404+9KHLbZ2yhdnoe2GrABNDvkquczCRgV/+pDl7NU2gv247V0PtadhVlZAw1+f5N3SVpk5NnCU35OsS09/CbJe9uxeOY0sjdqXlhfMShCEaYeXa75aVBitxelCdqLpqOEgd2oC2S0AkHZDJ4Xqx7PLZVNpFe8fUYJZqrP0B28xb0fDBHSR+qL00zrxl/YLjzLLH9/AgLodNEdLjzfgBc8WkIjiVY8DruHJYjpTz6LXZDuEgV8jsYHbtYPweidSqslCrQGcU/KDr63ZY3ruHredmquyp+b1kgnk0HnpteMiwRBcBo3afdizvek5EhdPxoKSmo6ukVybzd7ac0vmS1YLucycPHV37Gfev1q97dYEL5JOqhkUuYJ4DtLWNMfFOyjDlzW9zYMmh9TxsS2JrPpFqQVMr31su8LG2b+pYGeQalF1g5iW2ydu9JaO3tUB4OUgkEBata8Ok9gZRevw7CONEVhLV/Xc84vLTimJIHIRjF1MCqq5qgLWZInt0YMJKpetPM+5nddfFgglpf6vboFzeJf4mTrA0isxzqV0MKm8r15sjfy1i7qoZmLLdvNF+sYX7ygElMX384glLZodXDqmlVn3eRr2vd1h8rw0nKbW4yED6sM0fXrADPMdmuCZk/8r/c7lzVf+qEcHPBlvDson7P2GfgL/UfeYRzCP6YZOELxENHh9O4xG+Q2dpX07dvn31QhUxLJ/Rh9kHsTKXoFKyNXk6fjPTNiVA6S3qyogFCt4S8m9prSLydM1Yb1CcdXVrqgYPuxvhk5PG5IfXPPTq4EHf2wOcJ3dDNJpoOOM+tZYbaohwFgJh5X4zncDlGP5 PBy+2PMi 08IAuaOzPU23SKkytPZYdkIe2NDkwwOff6HyGVY5RZL+mdOE4cNM2PyWBh8dbA6CKCLOqBU7oIUU0ElE/sxqaHQi5EtQQ0OSyUkET8PPpBhk+VnrGwf8XblfASmt41zDuk4glraWpU8d/y0UlR2ci+rYKRAjedAtiriOSbcQgGVMdOhYqRie+HvgctVaUmSCtRpFeNm/7sshhm239ziKdIQlzf+6DZCJYclda0ZkcsIJi2IK6ENHU/II434SWTAa/lravTuUsq5PuLJliKxjDsLBSZT/IaPZclwOBLugN0sqdXH8Rq/x5ga1H/z/dzFZvH9BikRyvo45TElZyqgv1dXFI89PgOBUSBHmO6HJfUGcoARKnUReiefTkt/pTTUpgJ9h0rK6ouYsJxAbKpUsBL+CVYI7z3jrpa2cDlk/VGpR63iR+4nT2v9QXQH9sK/JL1VAbaInqoDRnInhtCFTbMg3VKzE+TYe3XMARAB+44/s/APNpTmrWv+ftDiv+jrqV+F5UcQuA0GeqPd+dJtH9STgt2Aqeqs3hpNMJdMvxLlBuovfpNx3mH8CCHUXZrn6yOC6S2Dz/xQ2Nj9RIWOqXYQRnBbs5aSgKZqaL8vg3UrPcZ9N5jFajY6Sh7YusTWfU7uOL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/21/24 13:40, Vlastimil Babka wrote: > +CC kunit folks > > On 9/20/24 15:35, Guenter Roeck wrote: >> Hi, > > Hi, > >> On Wed, Aug 07, 2024 at 12:31:20PM +0200, Vlastimil Babka wrote: >>> Add a test that will create cache, allocate one object, kfree_rcu() it >>> and attempt to destroy it. As long as the usage of kvfree_rcu_barrier() >>> in kmem_cache_destroy() works correctly, there should be no warnings in >>> dmesg and the test should pass. >>> >>> Additionally add a test_leak_destroy() test that leaks an object on >>> purpose and verifies that kmem_cache_destroy() catches it. >>> >>> Signed-off-by: Vlastimil Babka >> >> This test case, when run, triggers a warning traceback. >> >> kmem_cache_destroy TestSlub_kfree_rcu: Slab cache still has objects when called from test_leak_destroy+0x70/0x11c >> WARNING: CPU: 0 PID: 715 at mm/slab_common.c:511 kmem_cache_destroy+0x1dc/0x1e4 > > Yes that should be suppressed like the other slub_kunit tests do. I have > assumed it's not that urgent because for example the KASAN kunit tests all > produce tons of warnings and thus assumed it's in some way acceptable for > kunit tests to do. > I have all tests which generate warning backtraces disabled. Trying to identify which warnings are noise and which warnings are on purpose doesn't scale, so it is all or nothing for me. I tried earlier to introduce a patch series which would enable selective backtrace suppression, but that died the death of architecture maintainers not caring and people demanding it to be perfect (meaning it only addressed WARNING: backtraces and not BUG: backtraces, and apparently that wasn't good enough). If the backtrace is intentional (and I think you are saying that it is), I'll simply disable the test. That may be a bit counter-productive, but there is really no alternative for me. >> That is, however, not the worst of it. It also causes boot stalls on >> several platforms and architectures (various arm platforms, arm64, >> loongarch, various ppc, and various x86_64). Reverting it fixes the >> problem. Bisect results are attached for reference. > > OK, this part is unexpected. I assume you have the test built-in and not a > module, otherwise it can't affect boot? And by stall you mean a delay or a Yes. > complete lockup? I've tried to reproduce that with virtme, but it seemed > fine, maybe it's .config specific? It is a complete lockup. > > I do wonder about the placement of the call of kunit_run_all_tests() from > kernel_init_freeable() as that's before a bunch of initialization finishes. > > For example, system_state = SYSTEM_RUNNING; and rcu_end_inkernel_boot() only > happens later in kernel_init(). I wouldn't be surprised if that means > calling kfree_rcu() or rcu_barrier() or kvfree_rcu_barrier() as part of the > slub tests is too early. > > Does the diff below fix the problem? Any advice from kunit folks? I could > perhaps possibly make the slab test module-only instead of tristate or do > some ifdef builtin on the problematic tests, but maybe it wouldn't be > necessary with kunit_run_all_tests() happening a bit later. > It does, at least based on my limited testing. However, given that the backtrace is apparently intentional, it doesn't really matter - I'll disable the test instead. Thanks, Guenter