From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAA99C6FD1D for ; Fri, 17 Mar 2023 04:11:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72377900003; Fri, 17 Mar 2023 00:11:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D436900002; Fri, 17 Mar 2023 00:11:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59C65900003; Fri, 17 Mar 2023 00:11:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4A95F900002 for ; Fri, 17 Mar 2023 00:11:13 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 14194121578 for ; Fri, 17 Mar 2023 04:11:13 +0000 (UTC) X-FDA: 80577065226.17.64E4B14 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf30.hostedemail.com (Postfix) with ESMTP id A24BE80015 for ; Fri, 17 Mar 2023 04:11:10 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="b2V+k/Dc"; spf=pass (imf30.hostedemail.com: domain of quic_zhenhuah@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_zhenhuah@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679026270; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s+1pbwr/Cc4LTRim75vnmUoKCUh3reZCLwfHbyYDJZ4=; b=LZsLAVGq5gqvfvXSaG6zomYSy5W/U+xeyxfG+G2nLDpckwhkd4TQtBxChLE86jKUT96ePG kmjNyu68zM/DQGw0txkJvDikzUzt9n349XOUiTsXp40tWlPxB/N02zIkrPCdGcyBIWA3iH woRovYPjlh9X1KBmVmqssSc0xookfb8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="b2V+k/Dc"; spf=pass (imf30.hostedemail.com: domain of quic_zhenhuah@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_zhenhuah@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679026270; a=rsa-sha256; cv=none; b=FE+ZusqX5mcBS9L/5fRbPzJN+xUZS8X3q+hkYBuZzM5nrjNxgN39rsWlxjTYqnhxoAuteZ i9isP7io2TsOk1miNG9snpwNbNyLgUM3TTMrcDFot9btB5ybGC5LY2wMc+l48rqT56A00m B2shO6E6H2P8XeGVhFEVPvfzpUuiUvs= Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32H3dhml021094; Fri, 17 Mar 2023 04:10:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=s+1pbwr/Cc4LTRim75vnmUoKCUh3reZCLwfHbyYDJZ4=; b=b2V+k/DcAVByPYzpxHbdql074vNFYtsVBPEo6ImVx9VXOiMreGKCdeuhI9x85lhsJzDm zcKAD2PdH6OSoGfVKJi/ajl24LcMwM1ir7wxX+I0tUuKoBegwPoexKZpBOHUJ+7Qu8Gm mAJ7+byAOEPs07rE2vq9a7fmWzyfERLWdkua6+ATsogSdSEyxFnwre/EHgJyvBdcnwl0 42U8wDZ8dwzjft0RbhhlCGhiPP2+CeCEOkfWI4Tkgeb588ARUdvd6lJgNpn6KS16eV9R woBT6BASUl42KObnQJqx9L/yR14mO/FqM9JN8/YL3QJGyDWJ6Ee/GGZUlYzuCxG1fF+O jg== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pc624hn11-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Mar 2023 04:10:52 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 32H4Apq3005910 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Mar 2023 04:10:51 GMT Received: from [10.253.39.45] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 16 Mar 2023 21:10:47 -0700 Message-ID: <73f9140a-428c-14da-9695-dd0d39e0248e@quicinc.com> Date: Fri, 17 Mar 2023 12:10:44 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v11] mm,kfence: decouple kfence from page granularity mapping judgement Content-Language: en-US To: Marco Elver CC: , , , , , , , , , , , , , , , References: <1678979429-25815-1-git-send-email-quic_zhenhuah@quicinc.com> From: Zhenhua Huang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 1oupcNSA8kTZtaJPyd74k4xNYxU5CQDV X-Proofpoint-ORIG-GUID: 1oupcNSA8kTZtaJPyd74k4xNYxU5CQDV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-17_01,2023-03-16_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 adultscore=0 mlxlogscore=999 priorityscore=1501 spamscore=0 suspectscore=0 impostorscore=0 mlxscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303170024 X-Stat-Signature: rt78aiwzkhhjjs3mcfzcnc3fsdfby7uk X-Rspam-User: X-Rspamd-Queue-Id: A24BE80015 X-Rspamd-Server: rspam06 X-HE-Tag: 1679026270-486090 X-HE-Meta: U2FsdGVkX1/PoAN/0flfJ+L0pXeHPjyTiHRxP/IW7tYbFuHhml7TgmYjedHnRB15wvpUigsogjL1URy3Pb8NsEEXVn32tOqStCcPlpGtFgqAuLE/pxdef5gjtXzExje8Hnb5RUzSJOLaNLdGtTtghwcwfpC448bkvjt83CmE5I7RiTbP9Ut1YuOivyomPhsUFCFr2vvoT1G6ykhcg8fTgSnqbpu8O+5U3Jmi0hHz0QzpwpQsb18MiUotZobG5LGjpPbfVD4iiLZ6uB9Wj6R8P2bW6ps9/vLYuPiWq4l++mYbbbRTMKqwp6aSXHg4HM7FJvZpMQexBbv9p+rBEtnSt4K8ru2wtpwX+5xxInDrzFot5D5PKlWcnlzFCJgMkrVN42vBLaKDcjTFAnNQJViFxQpNpA1TB3KCVyPmWymdI8nwI3XHveMpzEgK2okhGOD7aNP/ICR0RGaO/WSSZR/OaNIi9ffXWUWyxw/lVlCwb2ZGB5GpaIRy22vEoJK+EdKduwyWDjKaLxRcbVlj6zGtT26e6/X7rgHnUbqxlXPi7KVt+4OLpsPTPf0nbp3ZBxQx1S35zwfBzn0vWfVN3aPnR0XWEmHM/wVMsn2r8gom5SAXbemJA8mBkhF1zyxmc5eECzhYKrUNsIYFAY8FUyK02RW2YQGzzXfQDr5vMKPkIebD8r5e905FLNZ3JydnivXM2B9/Yo+iVIOtlRoTxt5/fJW2p5PwyZwgsJUfHAVlRHaLAGpxxAO36FoeipQcXv5wmFGGMR9+p4RKScLzqyHFrL4TIhLtlLV50m8yqrPWuE7aN3bQNDOM4/x9xoDG2DXico8bJHNTinjnuqsE2jI/i58hYxigFpenfgJEqrHvHTXoEAoWJKg+onKCftFtWXYnwqTghyluyyfiG7+Vq0QtsRE3MdUoMf9YJEUZ8tzVhOJDORzVvsUOzWSyCOfEf1N1IPPHGUhVf23/ZOX07/J kU/NeFSP ZHi33Lb3TIVdq1iotEOf2HE3NSFXBZ8llrIGZgLfM1Mz73ZgpeT6FtRB2OAzxREHYNRc317a+lzjX4REqNcNnqhqOHC+S1FDEKTa9MKLpdn24JUgAH4ooi/WpQnvF3wkaqI3B8rGVHcLqCk7taor69z3yZfjwOdcpWgqYQL0J/M2EYgdQE52ShkV1FoayWr69bL6anYYpQTDNIa9zZu/J/U+EsqjK4icO8+SFoumi/nHBicjIPDyS646jGKSDQmmTI89IpqAoJ1qgaSyoeoh0j+rXnIRH0/jtbiNKl2rQ27RIXEjKAmiU+1j27FJZOE12Ga8D2Qbom6O55FT8EeRKre0467K3ioQqZKSyzFnS+GpORX7u1yzpBYNEZu3mzF02gq5id1VtgQl5JTxTF7Jt3kx21mpLc4Fdjbhp+qbLYMNypYcV8eTsOSL+CxTYnXKK8Yxv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/3/17 5:43, Marco Elver wrote: > On Thu, 16 Mar 2023 at 16:10, Zhenhua Huang wrote: >> >> Kfence only needs its pool to be mapped as page granularity, if it is >> inited early. Previous judgement was a bit over protected. From [1], Mark >> suggested to "just map the KFENCE region a page granularity". So I >> decouple it from judgement and do page granularity mapping for kfence >> pool only. Need to be noticed that late init of kfence pool still requires >> page granularity mapping. >> >> Page granularity mapping in theory cost more(2M per 1GB) memory on arm64 >> platform. Like what I've tested on QEMU(emulated 1GB RAM) with >> gki_defconfig, also turning off rodata protection: >> Before: >> [root@liebao ]# cat /proc/meminfo >> MemTotal: 999484 kB >> After: >> [root@liebao ]# cat /proc/meminfo >> MemTotal: 1001480 kB >> >> To implement this, also relocate the kfence pool allocation before the >> linear mapping setting up, arm64_kfence_alloc_pool is to allocate phys >> addr, __kfence_pool is to be set after linear mapping set up. >> >> LINK: [1] https://lore.kernel.org/linux-arm-kernel/Y+IsdrvDNILA59UN@FVFF77S0Q05N/ >> Suggested-by: Mark Rutland >> Signed-off-by: Zhenhua Huang >> Reviewed-by: Kefeng Wang > > Reviewed-by: Marco Elver > > One question: what happens if the page-granular direct map is > requested either way, is there any downside with this patch? Does it > mean map_mem() just does a little extra work it shouldn't have? (Not > saying that's a problem, just trying to ask you to double-check it's > ok.) > Yeah.. I think so Marco. Seems the extra work in map_mem() is we did judgement there.. Other side is we added one early param. > However, please also wait for an arm64 maintainer to have a look. I'm > assuming that because it touches mostly arm64 code, this patch ought > to go through the arm64 tree? Yeah, sure. We will wait for arm64 maintainers' comments. Thanks, Zhenhua > > Thanks, > -- Marco