From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE5F2C25B76 for ; Sat, 1 Jun 2024 06:47:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C2636B00B4; Sat, 1 Jun 2024 02:47:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 797CC6B00B6; Sat, 1 Jun 2024 02:47:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 686926B00B7; Sat, 1 Jun 2024 02:47:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4B8EA6B00B4 for ; Sat, 1 Jun 2024 02:47:54 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C043EA306F for ; Sat, 1 Jun 2024 06:47:53 +0000 (UTC) X-FDA: 82181389626.03.BE130CA Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) by imf10.hostedemail.com (Postfix) with ESMTP id ADEBAC000B for ; Sat, 1 Jun 2024 06:47:51 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=SnMlZvS7; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717224471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sjLZZRzBZcTCQY3kC3rZ1Hok+tlDm5Px6KNoO2+Q8ls=; b=fe4WpQ1aHNphiYOOk3xVa2vVyCeGQn4z/e7tWYEjbFkunkdSP/j5ATe19KPAHd5WdHHKJJ lm3TCpKRQFMGKuT9/nXxtfEZeA/Zb4HcyactWtt102HXYZYgjvKXSmlgIDGJvZl3YJ8md6 d+oqmgri2M1ck6y6q+FteMpr2eF66zg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=SnMlZvS7; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717224471; a=rsa-sha256; cv=none; b=amdXrgvTO5bk/tKEpvQNSc95x7YrHBnehEMbReUAFHrJlZsp+WlWbjFcjvTWtxIqV6gqGu 2Kj/+zLabVprmGz4YtGIOAvHAgh1wM68qTx9mbehgZrFXWwISvd9QsCD7Q5x+Q2U8RYi4B EOLlvSPwc92p/+r51PVxSk3ezPnEsdQ= X-Envelope-To: roman.gushchin@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717224470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sjLZZRzBZcTCQY3kC3rZ1Hok+tlDm5Px6KNoO2+Q8ls=; b=SnMlZvS7KOj0xhhJCHn+El31RwcaODxWUU61//d2H0RnO5zEf9Rr+PlMnX0X+904K+YKmD zHENlx9nL4F1M0jXyshhqT9bVFzX3OW+KNrPt9SoiylPJcOcVnanGG/MvHVmvYfyd5uny0 DRPEpwoxKj8nHoMt35aL3o1778gm39M= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: willy@infradead.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Fri, 31 May 2024 23:47:45 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , Muchun Song , Johannes Weiner , Michal Hocko , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 08/14] mm: memcg: move cgroup v1 oom handling code into memcontrol-v1.c Message-ID: <73dfsckpotrrgmq3zsatinqwkfwpbid3eniegigonbsnz4ewl7@ywuahcwkcl3r> References: <20240528202101.3099300-1-roman.gushchin@linux.dev> <20240528202101.3099300-9-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528202101.3099300-9-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: ADEBAC000B X-Stat-Signature: qiqmc15txuqj93n8a3j4xoo5xzzdcoj7 X-HE-Tag: 1717224471-251182 X-HE-Meta: U2FsdGVkX1/PQtoiBXqR6gRRL4duhzjivGll9O2Uim36BzEOkuLh3PXZik04/3UWVk2AZuUb+BNIzRueWWfOD3y1AAJCbr83WU8r2INVCGOoeo5NV9sGc/5+kaWUnslMBuU5db+SCMGPos2QdPGC2zv8XyzvBW8RwPFrdoG2twOo0cTbVOVvAbOoGCLIcfAT6tynBBVamzAfQ8HgwYy4dXwDmwQX3QUC8434yAkGaBXchhWJxNHpMzKwO8k2ChBQRw+MzUKaXh8mYhFgYxGESx99PzsfWHN1xTS7wmdohZLfUvLX/WDm+qTin99Potwjuw76fcmD3gnVxNfsEFV2hBgJ4Z5WFNui0aKlA5s4m/NB1WvX9coK/DnhikJfbyFLYni1j6By8WdnK4Dz6WW4oOsjfdd4M7BlDCCmr6bXvc3NNvrHA6IXaznv95znlFMLMmzNou/c/7Wzg85nLE1KO+RIROy1LODTSCjAjUiwQXbtLGD4LiANa9suOIAtfTOzUq33LyMhCC/HhHyf/KQBKVxaggEfQ8pjJ/AqDypkKcpI3iaTh1CT2mkDJMtpDBh6hfKJPuB/YmZzXLfkSUU39rKftmH1hPGq3PAV6xlUN5NFGS1CA8BxUCwT/rQqT42twEiB5IIgDzLO4ZT/sKCjIbkbxmNfiV/Lf+2Ridru0k2dt1qnvsJYkNJQ6msr8Eo73DveWZiCKSRF7mGZeBiRKWOq7A2cDdx5Hnc5C+yjHdxI7dP04JnCVVDu9lgZFo2FwMErPH1nwim/2YJVljIJ2qiuDWonTGG8AJArvTWhuRvRJVpOB/saA6+vGX3eUVdSJqtzLrV5H0i3fhRz4v7/FAOdoTLOaevyvSfBw1FuPO6A3YXkLNoDifUYLRLB/K7cWBuUTHJQlqRlZciqq1UKG76xjJE97/kYhu/WzVousqt/3FpJDURuGAWiPiWJM7SM7Q9A6+kJgUva/67GndX MmhNvrGi ZNMyA0I6eRUFxqTiyO9aOWmp/2ID1yRbmn/Ug4S2+Wcle5PWJgWTG6hUfG+rwnJrR6YTB6p2Uuxl6IzGLvzmIqpHFKw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 01:21:00PM GMT, Roman Gushchin wrote: > Cgroup v1 supports a complicated OOM handling in userspace mechanism, > which is not supported by cgroup v2. Let's move the corresponding code > into memcontrol-v1.c. > > Aside from mechanical code movement this patch introduces two new > functions: memcg1_oom_prepare() and memcg1_oom_finish(). > Those are implementing cgroup v1-specific parts of the common memcg > OOM handling path. > > Signed-off-by: Roman Gushchin Acked-by: Shakeel Butt