From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E93DC54E68 for ; Thu, 21 Mar 2024 13:10:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C99616B0087; Thu, 21 Mar 2024 09:10:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4A0E6B0088; Thu, 21 Mar 2024 09:10:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B38446B0089; Thu, 21 Mar 2024 09:10:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A16556B0087 for ; Thu, 21 Mar 2024 09:10:43 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 413C712163D for ; Thu, 21 Mar 2024 13:10:43 +0000 (UTC) X-FDA: 81921080766.10.32DE094 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf30.hostedemail.com (Postfix) with ESMTP id E540480029 for ; Thu, 21 Mar 2024 13:10:38 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711026640; a=rsa-sha256; cv=none; b=Arz+lO1JvHipP9GW42j/KAb4zDQTNlojA0SQt4nXPB+FdczNZOiLIThe51Hx7qd5maa+oP hhSBd0ZN1bZEhhn+tS4WupcfstgsznFbUp5WLxGbI9zFFy1R79uecgevvgDf6LLMIE5fep NNeVbnQiGpchirG/ZxNXCJC6Nbi0+m4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711026640; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+jr4Jt2Prpm++1Sj2BdSW3mxmmn1GQbuGmA+85Qk+zY=; b=ccsI2lF77vxKYXhOKg7orP4E0jo02FIj0atwlrLCvK1br+BOAnwRNb3SI/YJhXAUuLQoQU cJ+/o5WXK3RS/AaveAc/OoACtd9jlPwj84TarYEZm7T/AGS8qSWZtQ0cuyIBTds8VjefBB ga5c/OldtZrKLFPQ3CdDzaU+APGuwWU= Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4V0m5L2c7KzbdSk; Thu, 21 Mar 2024 21:09:42 +0800 (CST) Received: from dggpeml500023.china.huawei.com (unknown [7.185.36.114]) by mail.maildlp.com (Postfix) with ESMTPS id 8C620140FEA; Thu, 21 Mar 2024 21:10:31 +0800 (CST) Received: from [10.67.110.112] (10.67.110.112) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 21 Mar 2024 21:10:31 +0800 Message-ID: <73ddccdf-9e4a-9fbd-893a-ab95a62fad44@huawei.com> Date: Thu, 21 Mar 2024 21:10:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH -next] mm/slub: remove dummy slabinfo functions Content-Language: en-US To: "Song, Xiongwei" , Xiu Jianfeng , "cl@linux.com" , "penberg@kernel.org" , "rientjes@google.com" , "iamjoonsoo.kim@lge.com" , "akpm@linux-foundation.org" , "vbabka@suse.cz" , "roman.gushchin@linux.dev" , "42.hyeyoo@gmail.com" <42.hyeyoo@gmail.com> CC: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" References: <20240321084415.265643-1-xiujianfeng@huaweicloud.com> From: xiujianfeng In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.110.112] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500023.china.huawei.com (7.185.36.114) X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E540480029 X-Stat-Signature: ixj4g1gphjpzjsmsa6op6yns81ymr9s7 X-HE-Tag: 1711026638-485791 X-HE-Meta: U2FsdGVkX1+euwEhCZ13XXxIdjUiG5o7IKK3dYtE79DaKH+Bf798E3plGTYN/9NQpzXjx7uCq8omYtltMkG6Mu8LckpYOxcToxP/Pr/b73wxahF4xH0mwODF++MciU18HSSdmVJ1wVH80sVBXuDqW1hhkuI4GpW+sE4PQi870L/vTgkaMb49jLcnAbKhOa1VD531rTYKoRrWdRqcTj1oxP7Cj8UFcsBb4RXDlwhnkzSk71fZqe9doViZAzzHR7f/K9/u86+66+xXCPuZWXMXaSrUiUkCPizlykz8htCE0098LCS6ThNQv0olkEuwUe+V5wYFY+jXxdob59xvS6KpBjPKt+8CG0sxY5rH9IIfEGVoZa9Z0CuJGWCm0ohy8/lhGT+TaJ8dmdV+wWhpS78m65Rs8mdpK1CgD2qfC/GH9C7Elxc2khi/Xk7NXEfhbjgcY0y2HCQRKonFStisT/M0j2JBvZcjMjvli0XWEadQi5PMuwvI4McbZLpyhPPR8IeZyAlLeFQeaIzIa/SLNKxtbAVLj38mCIYmkVmbSJei5bkaeoMW6HXs9Uc6B+pvB551fQdo5hqfMA9kSF1snDZU5YzMUgTwvIWSuHIT+aXp7+GEsz1jahdNho1b5W8+7XaBTF1qBTjy8UNcFFhIwf02/E/KG2HqUfYNMGOtanvqhCecUTZZtJYAz+1KzHLN/eupg14BcWkRU6wBVn063mog48eEPEIXaFqse9kcxC0MDk1hEKsEDBJZ4J0x1csaDPa4aUaQwxHDI+CvJOCpvaL/lCigencwciw1MhtEKexzFEoZ9Rz9bjEdsFozz66d/fsJ6fL8wsHqvI4qCUl4rLl5v1nAorTh6ioeUFjAVdJdMFACg1dA9o1Rb0UUlvLyvbpCYdqSGmks0woDKGFfu69oQHxjHuSiWqwW9AhxenDZLpYIGxqMW5yrC71Ls1H6lYSejBJ8pC2fgXm6SefH3RT CojnUvEM 2wHKEacB5jVczEk91zqtPMcCgLA6iSipoxkza+uWU81KkPNhBrrn0TbS3BRkzRxo6T3wTO0CVml2kdoo9RxrpNC7sVhixFFx5w3asov2dxA7lQHVlmq3xaCLMWUh48WyMnMVHz1JC8tq34YfwGms/BhOHzg+w8mriXcPXlH2vclDvvlUTPyrXWAdTrZl0aERomvAH4EMQz7UBKE9NvzAp6FTuPxm4EfJYw1Zj9jKeCajKa2z/a7iZBO0Q54nOIl5CvKOnLn+5BxagV28= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On 2024/3/21 20:20, Song, Xiongwei wrote: > > >> From: Xiu Jianfeng >> >> Slab has been removed since 6.5, so there is no other versions of > > Removed since 6.8. The changes looks good. Yes, thanks for correcting! > > Regards, > Xiongwei > >> slabinfo_show_stats() and slabinfo_write(), then we can remove these >> two dummy functions. >> >> Signed-off-by: Xiu Jianfeng >> --- >> mm/slab.h | 3 --- >> mm/slab_common.c | 2 -- >> mm/slub.c | 10 ---------- >> 3 files changed, 15 deletions(-) >> >> diff --git a/mm/slab.h b/mm/slab.h >> index d2bc9b191222..78e205b46e19 100644 >> --- a/mm/slab.h >> +++ b/mm/slab.h >> @@ -496,9 +496,6 @@ struct slabinfo { >> }; >> >> void get_slabinfo(struct kmem_cache *s, struct slabinfo *sinfo); >> -void slabinfo_show_stats(struct seq_file *m, struct kmem_cache *s); >> -ssize_t slabinfo_write(struct file *file, const char __user *buffer, >> - size_t count, loff_t *ppos); >> >> #ifdef CONFIG_SLUB_DEBUG >> #ifdef CONFIG_SLUB_DEBUG_ON >> diff --git a/mm/slab_common.c b/mm/slab_common.c >> index f5234672f03c..67c03d6bd26c 100644 >> --- a/mm/slab_common.c >> +++ b/mm/slab_common.c >> @@ -1078,7 +1078,6 @@ static void cache_show(struct kmem_cache *s, struct seq_file *m) >> sinfo.limit, sinfo.batchcount, sinfo.shared); >> seq_printf(m, " : slabdata %6lu %6lu %6lu", >> sinfo.active_slabs, sinfo.num_slabs, sinfo.shared_avail); >> - slabinfo_show_stats(m, s); >> seq_putc(m, '\n'); >> } >> >> @@ -1155,7 +1154,6 @@ static const struct proc_ops slabinfo_proc_ops = { >> .proc_flags = PROC_ENTRY_PERMANENT, >> .proc_open = slabinfo_open, >> .proc_read = seq_read, >> - .proc_write = slabinfo_write, >> .proc_lseek = seq_lseek, >> .proc_release = seq_release, >> }; >> diff --git a/mm/slub.c b/mm/slub.c >> index 1bb2a93cf7b6..cc7e68fbdbba 100644 >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -7099,14 +7099,4 @@ void get_slabinfo(struct kmem_cache *s, struct slabinfo *sinfo) >> sinfo->objects_per_slab = oo_objects(s->oo); >> sinfo->cache_order = oo_order(s->oo); >> } >> - >> -void slabinfo_show_stats(struct seq_file *m, struct kmem_cache *s) >> -{ >> -} >> - >> -ssize_t slabinfo_write(struct file *file, const char __user *buffer, >> - size_t count, loff_t *ppos) >> -{ >> - return -EIO; >> -} >> #endif /* CONFIG_SLUB_DEBUG */ >> -- >> 2.34.1 >> >