From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82CF1D5CCAC for ; Thu, 31 Oct 2024 12:32:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6F1F6B0085; Thu, 31 Oct 2024 08:32:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF8166B0088; Thu, 31 Oct 2024 08:32:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B23DF6B008C; Thu, 31 Oct 2024 08:32:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9134C6B0085 for ; Thu, 31 Oct 2024 08:32:16 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 45626141570 for ; Thu, 31 Oct 2024 12:32:16 +0000 (UTC) X-FDA: 82733834190.21.723FF2E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 8E65240022 for ; Thu, 31 Oct 2024 12:31:39 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FazrPV9m; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730377774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uKrPAKxKq1Jx7vedNmeCC6agMwFMSyba5+2s6PfI3BE=; b=Yco2WTcO4VLeY2RlKMNVrFKhfyfj28e3v9Nlr40b0vPyxJcBdabKgaGh8pTswoygTLonto cvQMbPTb/NFXIUu+KPBjqclIFGl1srw+CjluGlNkAhpW5pDfkCGl83Dl+Fre+LITu7RI/B XPcm4kegX33JRvmUTFjdCLzeLzUZd3I= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FazrPV9m; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730377774; a=rsa-sha256; cv=none; b=aatPdp2X7+7pgGhBlbbDmI1leNJwqMFZGYOxBpFYNchARxY5CqyI2rCN1wmOPCnmIL8tkz ThYjQvcDpPJGJZWKU5bGMwMmpej9L5oew9ltEWbXOnKN7F9Gr8UzSAFmssePipzKoD4smN BBNGvBIP5g+xkPW5gZslshtKs1JtiGA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730377933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uKrPAKxKq1Jx7vedNmeCC6agMwFMSyba5+2s6PfI3BE=; b=FazrPV9mIDDthsEUXgrUat5ZvJ0A1l5AHBL+sQXsmIus62eCF5mhDExtpxIjqLlqaEk0ql mqyeDXT7ulDP8BkTjNbhq51Z717sjHtilNDaLLLtyUowxrs+Tw8xK0h1sIRMasuavyT+No CE2eRr7cInk0aCpWrguDivJEkxAsGTU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-vMyHPi-FOGidszb_JAzb9w-1; Thu, 31 Oct 2024 08:32:11 -0400 X-MC-Unique: vMyHPi-FOGidszb_JAzb9w-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-37d533a484aso1020339f8f.0 for ; Thu, 31 Oct 2024 05:32:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730377931; x=1730982731; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=uKrPAKxKq1Jx7vedNmeCC6agMwFMSyba5+2s6PfI3BE=; b=V2qUfnDS4ynaNo6keyGonLF5IvLq87sDDXT1OdgbMs6HuasPj04qiARui4n+F24dxh +lbiO0bEibf9B0YDk3EG64Z4ANVXA8m2nGslAVnbXRFUTrfAezKhwNl9wKvW8/uCt9lK dckagTdcL2Je7eMR7Wmw/+iITVjshYgWpAkN18sJbFdKOOcz1ZxU8hLlRhvx+eR0uSRT keC7UezEym8SDFL8hwGVYNpUlujYVt9//zSVy3MmiJ0ErFlRxZw0fwVdOi1wX7Ev3YdX bRJHDOwu/F0gvlkyfjbSdI0dC6/JAMb8SRicNF6YZpUkSAloZuxwjGmXu+xDI4SMh6ff V70A== X-Gm-Message-State: AOJu0Yy63ln+lsSvdZc0FfHddsp2yOole2mce/5E1syvK14TWFwPIkMT DXCzWZBDkkiLxQfTlY1CARNFCyENq0MQXQ7g13283ClalH+SH4BpyI4CJLorx3h9+s3LlQKY1oK hcaOAFol5Eg+JA0vT2d0Bj4V8o6KX0oymeitaAvjV//78BhGH X-Received: by 2002:a5d:59a5:0:b0:37d:3b31:7a9d with SMTP id ffacd0b85a97d-381c14bb067mr1633449f8f.23.1730377930705; Thu, 31 Oct 2024 05:32:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEu82J0PIR+pp4nUH/6upDWBeLgmtjty7qYAPHYGLGOrQCvA2FcAzeK4yv20KNlMVeyZpEHrw== X-Received: by 2002:a5d:59a5:0:b0:37d:3b31:7a9d with SMTP id ffacd0b85a97d-381c14bb067mr1633399f8f.23.1730377930212; Thu, 31 Oct 2024 05:32:10 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:ed00:7ddf:1ea9:4f7a:91fe? (p200300cbc70aed007ddf1ea94f7a91fe.dip0.t-ipconnect.de. [2003:cb:c70a:ed00:7ddf:1ea9:4f7a:91fe]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c113e595sm1994177f8f.77.2024.10.31.05.32.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Oct 2024 05:32:09 -0700 (PDT) Message-ID: <73d19983-b97c-49fc-be9e-89728626dbed@redhat.com> Date: Thu, 31 Oct 2024 13:32:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] mm: shmem: control THP support through the kernel command line To: =?UTF-8?Q?Ma=C3=ADra_Canal?= , Jonathan Corbet , Andrew Morton , Hugh Dickins , Barry Song , Ryan Roberts , Baolin Wang , Lance Yang Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com References: <20241030130308.1066299-1-mcanal@igalia.com> <20241030130308.1066299-3-mcanal@igalia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241030130308.1066299-3-mcanal@igalia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8E65240022 X-Stat-Signature: uunkr5ai63orcjr7j65nk6j4ytaddeyr X-Rspam-User: X-HE-Tag: 1730377899-281322 X-HE-Meta: U2FsdGVkX19LhKKw3sAx6GkiX+O1HKc0ZUFzg0NlTHQ4K0WzBZPaBCNEFYm7iLK8fGVAJbo3PmYZWSAFEnadg4AuDo06ZGNuP7BfHIAU8FLV0QF/Dmo8Lt0f7AKnZFE/zjCvKNHSNJZlFEd0TS0o0HDtRg22Ow+0lZqD1CU4s2xQmq70BxwACmHt3SSH1LAJ53rUcEMTCniIgvFCWtXLpTJc4ph2l9CFMCBr1CzW7QGblF2ooCaxkKkzqQYfKsKAnqeNBU5xfi+HSCEpcS7kToN1B8HLxYg9h6+25E1lRF4Ag9BLImYY2xOqMP0tZdp/UuMyOEnQgJnOFOceEwTFoC+pBtwGn3BJtKhjYyMWp0yBACP0uValSVlPYcYlpM/Am/lNU2ogtV6rxW1mNhu3NSxzLVoFOxlp41EMN6gRIplm4HLSqCp7092UkQ0Bm+tkfpsmi6UYinFA4/xoYn/bnWvwcGbfzMImq5M3ekj9tZoeZ/zHjSpoHdsBRYdPxqCWLcjTMp2nFD703F1NcmtpamF1goFeL+maVclTTpk1XIdmxuyIH6VoErHs97kpjWHNOOxmf2vblYe7HZORJDYpTQLC8Ax1ovgS3IVrXsyWCVcyeGQYbD5OzRIURpKnUIHP7tOkiBXCP1GRzrNHS1oiPpiwV4oJirxsdCy5o014ady1abtwU1WOY6N67Q/JJ94cg43DMkw5Zhlx9fuGp5iYF3NNGyD8tlG2SVfNBpbLQ+R/8bX8aiIrk9CKFbZ2L+GKzaBrVEDdmFe59DCu4Qk6GbtXxfQx9cWCvesP0Wap7I5h78UwK23d9EOoR8rblT8vK57cDIteybW//OWhdLV6pOoVX0JGvp8WPTPb+iuP4iaOVsrSJn2nYvXe7RzOkb41rZYMYdjAExBydlEaAmJZrqY9ud0r1RDqykIcTlrAKbZbalubEYUqd3x7r464btcsrGgzNH0AozDMtvy7sag hgfaa44+ VZz+Sh2MflrLBG5SD17aCztR2Y1QdJLX7dSpq7tDqq28BY7i40sMp8f7F5VdLSLcxVjd0Dg9mfhbKsH5C5CeKiAkiTwk+Pjsk8mSsel9HnOBc7uDGp785NkiJdGNnRACr2hDIPQT0wvNauq3BckRRGviZYkTzhoP54V+LrT0xugbmKX+VF2hCRuDdF8JzsTLeBA8PVEon/XlbD3viHjyXToxpUml7E7esSetn3oL/TrJ5aB13tgVyJJoJMqm2i7PmqqARfJfiqNyEgxzAFezAFIIMPFasVeffLmXew8BaElx6R4pvdutPQ4VeRMRWdH/m3irlCSAEOVxCufKwwrEC+TJGINAfhyYPx5fKpE8wokBa6P6/wsuNHTJWp99ChK9iWr/J7/sE5jX3QWH1A6F1y+Fa5I8ZkkMdmBuc9ICh0PpWk5Lyd4Fg4RRNm2z1oMNyAihwDGIVrYBRsRDpzrcMS/O14Kvf1DUZPmdVG1YiPHd9o5QZHFalQ9aZI3Pyzb9CQoup X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.10.24 13:58, Maíra Canal wrote: > Add a new kernel command line to control the hugepage allocation policy > for the internal shmem mount, ``transparent_hugepage_shmem``. The > parameter is similar to ``transparent_hugepage`` and has the following > format: > > transparent_hugepage_shmem= > > where ```` is one of the seven valid policies available for > shmem. > > By configuring the default hugepage allocation policy for the internal > shmem mount, applications that use shmem, such as the DRM GEM objects, > can take advantage of mTHP before it's been configured through sysfs. > > Signed-off-by: Maíra Canal > --- > .../admin-guide/kernel-parameters.txt | 7 ++ > Documentation/admin-guide/mm/transhuge.rst | 6 ++ > mm/shmem.c | 72 +++++++++++++------ > 3 files changed, 62 insertions(+), 23 deletions(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index 1666576acc0e..acabb04d0dd4 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -6926,6 +6926,13 @@ > See Documentation/admin-guide/mm/transhuge.rst > for more details. > > + transparent_hugepage_shmem= [KNL] > + Format: [always|within_size|advise|never|deny|force] > + Can be used to control the hugepage allocation policy for > + the internal shmem mount. > + See Documentation/admin-guide/mm/transhuge.rst > + for more details. > + LGTM, and it's consistent with the parameter for anon. Acked-by: David Hildenbrand -- Cheers, David / dhildenb