From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7686C3DA4A for ; Mon, 5 Aug 2024 09:00:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E3C76B007B; Mon, 5 Aug 2024 05:00:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 194246B0082; Mon, 5 Aug 2024 05:00:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0349F6B0085; Mon, 5 Aug 2024 05:00:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DBC1E6B007B for ; Mon, 5 Aug 2024 05:00:20 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 61E86C1BB0 for ; Mon, 5 Aug 2024 09:00:20 +0000 (UTC) X-FDA: 82417595400.19.4CC6106 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id E591810002E for ; Mon, 5 Aug 2024 09:00:17 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JgBNu8Sv; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722848356; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8HQitpbMW2ypbNGKvmYtYs01w+MzFX+wf5SUicYWuc4=; b=tRLIAwAgAk4FYFJDrHirGavii4jgxNszBWddjmceSmc9Ay2CXnSVtFxJTGBAyzScJB/arI Y3gZRKSICztT/+td4gIyWAWpcU686GkmO7R9MMYd8tOXhxeIPucBmC8JYe/IFv/JW0PIgr ItOqqQBo2ex0mgRwexdfKLwwxU4jsa0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722848356; a=rsa-sha256; cv=none; b=eqWQraJMI5oPFqgbkhSM/+YhWSmk5NM5W5+gRLnq8ZWxARqRSfESFnfbDkWU/7MqnDHv69 pkT6joa+kEuhtYJiwu9Wcwoz+07kZl6aXZ/pOJFW3qqqh2eHtoKgGI32MpIb5w8cJimgFw 32miGpI1HrFreWDUHj5Dg1kAiy75r6k= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JgBNu8Sv; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722848417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8HQitpbMW2ypbNGKvmYtYs01w+MzFX+wf5SUicYWuc4=; b=JgBNu8Sv3XCw+vXzEicLP1PV4xapjq/th04Usz7pf6GEbywBqkNPali+MzufkmNHCCfAW9 URuYDcbk/n6G8BHtEgWNV+qbXngJ2KLWlmKAB3kMr4dumeHmhIKTkvDfgvIXz7vT6YyuOv pTTArwfZ3WIaUKIgG7/lUQsXjzs1Xb8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-WLAWWWIkNMWkY2alvTi_PA-1; Mon, 05 Aug 2024 05:00:15 -0400 X-MC-Unique: WLAWWWIkNMWkY2alvTi_PA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4282164fcbcso57004985e9.2 for ; Mon, 05 Aug 2024 02:00:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722848414; x=1723453214; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=8HQitpbMW2ypbNGKvmYtYs01w+MzFX+wf5SUicYWuc4=; b=hZsjwYCLrnT31VY3xEZ/3ThoD4bYCUZKvQP/srR9Jqp6OuFXBfzqvuy7eJdcaccgwt YoMsOkBGj/uSKBUb33ypzM20aUWYuV9pc8JCzKjLpnJ1rhGKq/39WM2gn2/iPxjqmQaM 9MDixOhzq5RCOcpWMa7BodyF2IgpSzDlR0b/+HtUK9oufiq6FbRSllDzZ7mweejA690Q MgtSGm3sznnErRAa9sGuMBiMApd48+dWcZp6aYxE7+dM8K4FKYe3kF7r441/TzHV4frw nE73aSTJAtsGGAQyz4ANcx7DsSWgHXs08MmB1fsCqymaTDaYZhg5uVBqx2keIGjCliAv Ut1g== X-Forwarded-Encrypted: i=1; AJvYcCV/VohQx3kI9FLmD4QDYLFDOkvKffSXGAsfbM27NQ1pcimNOI780QlS1MwkIIikTNvFCJM1/3O7jjBrZM718E+mCqM= X-Gm-Message-State: AOJu0Yyzbs0bZlM7LgJxht1oPKmbpPneAQA9Jq6SCqIj9SkfSMSLR14e 3nw3LqGLfP4VaR/IyxsNzV5V+r6pzBm5O/ylhrT3ITbg4wux83NsB8U11Z5h+mhfVHaNMox+T5X QeWxh6ITa8QsyxYap0GA1ero987KAkgf/fMaoV7AXEHjBdnlP X-Received: by 2002:a05:600c:1552:b0:426:6822:861 with SMTP id 5b1f17b1804b1-428e6b925c7mr72392225e9.36.1722848414274; Mon, 05 Aug 2024 02:00:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF5X01e4CDCLCXfAB37fYDPKvRcTeP8WyfYVlDdNd+Qm0VWVvOc9aGo2XYJg7YFARRENnEycQ== X-Received: by 2002:a05:600c:1552:b0:426:6822:861 with SMTP id 5b1f17b1804b1-428e6b925c7mr72391815e9.36.1722848413714; Mon, 05 Aug 2024 02:00:13 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-428e6d643a4sm130515125e9.2.2024.08.05.02.00.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Aug 2024 02:00:13 -0700 (PDT) Message-ID: <73bbee97-ff58-4518-8dcf-e1da07906b45@redhat.com> Date: Mon, 5 Aug 2024 11:00:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] mm: free zapped tail pages when splitting isolated thp To: Usama Arif , akpm@linux-foundation.org, linux-mm@kvack.org Cc: hannes@cmpxchg.org, riel@surriel.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, yuzhao@google.com, baohua@kernel.org, ryan.roberts@arm.com, rppt@kernel.org, willy@infradead.org, cerasuolodomenico@gmail.com, corbet@lwn.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@meta.com, Shuang Zhai References: <20240730125346.1580150-1-usamaarif642@gmail.com> <20240730125346.1580150-4-usamaarif642@gmail.com> <3be3dacd-1f45-468f-a363-b9d3a10aeb89@redhat.com> <6622b7b4-e558-4d14-bc72-33e8008b06ec@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <6622b7b4-e558-4d14-bc72-33e8008b06ec@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: z4s9ofi88a9s1ebbh8gp1sffoft3f7tg X-Rspamd-Queue-Id: E591810002E X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1722848417-469449 X-HE-Meta: U2FsdGVkX1/Kxk3yGOq0ZoAvw5cs4hkFf2YS8dKvg63l7yxHPswQpglhnCvX4VM6UEZ/yf7GNTQ9pMEeaQAwzdYNdj6H/BfnNsSt5a/d5pk27Z/fcwj3XIf18EYtko01cWDuUXVohIVwxSqjMFKXAcw6f5JCjObj4Sk8tvklvLrgDJt7rscs7D7SSnsG/xG20wrfEk0/wY0+RaIRuWJQvKn9QLWpzbB+zAx999uAii/itTHI0bF8DO6j7AgWgTYWBRqq1vblBmK8ubul17JfvQGkzBnspOexzbbs1jJmWxqW2ea8GdVsuAi6bJouMBcm0KJt27apotO1v0vCCSA4C96IqKOEOyN4KDLdZXNA0hxfQ2E2OwRM2fR8VrmvjaA6eqIRQr4XLT8AOpuflH2CcVp5gAcrtsKSaK34TM4LaELRw3/0bRZijjQvaF4pZE2CsXTi8FL9uAd2rRV9lteZfWEQBXoW32atUSn0xKIyCQQGadKv1RzzlorhEVMkY3bcMo4+U9adyQUFuHctCekkt/Wj94oNX+4ZW9CC6ohQJxctOCAZiUPnXNLj0vF8eyMvc48TQ8rntVosppFXurCZnkhLRGZbYsvrbnWFq31P+hmkZ0jQy1by8Zcu5b6clVAAkkJ5MvvDcxNLfPizjqaWpPcxqUR7C+RTYrNi30FoLDZsyO+gEmtyO+wy8vlndXb/vKvhENKBgA+1mIxtWJI8B6WB3qxf83gZ8Jilxx4HzlDActTEinQ7D7eLz/9oUtSasJ4rzTxVBqQ7L8LlOhStU7D699kNmJ1fTWQRJCFyEts+ctxFue828BVNUqVeAsi16tniv1sq1ILJd9HwAJRcoAkYp5lZ3uMrfW5ySIsq0wX39qefYO+/t38mcFVlIh8/z3N7W578eut3SR6p1wmSAHaYquKiN6hzBYou+Vmkc+VaMyfg43Zm08VHhEDEssj6RwBuzWA87Plocgt4yiu jp8+sH80 tvwLsx+TDSqi0xVFDxD+Yz0YGHGp++11hfZaJrIlsRURzjOtUctwzKq7VRhKDDrzJE9UhGToODd1L3OmKRivekIPdfrjSiCZ1Za9ds96+XGRdCslZkqwyyd1fW1dNRAtkFuK31RziGFBtk4HaNBzgkhj0J6JHHj8b/prfn/M9kPo+9bXfPaz3BQP80QOdeBvJxSdH70Ne+LQ/jJtNCucUrJhCBGWV7CLj5HmOyJD/1bMqoA7Uat6nNekrQrlg4EneRHxxykQsBZ0JsNNNcQUnfzUDNZ+cCCUzj8ACaA5kSPD2IwONjgCBSSq/18TxBaKRPmdXcffV1K8z+ypj3bhZSn0YK9sd9VxMPg7KOEQ4cm6Tmc6PlH5UmA29RJXZAov4JpHCKZSS00Bwd9F/0VQOC5UihO9XBpRjXs3lZETJzUKyM3n0TUQsmI9+4HcV4n7wSTcSLrDUQnlomTWej8qx6TNhToDb8DmWIDL/avVgCgNEtrtx2o/p7HRQ/Q/C2Yg1APhT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.08.24 21:02, Usama Arif wrote: > > > On 30/07/2024 16:14, David Hildenbrand wrote: >> On 30.07.24 14:46, Usama Arif wrote: >>> From: Yu Zhao >>> >>> If a tail page has only two references left, one inherited from the >>> isolation of its head and the other from lru_add_page_tail() which we >>> are about to drop, it means this tail page was concurrently zapped. >>> Then we can safely free it and save page reclaim or migration the >>> trouble of trying it. >>> >>> Signed-off-by: Yu Zhao >>> Tested-by: Shuang Zhai >>> Signed-off-by: Usama Arif >>> --- >>>   mm/huge_memory.c | 26 ++++++++++++++++++++++++++ >>>   1 file changed, 26 insertions(+) >>> >>> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >>> index 0167dc27e365..76a3b6a2b796 100644 >>> --- a/mm/huge_memory.c >>> +++ b/mm/huge_memory.c >>> @@ -2923,6 +2923,8 @@ static void __split_huge_page(struct page *page, struct list_head *list, >>>       unsigned int new_nr = 1 << new_order; >>>       int order = folio_order(folio); >>>       unsigned int nr = 1 << order; >>> +    LIST_HEAD(pages_to_free); >>> +    int nr_pages_to_free = 0; >>>         /* complete memcg works before add pages to LRU */ >>>       split_page_memcg(head, order, new_order); >>> @@ -3007,6 +3009,24 @@ static void __split_huge_page(struct page *page, struct list_head *list, >>>           if (subpage == page) >>>               continue; >>>           folio_unlock(new_folio); >>> +        /* >>> +         * If a tail page has only two references left, one inherited >>> +         * from the isolation of its head and the other from >>> +         * lru_add_page_tail() which we are about to drop, it means this >>> +         * tail page was concurrently zapped. Then we can safely free it >>> +         * and save page reclaim or migration the trouble of trying it. >>> +         */ >>> +        if (list && page_ref_freeze(subpage, 2)) { >>> +            VM_BUG_ON_PAGE(PageLRU(subpage), subpage); >>> +            VM_BUG_ON_PAGE(PageCompound(subpage), subpage); >>> +            VM_BUG_ON_PAGE(page_mapped(subpage), subpage); >>> + >> >> No VM_BUG_*, VM_WARN is good enough. >> >>> +            ClearPageActive(subpage); >>> +            ClearPageUnevictable(subpage); >>> +            list_move(&subpage->lru, &pages_to_free); >> >> Most checks here should operate on new_folio instead of subpage. >> >> > Do you mean instead of doing the PageLRU, PageCompound and page_mapped check on the subpage, there should be checks on new_folio? > If new_folio is a large folio, then it could be that only some of the subpages were zapped? We do a: struct folio *new_folio = page_folio(subpage); Then: PageLRU() will end up getting translated to folio_test_lru(page_folio(subpage)) page_mapped() will end up getting translated to folio_mapped(page_folio(subpage)) PageCompound() is essentially a folio_test_large() check. So what stops us from doing VM_WARN_ON_ONCE_FOLIO(folio_test_lru(new_folio), new_folio); VM_WARN_ON_ONCE_FOLIO(folio_test_large(new_folio), new_folio); VM_WARN_ON_ONCE_FOLIO(folio_mapped(new_folio), new_folio); folio_clear_active(new_folio); folio_clear_unevictable(new_folio); ... ? The page_ref_freeze() should make sure that we don't have a tail page of a large folio. Tail pages would have a refcount of 0. Or what am I missing? > > Could do below if subpage makes sense > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 3305e6d0b90e..abfcd4b7cbba 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -3041,9 +3041,9 @@ static void __split_huge_page(struct page *page, struct list_head *list, > * and save page reclaim or migration the trouble of trying it. > */ > if (list && page_ref_freeze(subpage, 2)) { > - VM_BUG_ON_PAGE(PageLRU(subpage), subpage); > - VM_BUG_ON_PAGE(PageCompound(subpage), subpage); > - VM_BUG_ON_PAGE(page_mapped(subpage), subpage); > + VM_WARN_ON_ONCE_PAGE(PageLRU(subpage), subpage); > + VM_WARN_ON_ONCE_PAGE(PageCompound(subpage), subpage); > + VM_WARN_ON_ONCE_PAGE(page_mapped(subpage), subpage); > > ClearPageActive(subpage); > ClearPageUnevictable(subpage); > -- Cheers, David / dhildenb