From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93F83C48BC4 for ; Wed, 14 Feb 2024 09:14:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E77116B0089; Wed, 14 Feb 2024 04:14:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E26746B008A; Wed, 14 Feb 2024 04:14:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C78576B008C; Wed, 14 Feb 2024 04:14:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B4C016B0089 for ; Wed, 14 Feb 2024 04:14:16 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4C177140CC3 for ; Wed, 14 Feb 2024 09:14:16 +0000 (UTC) X-FDA: 81789848112.13.133D458 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id EA8DF160009 for ; Wed, 14 Feb 2024 09:14:12 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BUZ2+EVG; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707902053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yF6KCGZ2SgAsNegJkudNmU2sSgptrONfebjoagaAkcY=; b=EYRu26IUfZS5LhIqW2dL6JPIbD+KSvBk/sRFQsiZrE47eEfFmwEAcTQ4xmxJdhQiEku5MB sXW8P6wfT7p9hqKnvNh0k6pxU8eHTNG5T7PS6+kN20DPcJfhWhJueoT0yIja3ofoMyzNlA 0D8sBmFRaCCjEDxPCgtDetB80ZO8q+Y= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BUZ2+EVG; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707902053; a=rsa-sha256; cv=none; b=yv32InuELdoWzY65qdFB6pW0+UkoG5Trzia8bqxl8hh+23P/u7cNkvme4zaJiFiEFO10hp gUWA/JsebxDgmjg9FrEmeF3tMTQJaOUpCETkGwJgBJ0irwdF6dB6U0OAi2eSd+d7jpFR0M x7bI4SBkZpLjIoNLZ2o+xiLfQmJXkhA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707902052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yF6KCGZ2SgAsNegJkudNmU2sSgptrONfebjoagaAkcY=; b=BUZ2+EVGqQBgF1YdkZLG8lcFKbmyQ0oWMmIyne/BpcfvOXQS08eYnDxbQBugwGJqtcpVSH xmgD/DjtoYPA6ZsZl9a5SZhaxSwLFWdjgDwPWUXGiH+k3sKh9MIrdZPAkrzZg121xJxT8t 2h6SXZegMEDwWDsf0zo5EwBnsr2+E4I= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-6-X2QANqiKP4K4SSni1kjovA-1; Wed, 14 Feb 2024 04:14:10 -0500 X-MC-Unique: X2QANqiKP4K4SSni1kjovA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-410e26257c0so14267665e9.1 for ; Wed, 14 Feb 2024 01:14:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707902049; x=1708506849; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yF6KCGZ2SgAsNegJkudNmU2sSgptrONfebjoagaAkcY=; b=bJL/iZ/iXyPnqVpJBoyUgv87zYx9bmnH7HfOfr4m8AYp3Hk1ir0qIr9q4Hq+haqtU5 QpozOTnrbmY1Oa8v+RV1vEBYE8WwYwFee0YqIm9PFk2KPnd4Fz0m8hKJslX/gv2TlJpT b6mt6P5GTAuwD44MW1nmt7SVroRDY4PB9nIPld0jHiXH5ro8hBprAzM/dvus7F2pqRC8 RSouzCHqHmyXjEzG2wkFF1SDVC++DonvJXl4M4/uB/Mi/fTu/oq28H77rQebgHaBSQKb Md3CZBNdqdRCcMd99QGWkRUvpmtiW1ZBFzbFKV1P3AwRxezPFos3D/MgAQG3Vcv/mfZS 15Qw== X-Forwarded-Encrypted: i=1; AJvYcCVLM1Fi0r1YwLWPpDcCvaJmU2fw/+05ABAXr4ZB44p6Vg51OXsJVynFTjKPF4rDh1xr40nRSI7aIwplljPvzPrMcGM= X-Gm-Message-State: AOJu0YwwSie98pSdxm6piC9Yfms8sgnQp4t2aCFpjj7d3OziUMgEpqH8 Vk5OBw/sw7FhVX1O2kyet5nqXXF8IZSxJVY5ZMtC2ows+UWi6E8oOGJWv8Z8Zf1qPcWQIGB6MCI hQmRAFznZcKZbgQZG8JI31X13tW2klwmXK5hqFQ+lpFjYdOOn X-Received: by 2002:a5d:4fce:0:b0:33b:6267:c594 with SMTP id h14-20020a5d4fce000000b0033b6267c594mr1349256wrw.10.1707902049479; Wed, 14 Feb 2024 01:14:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IGARvO3alTod/7fEEMprPUww3ZuSO77uKkZhZPmv4kYJGvEw1gD2bI2kkXnpmfnuumVCc9x5A== X-Received: by 2002:a5d:4fce:0:b0:33b:6267:c594 with SMTP id h14-20020a5d4fce000000b0033b6267c594mr1349234wrw.10.1707902049108; Wed, 14 Feb 2024 01:14:09 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWfC+oqcJxekVmFZDfLL8+ZEkSTIXEf0lqJvPGIBIVEVQ3syv9iqUCzwHg0ersrQawhtBD4SoAjeOdOyGZxchiiMbSPfcQkmp8Lkb1py99Fl8CwLLw4zwbDKHXNLcZmA72adapBLeJBSj7hXAYZ75xbFJO5YLYfLB3SHdp97YSPcFyttsoI4ko6QMTQsQ5mDFtHMYFbHaFPqhGPgPgtR7sHUOE8i1oBE76PF7kU3zVO8CTSjKyD4KBoxRT9VGpeuVp3C3tkmaevIEkn1hIjoAOLq4YkO5cC8zEGOzh3akZiGQPMoIKgqfKsNId7O58APBOpme8vVxN/DKSO3+FZZJHHgekMZmKesWCDvK0g2euaEbFmI5ZaN0g8PKMyKBSjYAgWfh2ymj6RPjSj1+FYQq2hyr4hISaPr60P+TtVMSD7JBC1mIXV/41d+Pij/p0ZQQS7xDXnRZUlGJvh3pGY62qofsJuWd5eYQh9Ar+0apfS9VIhHu5rGOLnfls4PAa9rZiwom31N1x7RZ8Xi+ouPl7h0z8xVHhR2hMujQP/46dTjHU32siECcuwoaNipbdkTu+4 Received: from ?IPV6:2003:d8:2f3c:3f00:7177:eb0c:d3d2:4b0e? (p200300d82f3c3f007177eb0cd3d24b0e.dip0.t-ipconnect.de. [2003:d8:2f3c:3f00:7177:eb0c:d3d2:4b0e]) by smtp.gmail.com with ESMTPSA id g9-20020a5d5409000000b0033cf0f5a01fsm504394wrv.33.2024.02.14.01.14.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Feb 2024 01:14:08 -0800 (PST) Message-ID: <73b550a1-05f2-46b2-a0bc-574fabe8460a@redhat.com> Date: Wed, 14 Feb 2024 10:14:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/7] mm/page_owner: use order instead of nr in split_page_owner() To: Zi Yan , "Pankaj Raghav (Samsung)" , linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , Yang Shi , Yu Zhao , "Kirill A . Shutemov" , Ryan Roberts , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Roman Gushchin , Zach O'Keefe , Hugh Dickins , Mcgrof Chamberlain , Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20240213215520.1048625-1-zi.yan@sent.com> <20240213215520.1048625-3-zi.yan@sent.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240213215520.1048625-3-zi.yan@sent.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: EA8DF160009 X-Stat-Signature: pf6erxxz5xna8qaskif47wkby4hrq784 X-HE-Tag: 1707902052-511467 X-HE-Meta: U2FsdGVkX19G8TP9aENsEmDrmvkEVNPae9KT8a6e85SOM8LHTUV3oddRnjJQlu9IrxlcWuF0P9EjgpztefQ9gf3bNbFGAnlHi0k8CxafsweMqkkGO7JlWxiWZNfl0OVU8PGmfXMcFQ2MiNFoZo4kxKVfHzc82OvZqp+CTaWtCb7ENqI+FMqncivNyYlXXdlKD/iL5HLXhRaoDsgzX4r50eQJaE6liP1nO8CMHChTdLR61wSwbDg0RVpyY3axs1CiicDg2p0Cw/ejndNpl62uB1JyYmqXnVmqvCCZd8smX/CfumZ/RX6BoDUe73mljjugnX3xgOOlg4tmaq7W9czQwUg8DYR4SUpK8u9b/3BKNX5g9/v3PmrygSlKWoT+z9qSo7pfcy9qj/Wd/mMv6e2DmNvHu4u6rwbuKLppNh0rGktGkyDF18klwOi2chqxPgh5ItlHGoHUspogodXShUcM8nGmy8IxNYddpCRGLbWU8KiIrT9wG511KEGmU1Tn0TL+3FVc3ckzNK64M3uAASQCeUw1YUg89qrUd4hWyfeu9HB+alecojm3l8Cmik6Yw0ZFi3nxfW7B1RDJppia3CfuH4Bmzm8FWST42hQthm2cXEQZKYX8qKxGWQDd174U6owEd4jJANih5yJxpiJIVLzqm/8sqXnTqRzL9rb0yhtt1pg0j7tpgFlTkp4lE+DX8IIherPEdzU+iw5M+EmcDzkprp8EBWC+82IaWlFdoJD+SO8oJn1+bKRTJOzFpqWIfR46o6GnrahA5DRYk6AaSujTb1n+twTxRhdGDvkrgXeHFkiEheesiWuAMTjZWOOmztpH4SZl4OhNZshaGJaj3v5/dmVh/c9tubcN+61JGgLwB+aqWyvbs3LotHCJagX5XzsWLVaEE1VkEObjEbnPsEHKz3P3tOHTgUweH1CRfrv21zvo00/gf4eFrq6I+eS6S+/3nPFSBRTsAjxwzaS9nHi k7xp9k3b JQVkCZ7tTe1X9nmIaPdiJOlBeADrmYVMzpMLc7ww1K7AyFQUet/0Ej76t3UcqsE+cKSWewvCx9XPHecR6ZpegMD8VcM9iilw19XOWLRLVmP+mry/5kzz3KnwuilurlM+lsBDijXmM8eA7vu2Z4pOONqilZ7V16a/Oj9AD4PWfZyV7Wzx5yJXFs1JVHg2crTXmyss7nHBGLmpAbIKvO5pZzwDhhkjysZTUYRJXgDcIpGl7q7VVlW2INWiDFhbZ1IHo/4Y7iDqmwV8/l8DrUM0QjMvcPXRZUu0Q4BWswZO/htdnK9CpQmIjClPh07uepp+pdcY+UyMbFgAnG2dnFVPDLrvR1JSz0zaSRK7SwXDoVHSoXAt3BO7AlbRiT6b3+piTNDguj6Y8ChH4X68+SXJfeGjw0iLwWAU80iUUhpZPqcPxwyWWEpiGDmBLsMGZuYMHRJQE1twRKCNleX1M6u+Zlc437GtiwOG0muOch8UJHn9v37hlM9P40iIqb2ulmGt8dEqg1HJTkSBdkQM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.02.24 22:55, Zi Yan wrote: > From: Zi Yan > > We do not have non power of two pages, using nr is error prone if nr > is not power-of-two. Use page order instead. > > Signed-off-by: Zi Yan > --- > include/linux/page_owner.h | 8 ++++---- > mm/huge_memory.c | 2 +- > mm/page_alloc.c | 4 ++-- > mm/page_owner.c | 3 ++- > 4 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/include/linux/page_owner.h b/include/linux/page_owner.h > index 119a0c9d2a8b..d7878523adfc 100644 > --- a/include/linux/page_owner.h > +++ b/include/linux/page_owner.h > @@ -11,7 +11,7 @@ extern struct page_ext_operations page_owner_ops; > extern void __reset_page_owner(struct page *page, unsigned short order); > extern void __set_page_owner(struct page *page, > unsigned short order, gfp_t gfp_mask); > -extern void __split_page_owner(struct page *page, unsigned int nr); > +extern void __split_page_owner(struct page *page, int order); > extern void __folio_copy_owner(struct folio *newfolio, struct folio *old); > extern void __set_page_owner_migrate_reason(struct page *page, int reason); > extern void __dump_page_owner(const struct page *page); > @@ -31,10 +31,10 @@ static inline void set_page_owner(struct page *page, > __set_page_owner(page, order, gfp_mask); > } > > -static inline void split_page_owner(struct page *page, unsigned int nr) > +static inline void split_page_owner(struct page *page, int order) > { > if (static_branch_unlikely(&page_owner_inited)) > - __split_page_owner(page, nr); > + __split_page_owner(page, order); > } > static inline void folio_copy_owner(struct folio *newfolio, struct folio *old) > { > @@ -60,7 +60,7 @@ static inline void set_page_owner(struct page *page, > { > } > static inline void split_page_owner(struct page *page, > - unsigned short order) > + int order) I assume this will fit into a single line now. Acked-by: David Hildenbrand -- Cheers, David / dhildenb