From: Laurent Dufour <ldufour@linux.ibm.com>
To: Christopher Lameter <cl@linux.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
nathanl@linux.ibm.com, cheloha@linux.ibm.com, mhocko@suse.com,
Vlastimil Babka <vbabka@suse.cz>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] mm/slub: fix panic in slab_alloc_node()
Date: Wed, 28 Oct 2020 14:49:45 +0100 [thread overview]
Message-ID: <73aa614f-24e6-75d5-8173-d858a5b33fec@linux.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2010281109580.1521@www.lameter.com>
Le 28/10/2020 à 12:11, Christopher Lameter a écrit :
> On Tue, 27 Oct 2020, Laurent Dufour wrote:
>
>> The issue is that object is not NULL while page is NULL which is odd but
>> may happen if the cache flush happened after loading object but before
>> loading page. Thus checking for the page pointer is required too.
>
>
> Ok then lets revert commit 6159d0f5c03e? The situation may occur
> elsewhere too.
The only other call to node_match() is in ___slab_alloc(), and the page pointer
is already checked there.
So there is no real need to check it in node_match().
prev parent reply other threads:[~2020-10-28 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 14:09 [PATCH] " Laurent Dufour
2020-10-27 14:24 ` Michal Hocko
2020-10-27 14:39 ` Laurent Dufour
2020-10-27 15:03 ` Michal Hocko
2020-10-27 15:12 ` Laurent Dufour
2020-10-27 16:31 ` Vlastimil Babka
2020-10-27 19:04 ` [PATCH v2] " Laurent Dufour
2020-10-28 11:11 ` Christopher Lameter
2020-10-28 13:49 ` Laurent Dufour [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73aa614f-24e6-75d5-8173-d858a5b33fec@linux.ibm.com \
--to=ldufour@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cheloha@linux.ibm.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=nathanl@linux.ibm.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox