From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BE91CD128A for ; Sun, 7 Apr 2024 08:59:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDFD46B0088; Sun, 7 Apr 2024 04:59:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8F916B0089; Sun, 7 Apr 2024 04:59:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7E426B008A; Sun, 7 Apr 2024 04:59:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 888646B0088 for ; Sun, 7 Apr 2024 04:59:55 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5731E808B1 for ; Sun, 7 Apr 2024 08:59:55 +0000 (UTC) X-FDA: 81982138350.03.D870EAE Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) by imf22.hostedemail.com (Postfix) with ESMTP id 622E1C0009 for ; Sun, 7 Apr 2024 08:59:53 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MdmwthX0; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712480393; a=rsa-sha256; cv=none; b=n0PhrqkmpTQRNajWkMcV1gRz/yuvkeQVDDhqZf2HtN+n7AuZNv3iLfF85utbyUeh8UJayE AVzL6H5N23cRIydYOsTYyKMw231zfXVkBIr41+0t+WXEUWc7aqBrtFU79iOrUN8VcvO9rf RvhjgkLXBHsjrVTu4SdwrhGsN2lnhs0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MdmwthX0; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712480393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KmlsLVmLcxwali6owfZJlKAmm6iLSvM2+NU6gTc1Z9E=; b=qIZCyuElKp75iUWblLsOg/KEGdj+EiFSiG+oPXsi5fTcbjCnHZ5R1way/dnxDRfIfSp4o/ ezbMf2882LXQae9DsEOG5iA79JoFlfqBbQL5Iv70x3m8I0M6v0PTlQsNkks8XNJhkkQ6IH Sk3rrM5WU+q8oVx2iCltao5umOn3TFk= Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712480390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KmlsLVmLcxwali6owfZJlKAmm6iLSvM2+NU6gTc1Z9E=; b=MdmwthX0V3X6njLDOvp9NfaqxNSB6UBqMaxuwwdty+8Prq508dITZqvax/Nh+zoJ+Jw6y7 sARASJGWygTtloekFRWTE+2xcwYbUBJj2xCaM+0d+3NCW6QkLBmhLp7mIoFlL+KQkzEcXl 6yojE3HnZHJmbI4IQLsxfsnDNys4Kjo= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Subject: Re: [PATCH v2 2/3] hugetlb: Convert hugetlb_no_page() to use struct vm_fault X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Sun, 7 Apr 2024 16:59:13 +0800 Cc: Oscar Salvador , Linux-MM , LKML , Andrew Morton , "Matthew Wilcox (Oracle)" Content-Transfer-Encoding: quoted-printable Message-Id: <73DFA2EE-0929-4801-9C7C-A393F7796CE8@linux.dev> References: <20240401202651.31440-1-vishal.moola@gmail.com> <20240401202651.31440-3-vishal.moola@gmail.com> To: Vishal Moola X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 622E1C0009 X-Stat-Signature: 3cuqcphpdf68ed7r56ucr5sak11jgsj8 X-HE-Tag: 1712480393-147604 X-HE-Meta: U2FsdGVkX1/f/evEm6lo1r7as4TtnNbfJY1VdaTdzIQoOGcwjUC88LoLkkGBM1L4xLXCWFevNrroD6CJ/s53v+nEs4BPCVxTU4AizGmE5QrJ0F3ul6ZKNMmUgZ0EhFAk1llWEiV1tDj0prl9xGQDScl56yESjhSnQERD94rcFhIJpCpnagRheSM9jNQ+07K+MJuKphvDoRndUgSCwuM0iG6qYMjYhTBycnQQQvTneLTsenj2jC7nVahPiw+Cv0WnM5MYTvGW2EORuSdzSoMLCs7HSACdd1M40l2h6KJ6BQH4tdChVkxZRB9fE4FakbcElAAnb1OIX7kJT24RN+KCXCS+UrBnXI6WfYnLvSoRE7kdjQ4TKUY5eEamEx07AEyn8DlrNbezlJna82K4lP09girAStdt3Hwsc6pLnisDqDMTUG1jshp/mmmJojA1cmY0WeZXpMATgI6J7jh9d32isAly0nA5k4hrGXQNF4Q/AdCYcQN84ZfTg9E/RTrdgU1otTbTBVTHnHlQXjYlRcok8iFZLcwP+HzYDLkD/xk+2+ywdpsS9li/VzJg7zU1v8y8Yf8zo8d9y5H2FufA/CtVv6sHBgd81ZpJ55KyMcrGL8VEflLNJYWb44+q9oStGKHxnIq+4nM/uauy887YW7KJWyl3XhGTGvdrBYj3HsBk9KdjXdsxUhl5Xn50xNs1NO/wI09nRgKQyfGdAHVKC3LlPwfHFop1UahfMfZiTezfl9mO6Dhk5tU7KRoAi1xhro0MrTnuE6UXCpo4qOco5DBxLUuY3hZllYiQEEgxfkHXyjWNufUQSi//gizftReWM1wijfWFTkUVO/uXwL2Rf6rXO+yuXLggwfgZ43ldkuC2HucaLBU1DOdjVvthM3Khd8LMk94kqjvLwpxQNVd6Adqn2vaByEbjbV2UTkNrjLMRmIhHhDQqStTPpQcSwjxjACM/j/ynrRzFCDzBRfyCSJR EDdZsnRA 1ceh0XYH3PHSQH0YUkQsuKrwh/R4vqSwDGfSqt7wA52reCBNV75cfrNAoNO9XaUFmiJQXf8rBHR42t9qXfGIAQsHzX2sN+ARpDQddtq4l+zu/mbuYOh/4mybmWGm5BURPVDryslOingnnsscD64KSKF6bn+xreKWId2I3nSCZI9oLOg/3gTj9j5fDPR10lyGLwWHXaY0/kyTMioxa9OCDQ9EZkw/1nlnWL6VGjf5njQ/Xu97vl3+zttHnABMw3Q1m+bgf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Apr 5, 2024, at 03:58, Vishal Moola wrote: >=20 > On Thu, Apr 4, 2024 at 5:49=E2=80=AFAM Oscar Salvador = wrote: >>=20 >> On Mon, Apr 01, 2024 at 01:26:50PM -0700, Vishal Moola (Oracle) = wrote: >>> hugetlb_no_page() can use the struct vm_fault passed in from >>> hugetlb_fault(). This alleviates the stack by consolidating 7 >>> variables into a single struct. >>>=20 >>> Signed-off-by: Vishal Moola (Oracle) >>> --- >>> mm/hugetlb.c | 59 = ++++++++++++++++++++++++++-------------------------- >>> 1 file changed, 29 insertions(+), 30 deletions(-) >>>=20 >>> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >>> index 360b82374a89..aca2f11b4138 100644 >>> --- a/mm/hugetlb.c >>> +++ b/mm/hugetlb.c >>> @@ -6189,9 +6189,7 @@ static bool hugetlb_pte_stable(struct hstate = *h, struct mm_struct *mm, >>>=20 >>> static vm_fault_t hugetlb_no_page(struct mm_struct *mm, >>> struct vm_area_struct *vma, >>> - struct address_space *mapping, pgoff_t idx, >>> - unsigned long address, pte_t *ptep, >>> - pte_t old_pte, unsigned int flags, >>> + struct address_space *mapping, >>=20 >> AFAICS all this can be self-contained in vm_fault struct. >> vmf->vma->mm and vmf->vma. >> I mean, if we want to convert this interface, why not going all the = way? >>=20 >> Looks a bit odd some fields yes while some others remain. >>=20 >> Or am I missing something? >=20 > Mainly just minimizing code churn, we would either unnecessarily > change multiple lines using vma or have to declare the variables > again anyways (or have extra churn I didn't like). I don't think adding some variables is a problem. I suppose the compiler could do some optimization for us. So I think it is better to pass only one argument vmf to hugetlb_no_page(). Otherwise, LGTM. Muchun, Thanks.