From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43B5AC28B30 for ; Thu, 20 Mar 2025 21:03:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AF25280003; Thu, 20 Mar 2025 17:03:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55FE9280001; Thu, 20 Mar 2025 17:03:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 426D8280003; Thu, 20 Mar 2025 17:03:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 261B3280001 for ; Thu, 20 Mar 2025 17:03:15 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 123FC815C5 for ; Thu, 20 Mar 2025 21:03:15 +0000 (UTC) X-FDA: 83243154750.03.01C1ADB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 7EB3614000C for ; Thu, 20 Mar 2025 21:03:12 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gX0vvsxf; spf=pass (imf26.hostedemail.com: domain of ddutile@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=ddutile@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742504592; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g9cWHc7K+Srf/xWlU/uXyGYlcpAE8jDtkMRoLJ801OI=; b=nVdApiHaQelCvaK2f5to84xXsSPAvyHrIenb/rGteTKq5+AawEeQsBprVylW52OXGpGYs+ E1lE9oSxi8pm3VQcGCxyBovJJdW6h0pyH2U9pgl/jELjlNu32eck3p/yacqZyiV2QnH6Lo JacN1H0SBnj2IdmNT5W2N1F6A3Qh4ew= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742504592; a=rsa-sha256; cv=none; b=o2iSOyjGGoJi/oTqS3cKul8G9qIcI/GrelLe2MOvCehdwt0m88ul65Xq5U6xK/EJ/05HmB zCXg5andgvfnCcVjJIH/TloUx+wgSAs/AydYpLuL3BcVfKKFqmzS0amhb0az5aLwOrzWw5 TknBzyie+u9zFF2UZNbdXeaxGzdOquI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gX0vvsxf; spf=pass (imf26.hostedemail.com: domain of ddutile@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=ddutile@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742504591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g9cWHc7K+Srf/xWlU/uXyGYlcpAE8jDtkMRoLJ801OI=; b=gX0vvsxfFmhy0BtGCxl2HNUN787UQiW6iWd1RqojUZdC4vR3GoICZQGsrEgAN62xb1JsK8 b9pAfdJZFkQE8o8V+ofCdpmDfMBqHaXcaAXXCic5Y+DZeuV+UsCdS/DXApKfgefixVRVTi ElEW7TAjIR/+WCmErG3V7atnNWYqa7A= Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-FxaLxGIKNEyiu-qybWIlGQ-1; Thu, 20 Mar 2025 17:03:10 -0400 X-MC-Unique: FxaLxGIKNEyiu-qybWIlGQ-1 X-Mimecast-MFC-AGG-ID: FxaLxGIKNEyiu-qybWIlGQ_1742504590 Received: by mail-io1-f72.google.com with SMTP id ca18e2360f4ac-85b5875e250so143402139f.0 for ; Thu, 20 Mar 2025 14:03:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742504590; x=1743109390; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g9cWHc7K+Srf/xWlU/uXyGYlcpAE8jDtkMRoLJ801OI=; b=fByQU6xv2azguUmGxuU1wSsU/VanzczyrxSNYa6rW3g9rQDmMMIlXf/1ihEudrQd3c +GndcU/aZHwsLP3OFIXu6pDlBqRCLE3nm8rBorZ+3Og9Mnl5HVKa5xJXimx44G4aFvg3 qYlK33yXA7a6/icRJhv8j//+4nReIVAsUXgp3z+/bymAmJG86OmkBJ32DowzUC7QtHSy YfYE4gLm/adHn/Irk+4jE4Xd/CZC143CxoB4pWHIjLo6JehNuBGw/SQm+y7u5DaAcTZl 7bF07p1pz/tDICnVQkF58yn+VowpWkPYF56lXzorLl1evt6fsbzi+SHHkpnPQrcGgSNg Z0Xg== X-Forwarded-Encrypted: i=1; AJvYcCVK14FHJMlsZTfdmRprbLRXGyO0PrnXFDfGi3/VxLxi9VyR1oJqWtFO4sgKa8o5KozN9EXqJUMbJw==@kvack.org X-Gm-Message-State: AOJu0YwPYoB+e7ccqEMkCyrGZzwhH69qs2mpyQ77DfaCFk00s492tgYD EelA2o1KQyI0GdHh792iaRGJgSW04ofCKTLqjPN4ASyM9g0brSkXGM5YLBEBGjXwXN5wPmrFIfn p9Fo7fSz1ltV6jRF3Tg8qlH5CxoWUVHhG6l0cPaOOLwDVBEYO X-Gm-Gg: ASbGncuptG/obI88p1SOY3cYFyl6jG2Cl9za1wTzmQM5LFJUKovDmg3BLxHBvWC9y0Q zg5COvP2V6LfZJWGoAx4P32H0Bcti/DpgI+UWDSPYQhhTW4Gm9RALTadIIaVNgXCsX45VrR5LMa 0xYKG7INjQ8Mq6tDH6XDLeppdgel/osYrl8SyNIS4khysd4fR1mMKVa33E0FS/6To5vs+zJIR2g FUf2HM13+SafFFqyWsWxgExrGFWC05trw4UipPVL1Go2cF3Irf8uVtmJ5MQfHka6uOQIvEksjDb 3EB57Gzu6v9E/yKc X-Received: by 2002:a05:6e02:3a0c:b0:3d4:6f37:372c with SMTP id e9e14a558f8ab-3d5960e2419mr11346105ab.7.1742504589884; Thu, 20 Mar 2025 14:03:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnzVigKPBA5Q69oU5Iypl8N02NSBBlztIoOjGF6V6vtIJyPBcKMGbE54MAjDKZEk1qejJTbQ== X-Received: by 2002:a05:6e02:3a0c:b0:3d4:6f37:372c with SMTP id e9e14a558f8ab-3d5960e2419mr11345785ab.7.1742504589527; Thu, 20 Mar 2025 14:03:09 -0700 (PDT) Received: from [192.168.40.164] ([70.105.235.240]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f2cbdb3bcdsm104582173.3.2025.03.20.14.03.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Mar 2025 14:03:08 -0700 (PDT) Message-ID: <73969634-a6f6-4dbb-bc30-801a5c4500cf@redhat.com> Date: Thu, 20 Mar 2025 17:03:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/arm64: Drop dead code for pud special bit handling To: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrew Morton , Alex Williamson , Catalin Marinas , Will Deacon , Keith Busch References: <20250320183405.12659-1-peterx@redhat.com> From: Donald Dutile In-Reply-To: <20250320183405.12659-1-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: abBQEmEoA4G-GRauw4fTMkbMmvyVXL5M-oqkoFf7VFw_1742504590 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7EB3614000C X-Stat-Signature: 6kmjp3ij1qg77jupsu41upjuf73wfci4 X-HE-Tag: 1742504592-393863 X-HE-Meta: U2FsdGVkX1+zwiWXtjBmhGxZUyOjghIzk6ahTNGBsgHnYR1tBUpuYXGZ6NvCkcjoqX21mZl6xM2PsZH+FB2eiUYs778u1ouKN6mvFqx+6xiQ/uxHOguFvATDTlsZTN4TN+Vc2FTvDAj3gyhHFXChlzPfkvqEJeWZj/HTDz0OUYdvD7pGT2R5DP96v2ikKVXOUta3VR8/Af6rwSMWRWGFzlHJuxzy7MoJ9VOqthrDsa9pNa9GAK9+vepFMDJqgTlN7TwWk5AR6zGMGhpjGN/zXIfumeiZ/YLh1+JgTtrEArrNb/Q4fdYUE9Ctlp2bRgumhHl26iCfkfVXbemuBrOHQVU+MsQPX30GqWfhMjGXLwEA0csaRhkltjvBLMaBY45V57wHVAVV4J5DOOMy2icIhz9bJW8lOk+FPyHAR93cxRO5g4uN4uY4YFmFZmJkwWjbdlMEMLXpM30I9MIpWq8sjyVOKEddau7hVTmeNbnmW5DxBQbobiP8538HH9GeHyEMhTxeg0u0KGaNenfcX+v4f0ujEKcIcm13FWxUWzoufI9XcHz0kBrcF3F/70RsSQ7zTFJ+vwrpffLQWZO+3GK2ASK4uOoP9M82bcssFNcSq1gM1YukseGo4TaYF6WWmTFKFfhTjjLETerZHXwp4GA8OubDL+GX5S9orsATvD1LXz4ZcTr/pwef2ZMEmFmp39GzyeU+fpffHhb04a6IwhKtWWktO/wBJ4JOVx1wdOjtRn3uR5Az8N7tFPsV32ki61+tpWg+XgzP4m2iWz36pgrhxCdTR3Didc8qYLZGOcTOfPwwZMJTSwOdCn+Uezjqts+fPid2XNCWI2Dnm8QgF9noFIbTX00/+hucWAGjmUjib5OFPVw5WP7RRxl90bSPEKcwS31keb9yInsbRakJ259bq1MEY7LSozLlRd9Jm1mfqNHGeSuNsbm9/aUzQZ1mAcx9pteeH5eqswmePK32pVd V/Rys4+l jAOqQzKKb7w2thpFq/UlSjSKw/V5HDP7humFmd9+taeipg95mp5vQd0vbdGjU8zy3Xakh/4mOmJemIp66LWY73ljSblFgtvGuY+GyCov7R8jtwlvmT82AZv55lfT6hG941+GjTWszFUGV2MNuJj6DzS2Juj13EVbUl3AJOL4G+ZvtyMuovGY3ryxKeqK5IkE9CsXFtiqYaKaBeD3E6MIdrmyX+uCPuIhZFVlJcanqFshNu06KDfZhqRS+bF7GQSv1nQHh6ds1G6RW2Z1Nn3hpGpxV7YGm7IUjGjtSHH1sGpmeh2DY37Ak+A7IRiC1FXcecD8DBRP87quEl8OgO74XGuLHD2jVf+WO2L0zYDL9hp5GWpKAav/KYJ2ZjxExjwb5Y+LEtzTGQSVdbn8RgRwziFCtTFLqMMkJhs2rFep5c6MdabGggDdJMGXmV2MVcjEKW+oPzK++M1fdZuFTQmSd0+jDJfYqM+/doCxDiTnGlhCIW/a1xTxVN+/DUozKOo32DtQBwunm7mA5K5qes8YgdmaCxhDssGUCE+R79OmVvcVeyr1P3kdRyQovq7kBqQ4nwM9OkBlcsdQXuBIP0cnId5toDm6FhzPHLpSLnhDNdgzHFok6z6jKircW0P6dG0gXHo9QN+cfldaJkUc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Peter, Thanks for the cc, as I have the original commit in a recent, proposed backport that now needs an edit... or, since harmless, maybe this patch to additionally backport, once committed. :-) On 3/20/25 2:34 PM, Peter Xu wrote: > Keith Busch observed some incorrect macros defined in arm64 code [1]. > > It turns out the two lines should never be needed and won't be exposed to > anyone, because aarch64 doesn't select HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD, > hence ARCH_SUPPORTS_PUD_PFNMAP is always N. The only archs that support > THP PUDs so far are x86 and powerpc. > > Instead of fixing the lines (with no way to test it..), remove the two > lines that are in reality dead code, to avoid confusing readers. > > Fixes tag is attached to reflect where the wrong macros were introduced, > but explicitly not copying stable, because there's no real issue to be > fixed. So it's only about removing the dead code so far. > > [1] https://lore.kernel.org/all/Z9tDjOk-JdV_fCY4@kbusch-mbp.dhcp.thefacebook.com/#t > > Cc: Alex Williamson > Cc: Donald Dutile > Cc: Catalin Marinas > Cc: Will Deacon > Fixes: 3e509c9b03f9 ("mm/arm64: support large pfn mappings") > Reported-by: Keith Busch > Signed-off-by: Peter Xu > --- > arch/arm64/include/asm/pgtable.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 0b2a2ad1b9e8..15211f74b035 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -620,11 +620,6 @@ static inline pmd_t pmd_mkspecial(pmd_t pmd) > #define pud_pfn(pud) ((__pud_to_phys(pud) & PUD_MASK) >> PAGE_SHIFT) > #define pfn_pud(pfn,prot) __pud(__phys_to_pud_val((phys_addr_t)(pfn) << PAGE_SHIFT) | pgprot_val(prot)) > > -#ifdef CONFIG_ARCH_SUPPORTS_PUD_PFNMAP > -#define pud_special(pte) pte_special(pud_pte(pud)) > -#define pud_mkspecial(pte) pte_pud(pte_mkspecial(pud_pte(pud))) > -#endif > - > #define pmd_pgprot pmd_pgprot > static inline pgprot_t pmd_pgprot(pmd_t pmd) > { Reviewed-by: Donald Dutile