From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F2AACDB474 for ; Fri, 20 Oct 2023 06:14:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B607C8D01C1; Fri, 20 Oct 2023 02:14:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B10248D001D; Fri, 20 Oct 2023 02:14:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FF868D01C1; Fri, 20 Oct 2023 02:14:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 90B238D001D for ; Fri, 20 Oct 2023 02:14:32 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 61CD11A0364 for ; Fri, 20 Oct 2023 06:14:32 +0000 (UTC) X-FDA: 81364825584.01.0C16EBD Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf20.hostedemail.com (Postfix) with ESMTP id 3E1401C0004 for ; Fri, 20 Oct 2023 06:14:28 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf20.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697782470; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P8sgqanMuJmIgSVFFQYjcEpXBLTsfBvqvpnboy9Vk0E=; b=VMyO/O4JKmYyxP57tiXp4AaqJRKR9O/r9kW2H130i82y+aC1mKL5h3nG0mpDAokNwPEWtA 74SBya59Ry3emKQMt662xRKSBbvjDSVNPkx9+fTzTbDh4H01btqCAbfM0QwKrvOtLPMZIw bpXlKFx7lz4RaO9QiNheRckcXDfQukg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf20.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697782470; a=rsa-sha256; cv=none; b=dLyh6UHjfwAPcomiJpWizMS17ILrr/uX0sggh0C7UzHb9XCcJ0cQe3QRg+utWCgMF8c1HE uk6Yj91UflQo1ACBc1Cn7jJNJk8scNpC/fmvN8sdSJw0ChiQozzj+gIAYSIToUREoY5pOz mL8e6fXjHns0XgeRMA1MrXeZH5ztzE8= Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SBZ260YdfzNp5q; Fri, 20 Oct 2023 14:10:22 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Fri, 20 Oct 2023 14:14:22 +0800 Message-ID: <73884890-0dbc-482a-9c15-6a32b36d799d@huawei.com> Date: Fri, 20 Oct 2023 14:14:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: cma: report correct node id Content-Language: en-US To: Christoph Hellwig CC: Andrew Morton , References: <20231019013253.2792048-1-wangkefeng.wang@huawei.com> <20231019050229.GA13957@lst.de> <20231020044731.GD11984@lst.de> From: Kefeng Wang In-Reply-To: <20231020044731.GD11984@lst.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 3E1401C0004 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ud4wxz18mtqcq6ey1stubfx36in7nadp X-HE-Tag: 1697782468-697592 X-HE-Meta: U2FsdGVkX1/WPc3NTQ7Fk9bIObquT/XTRcjMPpPkqe698XQeKN6sOxL/C/vngkByiURWwf5ukI2Ai8ZJUiXNEzVLtCB0GLGqk9+6HhtUcBOfuVIFFuh783xn0gZBEB3kJOeZrMfcKldzFq9978WoPPHwNqYjIPYrpiREwom+Czkph9hEw/GfeKUXRz4QtsigcdMulfkRH51Aa2+1bZOkc9d6dNh/gIr/R8X+0N9kzpTG2Rg1LQlWC19Fx5zFOD8NiSSAEyQBN2TzJtIgF1jWvU+0vw6t7le1jqCQw4/SngLJZrJd8JgaRNhuuDKlMYZ069yJAssziPXgFP65pBT99V5uZpO8lkPB7qie3MVAGL2bpinKTdAJT3Vr+bCEakAQ0vv0RMn/cWP/SXJCnKlgx0say3q3A15p/Xx2J/TPVsigdaHZDJv45Ee9FcHwfOFznOwxWfc4mh7E6CYLV/Kwc7TYh+VOTY2b9Z1ZpmOjsUPHtRT96aokH3Vi1LTOFH0y2pQtP6J9ZW6k6RMLnXdKjQWwcsHA+orccZh0xgHdi7LHNj8MCdSF8T5Ztd0hVGX5kE6ZR16SWCY2nJnEF11t5Grq7SclP5gyjD8p1Yh4tn+/1T+yGuAUnSAC+olVO6oNdTd+eZi3DnF05LSlmJjGAUjshobTtElgmPRzqGMJOnSbhq5h9Ytm52UUG7oDBomm+ZW+W2arj7pOW30ld5XuaTftJmYX8Z0vpsDvyrL+7pVZ/Z522JLr9xX02MMYSxbr4IuVqoJJkN2j4TtdmYx0FDVDKmEyfGzNGxqdsfERHMj5EkuFORihQMX61WGuWlhOTOn+iUugymb5zmS/g5aifJ3Q3XmcsktQ04/kN90AF1Zp64JU9WgsPPCT6Kx1/YmUMeqVM8pnGMUYn3pASdDaiyZ3otP/G9b91cagIbJ8r1khQscjn6sYuEROQYUey8/ZTZlt6EVrBSeuAjoOlH5 01ALygS4 CZr9uM4FGBJNM4vJr7YSnwwKDe8B4ln2iP/yjx/BkGC5U4kGyiChKPiTLfdIoFKzAHGskmIzjtAVB/xFX79y6dE2vyxXY59yd+2fGBBMjMdVf9EhTxVvLu29AHSxH3lq1iJtBU2uyWH6z9N0cW/MukCzEnjHx4AFC/gkGSy93o4AK2iI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/10/20 12:47, Christoph Hellwig wrote: > On Thu, Oct 19, 2023 at 03:02:10PM +0800, Kefeng Wang wrote: >>>> Use early_pfn_to_nid() to get correct node id from base instead of >>>> the default NUMA_NO_NODE in cma_declare_contiguous_nid(). >>> >>> Why? >> >> before: >> cma: Reserved 32 MiB at 0x00000000fe000000 on node -1 >> after: >> cma: Reserved 32 MiB at 0x00000000fe000000 on node 0 >> >> I think the real nid 0 is better than -1, but yes, it is not >> a big deal. > > So please document that in your commit log. Andrew write a better commit log and merge it, thanks all:) > >