From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58F82C433FE for ; Thu, 16 Sep 2021 22:18:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CD2BC603E9 for ; Thu, 16 Sep 2021 22:18:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CD2BC603E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 65492900002; Thu, 16 Sep 2021 18:18:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 602526B0073; Thu, 16 Sep 2021 18:18:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 451AC900002; Thu, 16 Sep 2021 18:18:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0146.hostedemail.com [216.40.44.146]) by kanga.kvack.org (Postfix) with ESMTP id 32C816B0072 for ; Thu, 16 Sep 2021 18:18:20 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E439F182321B3 for ; Thu, 16 Sep 2021 22:18:19 +0000 (UTC) X-FDA: 78594851118.08.B76F55F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf10.hostedemail.com (Postfix) with ESMTP id 532CA60019A8 for ; Thu, 16 Sep 2021 22:18:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 405AD22293; Thu, 16 Sep 2021 22:18:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1631830698; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DBzVatUHKFu0Cyk7pN9Ddz6kBstECbffWfHI3HWpgnw=; b=MzpzwYmHK6IHe/Wggxw00m7dOgq0DG4OMOxiM6R+h5+ObovCqHjt6Zgq77+uD2D632RiO2 LBrEiD0wg4qdy/VMn0bPMVBbrWSDH7jUgsvDuKnrfM2bzNlxbudufixfGuFZkdnvHX0Ez3 HraWPUwJ6EBv5cpi52RE3Uir3glCumc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1631830698; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DBzVatUHKFu0Cyk7pN9Ddz6kBstECbffWfHI3HWpgnw=; b=XNR4lite8fITY4tYX0a2WIgmLRwMIqxR2LfY68Wg7YGUP83o2apY6s4r1dJ5f/+WMsM3wm Uhm1EWl3f7GK8QBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1FB4A13D6B; Thu, 16 Sep 2021 22:18:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1wmjBqrCQ2GuVQAAMHmgww (envelope-from ); Thu, 16 Sep 2021 22:18:18 +0000 Subject: Re: [PATCH] mm/smaps: Use vma->vm_pgoff directly when counting partial swap To: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrew Morton , Hugh Dickins References: <20210916215839.95177-1-peterx@redhat.com> From: Vlastimil Babka Message-ID: <738511ae-b253-9927-eca1-97d621d9f149@suse.cz> Date: Fri, 17 Sep 2021 00:17:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210916215839.95177-1-peterx@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MzpzwYmH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XNR4lite; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Stat-Signature: 1wa47rjz73b4fuanukh64szswpwhpkb5 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 532CA60019A8 X-HE-Tag: 1631830699-127142 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/16/21 11:58 PM, Peter Xu wrote: > linear_page_index(vma, vma->vm_start) of a shmem vma is exactly vm_pgoff. Could you use "vma->vm_pgoff + vma_pages(vma)" instead of the other linear_page_index() then? But now I wonder, is smaps_pte_hole() broken? it calls shmem_partial_swap_usage with addresses, not pgoffs? > Cc: Vlastimil Babka > Cc: Hugh Dickins > Signed-off-by: Peter Xu > --- > mm/shmem.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 96ccf6e941aa..2aef5b8e17c9 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -856,8 +856,7 @@ unsigned long shmem_swap_usage(struct vm_area_struct *vma) > return swapped << PAGE_SHIFT; > > /* Here comes the more involved part */ > - return shmem_partial_swap_usage(mapping, > - linear_page_index(vma, vma->vm_start), > + return shmem_partial_swap_usage(mapping, vma->vm_pgoff, > linear_page_index(vma, vma->vm_end)); > } > >