From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69C33C433FE for ; Thu, 17 Nov 2022 11:48:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C02FB6B0072; Thu, 17 Nov 2022 06:48:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB47F6B0073; Thu, 17 Nov 2022 06:48:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7A518E0001; Thu, 17 Nov 2022 06:48:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 97B536B0072 for ; Thu, 17 Nov 2022 06:48:27 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 66FCE160D0F for ; Thu, 17 Nov 2022 11:48:27 +0000 (UTC) X-FDA: 80142761454.12.5A679C7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id D24C814000F for ; Thu, 17 Nov 2022 11:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668685706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VkDO0tN0QVhq9+4ytiHH1Q+NQsFL/NHOuSBEb6Cn4GU=; b=fNlklGim0uUS/UAACh64KERu17mjwMaf3cgd8MXEw9m12N68kgyCoOdesXVJh9izX6gTk/ 99QpsoyBLXks1/Orf7pF3qjedJenvf5+tzH27nI6L9qb4GG59AerPbQ1kpA8WdmzX19LfR e496LKayy2nResyxDLF4kxo5MEeLmYQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-132-MLWtdbLQMZWd_k43_8E1qA-1; Thu, 17 Nov 2022 06:48:24 -0500 X-MC-Unique: MLWtdbLQMZWd_k43_8E1qA-1 Received: by mail-wr1-f70.google.com with SMTP id n13-20020adf8b0d000000b0023658a75751so603979wra.23 for ; Thu, 17 Nov 2022 03:48:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VkDO0tN0QVhq9+4ytiHH1Q+NQsFL/NHOuSBEb6Cn4GU=; b=rtZGoFlMKZh+eBVe/CERZ0pWWDXH4GCKpiYud5rsuHIj5brxkQZjHwcjD+FAI/ftpz o3XpbWrHgPeyIpwbuCTnL/pcpPUtux2TzUCe9v+qOqmAulvBVR/+isPG8zCBW1ywLV1Z 2H5oGzTNGNnOB8Kv4uf9NhVbQU6nSIYeatS6PSYJgFcNV+OybutrdLTJ0Wg+vb1teriI s5R2lieX8VrVW8ubdZykaVjdsMqxQoHYzxMuiGseLbvng9qTrJb0Z9QJ3SlhjpezViZy FqaARK2hJGxLUNClP34biuzGXAegZp6NKns8cObFmmykF3UWnsZ/P8aNI4rRRff7Rauy D/bw== X-Gm-Message-State: ANoB5pkTSe5Siqtoa9yTZftLz2HLXDL0DJyfCpO+yK0iZRkHDn4TZ7Yg fAjPUJLgSc+NrZZed4aglnssa1b5STV/nGft2mFe2/mQsIBPucwfMEcumFv1iJPYStQAmxo2W7x ZT8+WrUNAbF0= X-Received: by 2002:adf:e4cf:0:b0:241:a047:d011 with SMTP id v15-20020adfe4cf000000b00241a047d011mr1264612wrm.258.1668685702239; Thu, 17 Nov 2022 03:48:22 -0800 (PST) X-Google-Smtp-Source: AA0mqf674QznTApmbdD3nTnBkGQgOC8JsrJmb13qrGrKOFNYUOmLozHLVWFFRxtSD6QXoicjTAAZRQ== X-Received: by 2002:adf:e4cf:0:b0:241:a047:d011 with SMTP id v15-20020adfe4cf000000b00241a047d011mr1264600wrm.258.1668685702040; Thu, 17 Nov 2022 03:48:22 -0800 (PST) Received: from ?IPV6:2003:cb:c707:5200:39a9:b834:27c1:4ede? (p200300cbc707520039a9b83427c14ede.dip0.t-ipconnect.de. [2003:cb:c707:5200:39a9:b834:27c1:4ede]) by smtp.gmail.com with ESMTPSA id l8-20020adfa388000000b002417f35767asm824276wrb.40.2022.11.17.03.48.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Nov 2022 03:48:21 -0800 (PST) Message-ID: <7379a953-5a87-7978-b413-3d52b9b55795@redhat.com> Date: Thu, 17 Nov 2022 12:48:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH -next] migrate: stop using 0 as NULL pointer To: Yang Li , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Abaci Robot References: <20221116012345.84870-1-yang.lee@linux.alibaba.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221116012345.84870-1-yang.lee@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668685707; a=rsa-sha256; cv=none; b=W/XEtSKA4f0FyLMrj+tu+/h5jRjtnPBIJA23MCMdFggF08BCuzb3pGeZaPWFv8KexIZvxj 7WR2+ypkAgB9/WxErWBH0UvnUzq4atfxGSUh/e1wqlnfyooW4BsyIQueV4Yzj+ZRXj2cB1 S5hKm+Cpg6Q8cYvO+hnkQRX34NZ+vQk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fNlklGim; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668685707; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VkDO0tN0QVhq9+4ytiHH1Q+NQsFL/NHOuSBEb6Cn4GU=; b=wjA9/LQCpoSwKZZ6VZ/pRbI3qqF7/PCY8Utn9HKtbopVMtbWBKcewAVw3lo+GiHCT+//0g bmpsejYDeBWBA8dlu+I5H9yju8+Xvwlepo/AVGxwGj99gGR2OZFaT4GYXjByhDhqUP8cg1 I3kTdCxEIPn+UbXG7jsmLieBkjYEprA= X-Rspamd-Queue-Id: D24C814000F Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fNlklGim; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 5txr3toq9znzapwcm73fps5hnu6we374 X-HE-Tag: 1668685706-116592 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.11.22 02:23, Yang Li wrote: > mm/migrate.c:1198:24: warning: Using plain integer as NULL pointer > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3080 > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > mm/migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 15dc56a3da7a..e50b3c42e6ad 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1195,7 +1195,7 @@ static int unmap_and_move(new_page_t get_new_page, > return -ENOMEM; > dst = page_folio(newpage); > > - dst->private = 0; > + dst->private = NULL; > rc = __unmap_and_move(src, dst, force, mode); > if (rc == MIGRATEPAGE_SUCCESS) > set_page_owner_migrate_reason(&dst->page, reason); Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb