linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Yang Li <yang.lee@linux.alibaba.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] migrate: stop using 0 as NULL pointer
Date: Thu, 17 Nov 2022 12:48:20 +0100	[thread overview]
Message-ID: <7379a953-5a87-7978-b413-3d52b9b55795@redhat.com> (raw)
In-Reply-To: <20221116012345.84870-1-yang.lee@linux.alibaba.com>

On 16.11.22 02:23, Yang Li wrote:
> mm/migrate.c:1198:24: warning: Using plain integer as NULL pointer
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3080
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>   mm/migrate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 15dc56a3da7a..e50b3c42e6ad 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -1195,7 +1195,7 @@ static int unmap_and_move(new_page_t get_new_page,
>   		return -ENOMEM;
>   	dst = page_folio(newpage);
>   
> -	dst->private = 0;
> +	dst->private = NULL;
>   	rc = __unmap_and_move(src, dst, force, mode);
>   	if (rc == MIGRATEPAGE_SUCCESS)
>   		set_page_owner_migrate_reason(&dst->page, reason);

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb



      reply	other threads:[~2022-11-17 11:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16  1:23 Yang Li
2022-11-17 11:48 ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7379a953-5a87-7978-b413-3d52b9b55795@redhat.com \
    --to=david@redhat.com \
    --cc=abaci@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=yang.lee@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox