From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 094ABC61CE8 for ; Fri, 6 Jun 2025 11:52:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97FA46B0092; Fri, 6 Jun 2025 07:52:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92FDF6B0093; Fri, 6 Jun 2025 07:52:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81F6F6B0098; Fri, 6 Jun 2025 07:52:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6351F6B0092 for ; Fri, 6 Jun 2025 07:52:52 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1BE3FA09BC for ; Fri, 6 Jun 2025 11:52:52 +0000 (UTC) X-FDA: 83524814184.22.D1B2EAF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id E7ABB1A0012 for ; Fri, 6 Jun 2025 11:52:49 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=al+zkC5X; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749210770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z+FEbX3L9HmrbUYpED1MkPniL68fqNN+10/AKObI0A4=; b=0fIJ8xCq/PRiXiTgXB9/TYinB3XzPcN/f1A6RdAJXseut7DQTs+ifGfsNtLPvd96lSg3aB yq7RBJ+ISsWS+WqubVYdjOm0AhSyZpe1zJkPoLXH/UnA3Hoyzk/658bBBzScJt46s4Zu6e cVmAxXw3O48PTsS3ucR4NAl8cYCCTjY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=al+zkC5X; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749210770; a=rsa-sha256; cv=none; b=3kDlqc0+sEZdb+0i3BnmS6tZUFkxr/ZWYJIssJqn7xClg0pQCdDEwsIJB1+HfSQb4xmcir /qJnmq6/VGDe2JuEv5JtV0RZKhHL9jz61w3dsa10m1tJMTrixmeR+sV2tUMWQ3UZjmAAN1 Xv8/+SRyLSXabKC76I5FBGZvYYGbiY4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749210769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=z+FEbX3L9HmrbUYpED1MkPniL68fqNN+10/AKObI0A4=; b=al+zkC5XnDfL1ZU6sHKVqI8u7GVNWNZsHXGl3sma/YR3qZUlBMmXYb7zS3Wn6PAFJXzuV7 7oWW9RcykuZeuTftzzRyzdxZwXmqXTZwMxgipOHz1EmZSh0AxO79cb1vMQszlFmodMO79p tLCacHQ7oKUAti+qfqDoh0UeQHWIAMc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-576-IF_HATpbMlmkadpHcxFr9Q-1; Fri, 06 Jun 2025 07:52:48 -0400 X-MC-Unique: IF_HATpbMlmkadpHcxFr9Q-1 X-Mimecast-MFC-AGG-ID: IF_HATpbMlmkadpHcxFr9Q_1749210767 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-442e0e6eb84so13552655e9.0 for ; Fri, 06 Jun 2025 04:52:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749210767; x=1749815567; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=z+FEbX3L9HmrbUYpED1MkPniL68fqNN+10/AKObI0A4=; b=WzzJrAHxVuPTz7SMJJbHisLP02koyD9EmDh3e5mPSCAY/47QXnYAL+ypd2AuzEvn2V UsqqsUUV8acurXrwNgPo7WuXXzl+YKgynbtDg9/ba7i8b8XU8YkKGWtbZIHIVCCmYiOt JTo1q3Kp4Y6SYP2CwLVL/sHqnbymMZ2z5BIQ0t0MSDmAwRLZyTbQJA4OLxcryE8LiGkS gBJDJSQzXwqnT03JIw/5N5No2VeMunM4+AvZmuqNPcLhcMibPkG6u23k+io4thmg6mg8 vxgBkI1YPKzVRy54iUnhpMnnPqOrik0iyC0TaD9vQayCx1LBQa7c4asTpvIKcB6Z6/d7 RY+g== X-Forwarded-Encrypted: i=1; AJvYcCUdfnlC77ZX18RVoCBZwTbr0B02o83CeOOYMXTkhxtv/RWfCFLyMqSPDZ9z+CCpAhEGdEQYnR0dxA==@kvack.org X-Gm-Message-State: AOJu0YxLiglVAbj0THAoQZNl1zLPjlQNhpw9IQBc8R3SjzIsE8tX9Btu pq+8b9DBkYMdF0gaM6uFIR/vUqKtgEbspfRsv+tSCnGTgZAtEheULEgrwZfqdvz7/FX4x+5MlTi myRH3LpS7R2pVTAPiwgOZWiaR6ufq2xgba5yTRb2XaU014YbXQbP+ X-Gm-Gg: ASbGncuWHd6KHAv/nc+/RfqyG54GmJ52Ed9b7Z8fL6HQq2pXmK25/yj77xXGBLc5CUG nknV+9UoC9yMN2SLBjRyejULWhRsunledWubp6lILhtJ0kpPNynhi5dZlRPjfTBTbMgT810D3d1 5w+xNdkc+648C5myD8vdtocwgQRVdFUZJmnIQ8ZJNAz9t3kk6uUdmjETXQwOJEMD0xeGY/wStRO B4Yi4qplbytIsRUGdIaoOESpFNsv1RySbVM1775iBNN4C2gcKHbSIPDvJ0z7IjoeQTXBZoEsSK6 55ZR6QPmiUitKXid2wowJBEKR3hCVTb8MiM34Tu4RTaAWZyW2c0wgT3f/Gp3vrMwueJOldx4nyW 2s7pXjuEDwmNw2vOfGc4ZiqauKNfbvrTp3GtLFJ5V8A== X-Received: by 2002:a05:600c:4e0a:b0:450:d614:cb with SMTP id 5b1f17b1804b1-4520143085emr30492595e9.33.1749210766854; Fri, 06 Jun 2025 04:52:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGebp748ZUJlgbYSDwhtX4XrCnpmqEcIzPAJIqqCkpY9vlhyhbH+iXq1p9Qo3rMj0g75gatzg== X-Received: by 2002:a05:600c:4e0a:b0:450:d614:cb with SMTP id 5b1f17b1804b1-4520143085emr30492375e9.33.1749210766490; Fri, 06 Jun 2025 04:52:46 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:9c00:568:7df7:e1:293d? (p200300d82f199c0005687df700e1293d.dip0.t-ipconnect.de. [2003:d8:2f19:9c00:568:7df7:e1:293d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53243664fsm1675690f8f.65.2025.06.06.04.52.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 04:52:46 -0700 (PDT) Message-ID: <7375c9c2-42f4-4c90-ba16-a365857d91d0@redhat.com> Date: Fri, 6 Jun 2025 13:52:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 08/10] kernel,cpuset: Use node-notifier instead of memory-notifier To: Oscar Salvador , Andrew Morton Cc: Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250605142305.244465-1-osalvador@suse.de> <20250605142305.244465-9-osalvador@suse.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250605142305.244465-9-osalvador@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 78q5GujMLpvfCMe2YjkKGHqBVsCSAmI00sSHa8SljIc_1749210767 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E7ABB1A0012 X-Stat-Signature: namwm8wo7tjb44s1b37463ac643p8ajw X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1749210769-622529 X-HE-Meta: U2FsdGVkX18v0FS2pt0JcUgqCH5AqLc/lOWw8D7ckkAZUXxnkCtfitQxKtjNcr8FGt6KOZFyxcpnOgryzS6oojv/mHKH5bohMjdZnGf3C6Y9+gOgkO6W4u1WcEbhi1q0lTlAge2PIXVwta/QPu2xfGNGFwIi+imjJgBCKuw2XBTs3nQ2epQETB3nk7aPbp+Lwdn+j5DU5QaiAz0BgyPPX54M/WSwPOwHGlrTXUFfFUfg3eJhotlusSCx7KsW9dUyf5g29ApBIad21sgMOnu6eB9DfJrhz5FFaNnv04+mAoaGbytj/QIJLqz4kjL0bqDsw7/0NGOjGBKGm1KBQGzFkumsn4Dqz/a6H0cUKgw39YP3aPPOv9+FKAvecuee+Gp5cVKsDostHo3WHJ9UrdZD+PFDaag96ZiJw72IFukZfqO0yi/d4dghAXfAw9x2dgJ10SW2m+HViXMxjCb+S760zbT4Qhzt2k2L9O8Al69kRwTk0qgS96uU4MDO0QCIiKmUcUFjfY2gBkrxGSsOYQxe0nda/eUoE6P0+GM80n0OYurnnrVUFMjYE+Ku/wfxBpxne21uueqRAKHPKpLvrPqKgqEG/7h7x6eSm9pgB6KvyWNOU2T/6BptN426dop4jiKq8B0MtU5GHeEh9Rlx0PmPHwkV1nXttumi8+PqsPEEUW+oBgX3mAc7UlKua2MLyfMapuXxQ1S/3KlNvTvBJZV/KVjLBfDTlBMVVbOFrvZ/pe+VpnzodVgHjWAB3nAu/ScnvPSMOnX/BdjNQspl7FmGyetVfo0qk3239fQt9zNlbUu2ochrIQMyBUJnHsfNN2jZoMyAJjttkxpACmsDMwyPyvPexej52ZG9f93WcpFJ8q3IbXq70wG52JhA6qXZKND9om/TJ2bodNxcTwf8h8IEVT0wsozkaHav49sBvCGEOY+gi6/6n64B8HO3Lo8VdZ5CDx3Oar59jHPVGOWdSmx pIC4OPXe k8w3GDjlE75I2S74HK1i/O5LlEFrgzmFHm57pF5i8W5uXXXwj2X1VW7cwVC24PH0vqgWnYI7qJv7Hb3sBwBJcdVMCI5R9NZVf36b5x0LHA6t0ysXXndeECsbEe6nGTpIAtdkYHJ3uQQ4b2umtedqBqvsJaQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.25 16:22, Oscar Salvador wrote: > cpuset is only concerned when a numa node changes its memory state, > as it needs to know the current numa nodes with memory to keep > an updated mems_allowed mask. > So stop using the memory notifier and use the new numa node notifer > instead. > > Signed-off-by: Oscar Salvador > Reviewed-by: Jonathan Cameron > Reviewed-by: Harry Yoo > Reviewed-by: Vlastimil Babka > --- > kernel/cgroup/cpuset.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index 83639a12883d..66c84024f217 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -4013,7 +4013,7 @@ void __init cpuset_init_smp(void) > cpumask_copy(top_cpuset.effective_cpus, cpu_active_mask); > top_cpuset.effective_mems = node_states[N_MEMORY]; > > - hotplug_memory_notifier(cpuset_track_online_nodes, CPUSET_CALLBACK_PRI); > + hotplug_node_notifier(cpuset_track_online_nodes, CPUSET_CALLBACK_PRI); Interestingly, cpuset_track_online_nodes() is only concerned about "after node_states[N_MEMORY] change", so maybe we could filter out more events .. maybe. Acked-by: David Hildenbrand -- Cheers, David / dhildenb