From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9D75CDB47E for ; Fri, 13 Oct 2023 09:06:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60BDC8E0010; Fri, 13 Oct 2023 05:06:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BC218D0015; Fri, 13 Oct 2023 05:06:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AA6E8E0010; Fri, 13 Oct 2023 05:06:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3AB828D0015 for ; Fri, 13 Oct 2023 05:06:29 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 069CDC01C4 for ; Fri, 13 Oct 2023 09:06:28 +0000 (UTC) X-FDA: 81339857298.22.3520AF6 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf21.hostedemail.com (Postfix) with ESMTP id 1AB2B1C001C for ; Fri, 13 Oct 2023 09:06:26 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=ByktosJ1; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf21.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.218.46 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697187987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=ICdCbc96AfhpeUwF2FpVWUFYN0NDR/8vF+plEaKQfdg=; b=4o7cK6axRUrVmr6w8vWXi7RyvF3CouLAXdbJKGP866mumIzlcFbb+bmFjy0MhNX73LMD3y NXgkmz8ryNzWbiRenpOjK3Ij0nx62UPhsdFFpGKr/pmdK2sB7ePmZia5byEeutfKSlURzg c5HenG8rZ0SyCCiky2WjXSc1DKFPooI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=ByktosJ1; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf21.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.218.46 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697187987; a=rsa-sha256; cv=none; b=by3ny+Coud+3cacRuGQ7+RxN8nU5DNhwQahWAwCJmfiEgIRwJYeOT55AH4O3vrp4LzVt/i 38QuM1kXIpVPwo8lvv/qB1lcRgMZCjZBYSZHQHlBmlUA60q+98ZgPqAH+nPNWrTyHIccM1 cHv5p3h893FVlmbJNCm4ymn6B7RYDR0= Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-99357737980so306231866b.2 for ; Fri, 13 Oct 2023 02:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697187985; x=1697792785; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ICdCbc96AfhpeUwF2FpVWUFYN0NDR/8vF+plEaKQfdg=; b=ByktosJ1ErqUnGosMRMUih0hPQxPmoU+fHGZDkuMca1LJnAgyDEkNBAjsGPHUJqjLD Q0y/pBLD15M9sk+BAH7luoSwD2/MEhNqXFiJHwv4Ia35RIkrWJi6z222zSBI7cXgtrD4 JkFc0Z+nKpvbfb+RGiZrIwWXAqlfM2kjGkdsu0BoxzBSHoCDvqqJNolEIkXMcajost+E OUe2C5IIPphllN68eMKAav7fU0GeeZNNTN45XupeOvWTltlwLujouvjT3Ghu/2SJfA6A Czy7QRmw2o5/kfO7tnjDMb3DMOPoK3cflkedvG47O+IJbjF7m5iZoT4bRoWg9xtNX3X4 nPuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697187985; x=1697792785; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ICdCbc96AfhpeUwF2FpVWUFYN0NDR/8vF+plEaKQfdg=; b=g2wXaVoAa/9oUJVKjTK+eQ5Cma4TP99crSdNIQRt0RWaIbA+5NGCfPsyKhFJqM4tSa GV8XB9oRUR9+5OY3kugcl5EvVwixh0+c+EgcUpXDx3Qnr5Z55HRABOXdNLSSLlgSJiEe GB78984K4NjgeYFzIBc8ZS2DCqFP9mLEUEkxTjTY7OIIrzUVP9k8jW5MIfZwv0Mzz5Hn PCFC4shWpQt27OWBtdl0XM70PMemzaIseVCB4O21TqNanAg+RAr8QxYAJYFw/LpS4dky YZAFfoGgRIlU4e1a2xF0Ck+BvxQHvD+FyxM5R2Xndyc1U9p7vxEwbSD7M9wUKyAI90U0 y2QQ== X-Gm-Message-State: AOJu0YxINO+OY4XixMPyqo1tYfIjywSEImTZdrvCPniACQwP6c6eL/wi yXOL5vAby/oIBP6JM4aemXU67A== X-Google-Smtp-Source: AGHT+IGheZ3hBkvdUTSIt8pjKSA00ZURPxw9q0BWrE34pvKkMrrsnMhMvLBO30xGYqJtAPo5/PbM2g== X-Received: by 2002:a17:907:75f7:b0:9ae:658f:a80a with SMTP id jz23-20020a17090775f700b009ae658fa80amr22490267ejc.48.1697187985523; Fri, 13 Oct 2023 02:06:25 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id a11-20020adff7cb000000b00326f0ca3566sm20231469wrq.50.2023.10.13.02.06.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 02:06:25 -0700 (PDT) Date: Fri, 13 Oct 2023 12:06:22 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, "Matthew Wilcox (Oracle)" , Mike Kravetz Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, "Matthew Wilcox (Oracle)" , Muchun Song , linux-mm@kvack.org, Sidhartha Kumar Subject: Re: [PATCH 2/3] hugetlb: Remove a few calls to page_folio() Message-ID: <736ebb93-76d4-4096-8b73-657a9698e043@kadam.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230822162808.4131399-2-willy@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1AB2B1C001C X-Stat-Signature: 9f5pxghzg78xwwrtjjt95owyed87nay6 X-HE-Tag: 1697187986-110994 X-HE-Meta: U2FsdGVkX182Dq0c8V4t596uk8J3X/wYN9Izh24hOjwsK2nOjP7qgyk8YpDCWVrJU4/v+VK5YVxNpUoybTryzSNBodRYQZlrOyvywEwLl08Qe0pLG09HEFRhVL77TH6B5fjRj1jRb5bz/T2hZYjkRR9trtwT6oyuGZ7o/xlCsM0ZoiDm87WFG6GPD0Klnie/qri7mlk8mM0sMWsk3kpWph7ijPgotFxql5oWhrR4QgPs/Z7dXes52zl1lF5eJZvfMct8qeYKkOgjZ7OgtDUwska1ypzj4zpSYT9QQsZ6PoYi7D4g0Ern4e66+H/YgMfbSGVK30oTLthUQLpQvHnmxZu/xDW3+BdRtHEMF7Yb84bSNCHlraVz7jE46tyZFmhC3k/h2JIzIvhDhjR8PRo8OQtTtZoTGSlwpE4KXCM61ZF+wCWoPomlyQShRfO9FHZJkXbfTH0pCwNnV+VHiwpdtbWXRrfOKum467HiPBYhb/7V90flJCkV1RQtwbA8hs4imO9IWaw8xIu2euABvBq1ZtXyLRuN1NTVFQFFs5Y9riLaRjumLiijJCeAei+wBvOJxjQD9j9zf5zwOigjwqiXyUpRXOuZlRl0R0rS0Q2LphJqqUk2/4QeYkl+d1MG3KxMMX2YiQ3i+M2FjYquWL2SUqc43nNKi0sY5IXbucn7QsSV4GbXOIYVtSTtFTXM6ZztOE8dMVyN4nzmxh7GkOkubzdL+mevjBtoIw3QIXlVdQoAgkJMCqJEUiq7jR0WrxBoI3UoLsPqqZbE4qBf/0iJbEs/5lueR/2JfgDFxb/s8iLGGPl6vi/IyRoqDJ06jXP7IYqNA76CatlgOjIreVUy6QRKwSifw+JznYct9qPL3PW8l4UaT0fWMAoW9ujTmn9JsEwGRNA8iKBjMFov4xBQ5eIFcLgkv9pVJpMwC7xG8JMkXMjJ34MuEHhpcKFcVi+q+Em0JhNuFBUSTwJkkP+ D7i/qNLc 1lQuEY0L7QmZxPuQ1O7CvL3lib4lEl5SZD7bRNd/HNYPe+G/gvTFuMGE2OxEvyuewen6FYwrra9wGyhMUwzgzEsqNtvAOljZDO57LkRcvnKZv/z6zRKDa0ITE3FhQxsGXXdAy++yabjWickzZQLTKgfiCa8I+oh/ZYFVsW40Dh/M8ZLFDY77jpA/pR3LVUcwGzwcB1OUPMKcRa6dEIEnBJYxRAtOfCGhk/DmXoaC/QW6aiaG7i4gNxEhclfTBk8DPikCrinsBRhJXNKXHh+PVCHqW52P2vfZ3Wx9dgC2NdAuZsgrxykBcuxaeGbuaq1eXbXRYlkEMhbJL6SJ8OOiR96DcXMf5qiv5w5d0XCzW1q9nJhANUDAuzdT7TLPrZl1dzcP7lWEuCsuWPhImmGfJQAG+sT9xDjxF3v2/1V3VaGCV67odGIV/UAormdwtWdTF2yxNPwOF9rTnfrxrVTfVrY33uQQuw8sAbCme752cMH9Bd9SLjj5sv1SghRMqoF+HsW3kfivmyz71+QsW21neDV0otug4kbukaLPBUx78C1Nog4Wx+465gZCBV/4/oZpORmGZm/MVSAeNfbOaGtTfrwl82L7nGOowSbn5V40nC3182QiUT7vSO8JOtrI3ictvlLsPzrnbAjX6MLDQxu8AUQktp2wJZu040wWE9pX2/7N2EPGd3KfOx/sZyj0JhIYdXnyj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Matthew, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Wilcox-Oracle/hugetlb-Remove-a-few-calls-to-page_folio/20230823-002932 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230822162808.4131399-2-willy%40infradead.org patch subject: [PATCH 2/3] hugetlb: Remove a few calls to page_folio() config: x86_64-randconfig-161-20230827 (https://download.01.org/0day-ci/archive/20231013/202310131039.ZgssYfIB-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20231013/202310131039.ZgssYfIB-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202310131039.ZgssYfIB-lkp@intel.com/ smatch warnings: mm/hugetlb.c:2246 remove_pool_huge_page() error: uninitialized symbol 'folio'. vim +/folio +2246 mm/hugetlb.c 10c6ec49802b17 Mike Kravetz 2021-05-04 2224 static struct page *remove_pool_huge_page(struct hstate *h, 10c6ec49802b17 Mike Kravetz 2021-05-04 2225 nodemask_t *nodes_allowed, 6ae11b278bca1c Lee Schermerhorn 2009-12-14 2226 bool acct_surplus) e8c5c8249878fb Lee Schermerhorn 2009-09-21 2227 { b2261026825ed3 Joonsoo Kim 2013-09-11 2228 int nr_nodes, node; cfd5082b514765 Sidhartha Kumar 2022-11-29 2229 struct folio *folio; e8c5c8249878fb Lee Schermerhorn 2009-09-21 2230 9487ca60fd7fa2 Mike Kravetz 2021-05-04 2231 lockdep_assert_held(&hugetlb_lock); b2261026825ed3 Joonsoo Kim 2013-09-11 2232 for_each_node_mask_to_free(h, nr_nodes, node, nodes_allowed) { 685f345708096e Lee Schermerhorn 2009-09-21 2233 /* 685f345708096e Lee Schermerhorn 2009-09-21 2234 * If we're returning unused surplus pages, only examine 685f345708096e Lee Schermerhorn 2009-09-21 2235 * nodes with surplus pages. 685f345708096e Lee Schermerhorn 2009-09-21 2236 */ b2261026825ed3 Joonsoo Kim 2013-09-11 2237 if ((!acct_surplus || h->surplus_huge_pages_node[node]) && b2261026825ed3 Joonsoo Kim 2013-09-11 2238 !list_empty(&h->hugepage_freelists[node])) { e601ce76a2aabd Matthew Wilcox (Oracle 2023-08-22 2239) folio = list_entry(h->hugepage_freelists[node].next, e601ce76a2aabd Matthew Wilcox (Oracle 2023-08-22 2240) struct folio, lru); cfd5082b514765 Sidhartha Kumar 2022-11-29 2241 remove_hugetlb_folio(h, folio, acct_surplus); 9a76db09970938 Lee Schermerhorn 2009-12-14 2242 break; So we're always guaranteed to hit this break statement? e8c5c8249878fb Lee Schermerhorn 2009-09-21 2243 } b2261026825ed3 Joonsoo Kim 2013-09-11 2244 } e8c5c8249878fb Lee Schermerhorn 2009-09-21 2245 e601ce76a2aabd Matthew Wilcox (Oracle 2023-08-22 @2246) return &folio->page; e8c5c8249878fb Lee Schermerhorn 2009-09-21 2247 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki