From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C543C4345F for ; Tue, 23 Apr 2024 03:56:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD4C86B0083; Mon, 22 Apr 2024 23:56:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B842A6B008C; Mon, 22 Apr 2024 23:56:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4B636B0095; Mon, 22 Apr 2024 23:56:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 858BC6B0083 for ; Mon, 22 Apr 2024 23:56:43 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 25FC81209AC for ; Tue, 23 Apr 2024 03:56:43 +0000 (UTC) X-FDA: 82039435086.23.171B350 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf08.hostedemail.com (Postfix) with ESMTP id 62A23160006 for ; Tue, 23 Apr 2024 03:56:39 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713844600; a=rsa-sha256; cv=none; b=TV96zvkk7wgxgCwei+x+GaFU2CwTdH6tf6MaESjf1NJyM7r/peg8xETb9z3zSwGjYWtDmw NTclJgd0S0JrCr5mSFgJhCsHJI2GhxXkJA29MjWXDkWvsluu9PrVkHsHDlhSLII0IXNIiD m0V7pzz2HgpuIHmiKNYhi8npfMYnM9k= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713844600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r179IgCSIpuZ32/vRFFivP2II1lfjAMRzfpcDFvivcA=; b=sLP6WOLLNLjoj8rvP4e6rjuxbHnSEADMCznMRsDphTyY/RixJHeJ91BCOJAOFf4brqGhVV Sf1yZBlEjsDnpH8N6NA2OUGeH9v6PwCdqmR01jyBHgBBgScU3jqBWu19OVqD3Z4UB+uFIt WuR+BXLk2vPQ0x5QP1uRQ+/dWHHu/lY= Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VNpBR3m9zzvQ4Q; Tue, 23 Apr 2024 11:53:35 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 891CD1800C2; Tue, 23 Apr 2024 11:56:35 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 23 Apr 2024 11:56:35 +0800 Subject: Re: [PATCH v2] mm/hugetlb: fix DEBUG_LOCKS_WARN_ON(1) when dissolve_free_hugetlb_folio() To: Andrew Morton CC: , , , , References: <20240419085819.1901645-1-linmiaohe@huawei.com> <20240419141134.464ea3a1ef3d0e93c6711c93@linux-foundation.org> <000d75f3-6e16-6b91-7657-afb954773381@huawei.com> <20240422142115.25582386f7f02df817eab8ae@linux-foundation.org> From: Miaohe Lin Message-ID: <7364e90a-1a55-21da-b579-52e7396fe266@huawei.com> Date: Tue, 23 Apr 2024 11:56:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240422142115.25582386f7f02df817eab8ae@linux-foundation.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 62A23160006 X-Stat-Signature: h7pj6de8khgw97gjf481t6uhipz9xkm3 X-Rspam-User: X-HE-Tag: 1713844599-114782 X-HE-Meta: U2FsdGVkX19xOYMimR8OpyjnQqoL0TOdmVWx6o4RmF63L1jCztjWYQnqtgDlmR2JCZJvXqHCCqh/trpIB2l7k0tQ2kr6knDCs8x7htYR4rPbbnhxqT8jBTzhGQUEZdkRCOWBgQaHZk8Dl0ch2+oOkIoIe4Vs4CYSRkCxB/K7O7I8y3TUXUqQeP3cJuOdW/Ydg3j5F3KuVw3LWRyOnF25nnKdZVCKhp1LgCHJJsZ5JE5YJ9uV7CznQK8+Zo4vEzvE1bOuJCGUwbxo2qjsBxi/Zq72KpskFRKO2nf6FSkI7rLApRAy5G6EuQIxQdd650z8DKMcKRQ8a8ZnwpRqjYAV8TYcH4VTvYgF1bdmmJJq/NwOMOLb7coghW/Hn+fdKXF1vXVA5xO4UazSpFh9bVHX8JAkATCyEt5mG9bMXgAUdSrxQN6hveZl4CNewqhyo0ADfiLZT3ztppS7yjw7qy7bmhhCWzh94tT/CZ6GZWnm10nqblYvs6anMcTkJlfGLWNVC6k/XN1HCwCH9BLMI76rtWcOjM7twGUJcqK7F79fhL+zA3vMFOL5S+ZqPfeAexpvGT5D+hYYDfsXO2BUh8B3xEUlmx3xOe2BjKPxpikSsqFOQMBRUVfREoG70tt7BJzgWHlGS61+N/fRIBh8SNPl7x/8N4sUFv4uc2Lvp4ATfrEa34wWzPV6pw3uWwiYYEWsbj/SP2YGBMvSQvJjYpEPCd8pSv6ZDzYtgrVMeO38kcGZbhARakvE3nKqfgJewmNPWv16qEqZnUEDr0OJsoj1z5QXG+F7IzH0g787IHTNiP1AGDRauquKolwgtis2l0IniMUebnj48gsVo+3lrZxs+fe9AUjflm9OIuOaqbK7ovPJrH3brEjcnfBe/5SIymp/SMS65yQpIL48KJP/6h+PPmRUAuKb8IFnoAmqdtEO/eFAa0HPMl2tZBvHpZ8G6nprdpZc2cNr6PjeyWBWylR FCNa40Mn +FdSzBwo7t2JtPgJE1QTb440uLYWT9s6b4GPSGHBAnU2DBoeJIUYPGZyfjQP7FY3IyQdsYW8Ee/umxivZRKhTAzbT7zNyOjPkjcYhHMqoNZnurSX+IYrHVlSu1sMa8qY0GNAsOdxMhPx8sUFvAeVPP9AZR6FeVuw6ntBdiVW5g9HGrGLBBLPkfaBqiumDkHmZ0/6gPyNbHzsWb1U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/23 5:21, Andrew Morton wrote: > On Sat, 20 Apr 2024 10:13:06 +0800 Miaohe Lin wrote: > >> On 2024/4/20 5:11, Andrew Morton wrote: >>> On Fri, 19 Apr 2024 16:58:19 +0800 Miaohe Lin wrote: >>> >>>> When I did memory failure tests recently, below warning occurs: >>>> >>>> DEBUG_LOCKS_WARN_ON(1) >>>> WARNING: CPU: 8 PID: 1011 at kernel/locking/lockdep.c:232 __lock_acquire+0xccb/0x1ca0 >>>> Modules linked in: mce_inject hwpoison_inject >>>> CPU: 8 PID: 1011 Comm: bash Kdump: loaded Not tainted 6.9.0-rc3-next-20240410-00012-gdb69f219f4be #3 >>>> >>>> ... >>>> >>>> --- a/mm/hugetlb.c >>>> +++ b/mm/hugetlb.c >>>> @@ -1773,7 +1773,7 @@ static void __update_and_free_hugetlb_folio(struct hstate *h, >>>> * If vmemmap pages were allocated above, then we need to clear the >>>> * hugetlb flag under the hugetlb lock. >>>> */ >>>> - if (clear_flag) { >>>> + if (folio_test_hugetlb(folio)) { >>>> spin_lock_irq(&hugetlb_lock); >>>> __folio_clear_hugetlb(folio); >>>> spin_unlock_irq(&hugetlb_lock); >>> >>> Please let's prepare backportable fixes against current mainline, not >>> mm-unstable. Because fixes against current -rcX and earlier will be >>> upstreamed ahead of the mm-unstable and mm-stable material. >> >> Do you mean I need to send one fixup patch against mm-unstable and another >> one against current mainline? > > Against mainline should suffice. I normally fix up the subsequent > merge/build fallout. If that gets too risky I'll ask for help or I'll > outright drop mm-unstable patches and shall ask for a redo of those. > This is rare. I see. Many thanks for your explanation. :) Thanks. . > > . >